Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

2016-10-24 Thread Prasanta Sadhukhan
Please find modified webrev with Linear/Radial Gradient NO_CYCLE option catered through quartz api and REPEAT/REFLECT option catered via raster path. http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.02/ Regards Prasanta On 10/22/2016 9:28 PM, Prasanta Sadhukhan wrote: On 10/22/2016 4:50

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Brian Burkhalter
Hi Jay, I also looked for a link for BMP but did not know which would be reliable. Is that the case for the one you suggest? Also there is the Wikipedia one [1]. Thanks, Brian [1] https://en.wikipedia.org/wiki/BMP_file_format On Oct 23, 2016, at 11:14 PM, Jayathirth D V wrote: > Changes are

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Jayathirth D V
Hi Brian, Yes we can point to Wikipedia link. It will serve the purpose of giving basic information related to particular file format. Thanks, Jay From: Brian Burkhalter Sent: Monday, October 24, 2016 8:22 PM To: Jayathirth D V Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-816

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Brian Burkhalter
Hi Jay, That works for me but there is no precedent for pointing to Wikipedia from JDK Java or HTML files. I wonder whether there are any guidelines on which external sites may be linked? There is also this one [1] which in turn points to Wikipedia and some other references. Thanks, Brian [

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Philip Race
Do not point to wikipedia. If we must point to external links we want to point to a specification in the most "official" place that exists .. one maintained by the owner of that spec. Strictly that even becomes a part of the SE spec. Wikipedia is not a place we'd ever want to say Java SE relies

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Brian Burkhalter
I suspected as much. Could be that for BMP we are out of luck as there is no “real” specification AFAIK. Brian On Oct 24, 2016, at 8:30 AM, Philip Race wrote: > Do not point to wikipedia. > If we must point to external links we want to point to a specification in the > most "official" place th

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Philip Race
I've poked around the Microsoft website and didn't turn up a location I am sure we could rely on. A top-level link to microsoft.com and some words that the format was devised by Microsoft for Windows may be the best we can do. -phil. On 10/24/16, 8:54 AM, Brian Burkhalter wrote: I suspected as

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Vadim Pakhnushev
My go-to place for BMP spec is https://msdn.microsoft.com/en-us/library/dd183391(v=vs.85).aspx which is where we point from JavaFX docs. Vadim On 24.10.2016 18:57, Philip Race wrote: I've poked around the Microsoft website and didn't turn up a location I am sure we could rely on. A top-level

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Philip Race
I think I saw that one but the weird final part of the name put me off. For comparison here's how they reference the OpenType (font) spec :- https://www.microsoft.com/en-us/Typography/OpenTypeSpecification.aspx -phil. On 10/24/16, 9:10 AM, Vadim Pakhnushev wrote: My go-to place for BMP spec is

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Brian Burkhalter
The content of the Bitmap Storage link looks good but the hyperlink is rather strange I agree. Perhaps the BMP link issue could go under a different issue as this has nothing to do with TIFF? Brian On Oct 24, 2016, at 9:34 AM, Philip Race wrote: > I think I saw that one but the weird final pa

Re: [OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

2016-10-24 Thread Philip Race
Can I get a 2nd reviewer on this one ? -phil. On 10/20/16, 3:52 AM, Sergey Bylokhov wrote: Looks fine. On 20.10.16 2:35, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~prr/8168364/ NSPrintInfo is an Attribute so it can presumably

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Philip Race
+1 to that .. and +1 to the webrev. -phil. On 10/24/16, 11:35 AM, Brian Burkhalter wrote: The content of the Bitmap Storage link looks good but the hyperlink is rather strange I agree. Perhaps the BMP link issue could go under a different issue as this has nothing to do with TIFF? Brian On

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

2016-10-24 Thread Brian Burkhalter
I filed https://bugs.openjdk.java.net/browse/JDK-8168609 to track adding a format specification link for BMP. Thanks, Brian On Oct 24, 2016, at 11:41 AM, Philip Race wrote: > +1 to that .. and +1 to the webrev. > > -phil. > > On 10/24/16, 11:35 AM, Brian Burkhalter wrote: >> >> The content

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168498: ExifGPSTagSet and ExifTIFFTagSet should use string literals for String constants

2016-10-24 Thread Brian Burkhalter
Updating to simply use a double-quoted string instead of a concatenation of chars. Thanks, Brian On Oct 21, 2016, at 12:18 PM, Brian Burkhalter wrote: > Please review this trivial change at your convenience: > > Issue:https://bugs.openjdk.java.net/browse/JDK-8168498 > Patch:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168498: ExifGPSTagSet and ExifTIFFTagSet should use string literals for String constants

2016-10-24 Thread Phil Race
+1 -phil On 10/24/2016 12:49 PM, Brian Burkhalter wrote: Updating to simply use a double-quoted string instead of a concatenation of chars. Thanks, Brian On Oct 21, 2016, at 12:18 PM, Brian Burkhalter mailto:[email protected]>> wrote: Please review this trivial change at your

Re: [OpenJDK 2D-Dev] RFR: 8168288: Dubious FontMetrics values from NullFontScaler

2016-10-24 Thread Sergey Bylokhov
+1 On 21.10.16 22:22, Brian Burkhalter wrote: This looks OK to me. Brian On Oct 20, 2016, at 1:12 PM, Phil Race mailto:[email protected]>> wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8168288 Webrev: http://cr.openjdk.java.net/~prr/8168288/ Fixes some bizarre values you get for

Re: [OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

2016-10-24 Thread Sergey Bylokhov
ok +1 On 21.10.16 23:11, Brian Burkhalter wrote: Barring objections to the contrary I am inclined to go with webrev.00. There is no precedent in the public javax.imageio.plugins classes for making getters and the like final. Note also that BMPImageWriteParam, JPEGImageReadParam, and JPEGImageWri

Re: [OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

2016-10-24 Thread Vadim Pakhnushev
Looks good. Vadim On 24.10.2016 21:37, Philip Race wrote: Can I get a 2nd reviewer on this one ? -phil. On 10/20/16, 3:52 AM, Sergey Bylokhov wrote: Looks fine. On 20.10.16 2:35, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~p

[OpenJDK 2D-Dev] REG : JDK-8168609 : No link to BMP specification in javax.imageio package documentation

2016-10-24 Thread Jayathirth D V
Hello All, I looked for Bitmap references from Microsoft and found below links : 1) Bitmap storage : https://msdn.microsoft.com/en-us/library/dd183391(v=vs.85).aspx (This is mentioned by Vadim also) 2) Bitmap Overview : https://msdn.microsoft.com/en-us/library/dd183377(v=vs.8