[OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

2016-06-28 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that "Print-To-File" option is enabled even for flavors that do not support Destination attribute even though isAttributeValueSupported for that flavor returns false. Bug: https://bugs.openjdk.java.net/browse/JDK-5049012 webrev: http://

Re: [OpenJDK 2D-Dev] [9] Review request for 8144703: ClassCastException: sun.font.CompositeFont cannot be cast to PhysicalFont

2016-06-28 Thread Alexander Potochkin
Hello Dmitry Looks good to me! Thanks alexp On 6/17/2016 13:47, dmitry markov wrote: Reminder. Could you review the fix, please? Thanks in advance, Dmitry On 10/06/2016 15:07, dmitry markov wrote: Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/brow

Re: [OpenJDK 2D-Dev] JDK 9 build with GCC 6.1.1

2016-06-28 Thread Phil Race
On 06/27/2016 08:50 PM, Yasumasa Suenaga wrote: Hi Kim, The newest changes for jdk repos is [1]. Erik points we should use DISABLED_WARNINGS_gcc to handle unknown warning tags. [2] [1] is implemented with it. This change is already reviewed by 2d folks. So I want to merge it ASAP. Do you hav

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In PixelInterLeavedSampleModel and BandedSampleModel we dont need hashCode() method

2016-06-28 Thread Jim Graham
Still hoping to hear an opinion from Phil on this... The alternative is to add equals() overrides in the subclasses that just do "obj instanceof && super.equals()" which would only matter in some specific somewhat degenerate cases. The intent would be that even though the layout and pixel fet