Looks ok to me.
Regards
Prasanta
On 6/19/2016 4:46 AM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-4497648
Webrev : http://cr.openjdk.java.net/~prr/4497648/
TextLayout is a final class that derives directly from Object.
It defines
boolean equals(TextLayout)
and over-rides
b
Looks fine.
On 20.06.16 15:11, Prasanta Sadhukhan wrote:
Looks ok to me.
Regards
Prasanta
On 6/19/2016 4:46 AM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-4497648
Webrev : http://cr.openjdk.java.net/~prr/4497648/
TextLayout is a final class that derives directly from Obj
It should have been reviewed on 2d as well - I only just saw this.
But how I noticed is that as I am syncing jdk9/dev into jdk9/client
I saw hundreds (!) of client tests had been updated in the wrong forest.
Client test changes and other client changes go into 9/client unless
there is a very good
Hi Phil,
Gentle remainder for review.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, June 15, 2016 10:01 AM
To: Jayathirth D V; Phil Race
Cc: [email protected]
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while
getting second image pro
Hi Phil,
Gentle reminder for review.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, June 15, 2016 10:01 AM
To: Jayathirth D V; Phil Race
Cc: [email protected]
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while
getting second image prope
Hi Phil,
I'm sorry I got this wrong. I'm not that familiar with the list/repo
organization
on the jdk side. I'll try to do better next time.
Besides the wrong processing of the change, do you have any objections
to its content? I'll do a follow-up if so to get it straightened out.
Best rega
