+1
Thank you!
-yan
On 06/10/2016 07:38 AM, prasanta sadhukhan wrote:
Hi All,
Increased the timeout of this manual test so that user can read and
verify the instructions within timelimit to avoid timeout.
Bug:https://bugs.openjdk.java.net/browse/JDK-8159134
webrev: http://cr.openjdk.java.net
Jim,
I fixed the issues you mentioned, see below.
Here is the new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159093.1/
I also fixed the bracket position (int val[] => int[] val) in Helpers,
MarlinRenderingEngine, MarlinTileGenerator classes.
My comments:
2016-06-10 1:48 GMT+02
Hello,
Could you review a fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8144703
webrev: http://cr.openjdk.java.net/~dmarkov/8144703/webrev.00/
Problem description:
If an incorrect font file is used, we unable to initialize the font
during CompositeFont.doDeferredI
Thanks for the response Jay, I think I was misreading some of the code
as now that I look back at it, it's mostly written as I was suggesting
with respect to skipping over data sections, however it is still doing
some scanning to find the initial 0xFF. Some thoughts:
- If we can be sure that
Thanks Laurent,
Eeek, I hate the type[] syntax for declaring arrays, but I guess I have
to grow with the times.
One last thing I just noticed, RendererState.getInstance doesn't protect
against MT access if multiple threads encounter the null instance case
and all decide to make their own...
The getInstance MT issue could be filed as a separate follow-on bug if
you want, in which case webrev.1 is good to go...
...jim
On 6/10/2016 2:54 PM, Jim Graham wrote:
Thanks Laurent,
Eeek, I hate the type[] syntax for declaring arrays, but I guess I have
to grow with the time
