[OpenJDK 2D-Dev] [9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on Solaris 11

2015-10-29 Thread prasanta sadhukhan
Hi All, Please review a small fix in jdk9 whereby JNICheck issued a warning that Exception is not checked after calling a JNI method. This is in continuation to JDK-8130507 fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8020448 webrev: ht

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

2015-10-29 Thread Sergey Bylokhov
On 17.07.15 16:27, Alexander Scherbatiy wrote: - Sergey's point about multi-mon should be checked out. Windows 8.1 has option "Let me choose one scaling level for all my displays". If I unset it I am able to change the size of all items. However, the DPI which returns GetDPIForMonitor

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

2015-10-29 Thread Phil Race
On 10/25/2015 11:56 PM, prasanta sadhukhan wrote: Hi All, I have modified the fix to assign printer name in case UnsupportedEncodingException is thrown which is unlikely as we are using UTF-8 as character encoding and not any user-supplied encoding. http://cr.openjdk.java.net/~psadhukhan/8139

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

2015-10-29 Thread Phil Race
size->cx = (int)ceil(size->cx / scale); So if size->cx / scale works out to be 12.0001 you will round it up to 13? Can you check what pixel size windows gives you in such a case ? I'd be a little surprised if they did that rather than round. Is the SetFontProperty that does not accept a scale

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails on MacOS X 10.9

2015-10-29 Thread Phil Race
Should this new check go before this : CGGI_ClearCanvas(canvas, info); since it is using info which is where you get NaN from. And should we then populate the returned canvas and info to ensure that we return an "empty" glyph rather than garbage values ? It is not clear to me that this is occu

[OpenJDK 2D-Dev] RFR 9 8140598 : Unused variable stream in freetypeScaler.c fails compilation

2015-10-29 Thread Roger Riggs
Please review a minor fix to remove an unused variable that can causes a build warning/failure. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-unused-local-stream-8140598/ Thanks, Roger

Re: [OpenJDK 2D-Dev] RFR 9 8140598 : Unused variable stream in freetypeScaler.c fails compilation

2015-10-29 Thread Aleksey Shipilev
On 10/27/2015 05:48 PM, Roger Riggs wrote: > Please review a minor fix to remove an unused variable that can causes a > build warning/failure. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-unused-local-stream-8140598/ I think that one is already fixed: http://hg.openjdk.java.net/jdk9/

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8139216: Non-ASCII characters in CUPS printer names are not properly displayed

2015-10-29 Thread prasanta sadhukhan
Hi Phil, On 10/30/2015 12:33 AM, Phil Race wrote: On 10/25/2015 11:56 PM, prasanta sadhukhan wrote: Hi All, I have modified the fix to assign printer name in case UnsupportedEncodingException is thrown which is unlikely as we are using UTF-8 as character encoding and not any user-supplied en