Hi ,
Please review a fix for this issue:
It was found that RescaleOp on image with different alpha cannot render
the image as there is a particular flaw in RescaleOp implementation
whereby the source alpha channel is never
transferred to the destination if the rescale op is performed in java
(
Hello Prasanta,
I have couple comments regarding the fix.
* lines 408 - 420 and lines 438 - 444.
Here you are obtaining the source and destination rasters for all
bands (colors + alpha).
However, it is already done on the lines 391 and 392.
Could you please clarify a purpose of
Thanks Andrew for your feedback.
On 6/22/2015 3:28 PM, Andrew Brygin wrote:
Hello Prasanta,
I have couple comments regarding the fix.
* lines 408 - 420 and lines 438 - 444.
Here you are obtaining the source and destination rasters for all
bands (colors + alpha).
However, it is alre
Hi,
Could you, please, review the test-only changes for the JDK-8076468
CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/
@modules keywords have been added to the jtreg tests so that the tests can be
selected as
Hi Alexander,
the fix looks OK to me.
Thanks,
-yan
On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote:
Hi,
Could you, please, review the test-only changes for the JDK-8076468
CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
Webrev: http://cr.openjdk.java.net/~akulyakh/80
In reading through this I notice that at line 349 the filter code can
permanently change the nature of the RescaleOp. It should use a local
copy of the length field if it is going to reinterpret it on the fly
like that.
Also, at line 348 - shouldn't it do something if length > numBands, but
I guess I was expecting to see only tests that use internal API updated
but we do have some that do not being updated.
grep "@modules" jdk.patch | grep -v sun | more | wc
119 4553341
+ * @modules java.datatransfer
+ * @modules java.compiler
+ * @modules java.desktop
And this simple
