Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Jim Graham
Hi Denis, On 12/7/2010 10:47 AM, Denis Lila wrote: Hi Jim. I'm sure you will likely find a root, but the method you are using is "roots*inAB*" which may throw the root out because it is out of range, no? I'm sure some roots will be thrown out, but I think in every call of getTCloseTo there w

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Denis Lila
Hi Jim. > The main problem is that "must" doesn't exist for IEEE floating point > numbers. You can find the root for one of the endpoints and it may > return "t = -.1" even though the value exactly matched the > endpoint, but after all the math was said and done the answer > it came up had t

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Jim Graham
On 12/8/2010 9:37 AM, Denis Lila wrote: Shouldn't it be [A, B]? I thought about this when implementing it, but I don't think it mattered whether it was closed or half open, and the closed interval would have been somewhat more awkward to implement. I'm not sure how the closed interval is awkw

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Denis Lila
> I'm not sure how the closed interval is awkward. Isn't it just proper > choice of ">= and <= vs. > and <" in the testing method? In the filtering function, yes, but I was referring to cubicRootsInAB in Helpers:122-133 where we iterate through intervals. For each interval, we have the values of

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Denis Lila
Hi Jim. > > How about "if the 3 segments of the control polygon are all close to > > each other in length and angle", then the optimization applies. Is > > that easy to test? > > Hmm, that would actually be extremely easy to test and it would cost > almost nothing. We already compute the control

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Jim Graham
Hi Denis, On 12/8/2010 12:04 PM, Denis Lila wrote: I'm not sure how the closed interval is awkward. Isn't it just proper choice of ">= and<= vs.> and<" in the testing method? In the filtering function, yes, but I was referring to cubicRootsInAB in Helpers:122-133 where we iterate through int

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-08 Thread Jim Graham
By "without this optimization" do you mean back when you did a full scan for the proper T? Then this is great news! How often do we end up needing getTCloseTo in practice? ...jim On 12/8/2010 1:54 PM, Denis Lila wrote: Hi Jim. How about "if the 3 segments of the con

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 2 new changesets

2010-12-08 Thread abhi . saha
Changeset: ad7feec4413e Author:miroslawzn Date: 2010-12-08 15:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ad7feec4413e 6813208: pageDialog throws NPE from applet Reviewed-by: ant, minqi ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/su