Re: Pipeline vs. no pipeline (Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype)

[Xaver Hugl]

> > The 3x4 CTM colorop is not yet explicit on whether it clamps its inputs
> > or outputs. Should all colorops be explicit about it?
> >
>
> Do we expect all HW/drivers to be able to support the same behavior?
> Is this critical to using the colorop?
It doesn't need to be the same on all hardware, but it is critical for
userspace to know at runtime. If a color op clips to [0; 1], then
using it with scRGB would be a bad idea for example.

> Harry

Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

[Borah, Chaitanya Kumar]

On 4/8/2025 10:10 PM, Daniel Stone wrote:


As it stands, I've gone through the implementation pretty thoroughly,
as well as our use of it in Weston. I'm happy with how it looks for
pre-blend, and I'm even happier that the implementation is written to
apply easily to apply to post-blend CRTC pipelines.


Since we are planning to use this frame work on post-blend pipelines 
eventually. Should we change the name space of the current pre-blend 
helpers to reflect that?


e.g.

s/drm_colorop_curve_1d_lut_init/drm_plane_colorop_curve_1d_lut_init/
s/drm_colorop_3dlut_init/drm_plane_colorop_3dlut_init/


Regards

Chaitanya