Re: (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-04 Thread Maxime Ripard
On Sun, Dec 03, 2023 at 08:10:31PM +0200, Dmitry Baryshkov wrote:
> On Sun, 3 Dec 2023 at 14:15, Simon Ser  wrote:
> >
> > On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov 
> >  wrote:
> >
> > > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote:
> > >
> > > > Some drivers support hardware that have optimizations for solid fill
> > > > planes. This series aims to expose these capabilities to userspace as
> > > > some compositors have a solid fill flag (ex. SOLID_COLOR in the Android
> > > > hardware composer HAL) that can be set by apps like the Android Gears
> > > > test app.
> > > >
> > > > In order to expose this capability to userspace, this series will:
> > > >
> > > > [...]
> > >
> > >
> > > Applied to drm-misc-next, thanks!
> >
> > Where are the IGT and userspace for this uAPI addition?
> 
> Indeed. I checked that there are uABI acks/reviews, but I didn't check
> these requirements. Frankly speaking, I thought that they were handled
> already, before giving the ack. How should we proceed? Should I land a
> revert?

Yes

Maxime


signature.asc
Description: PGP signature


Re: (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-04 Thread Abhinav Kumar

Hi Simon

On 12/3/2023 4:15 AM, Simon Ser wrote:

On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov 
 wrote:


On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote:


Some drivers support hardware that have optimizations for solid fill
planes. This series aims to expose these capabilities to userspace as
some compositors have a solid fill flag (ex. SOLID_COLOR in the Android
hardware composer HAL) that can be set by apps like the Android Gears
test app.

In order to expose this capability to userspace, this series will:

[...]



Applied to drm-misc-next, thanks!


Where are the IGT and userspace for this uAPI addition?


Yes, we made IGT changes to test and validate this. We will post them on 
the IGT dev list shortly and CC you.


We do not have a compositor change yet for this as we primarily used IGT 
to validate this.


Can we re-try to land this once IGT changes are accepted?

Thanks

Abhinav


Re: (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-04 Thread Simon Ser
On Monday, December 4th, 2023 at 18:51, Abhinav Kumar 
 wrote:

> > Where are the IGT and userspace for this uAPI addition?
> 
> Yes, we made IGT changes to test and validate this. We will post them on
> the IGT dev list shortly and CC you.
> 
> We do not have a compositor change yet for this as we primarily used IGT
> to validate this.

Yes, please post the IGT.

> Can we re-try to land this once IGT changes are accepted?

There will need to be a user-space implementation as well, since this is
a hard requirement for new uAPI [1]. Maybe I'll give this a go if I have
time.

[1]: 
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements


Re: (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-04 Thread Abhinav Kumar




On 12/4/2023 9:57 AM, Simon Ser wrote:

On Monday, December 4th, 2023 at 18:51, Abhinav Kumar 
 wrote:


Where are the IGT and userspace for this uAPI addition?


Yes, we made IGT changes to test and validate this. We will post them on
the IGT dev list shortly and CC you.

We do not have a compositor change yet for this as we primarily used IGT
to validate this.


Yes, please post the IGT.


Can we re-try to land this once IGT changes are accepted?


There will need to be a user-space implementation as well, since this is
a hard requirement for new uAPI [1]. Maybe I'll give this a go if I have
time.



Much appreciated.


[1]: 
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements