'svnadmin verify' failed after hotcopy with 'svnadmin: E160004: Revision file (r2255) lacks trailing newline'
Hi, My svn backup script calls: - svnadmin hotcopy - svnadmin verify (on the copy) Once (for now) the verify call failed with 'svnadmin: E160004: Revision file (r2255) lacks trailing newline' The copy of the repository is still available and I can reproduce the problem. The subsequent hot copies of the same repository are ok (for now). Is it ok to file this as a hotcopy bug, please? The server is VisualSVN 2.5.2 (Subversion 1.7.2) on WinXP SP3. Thanks, Dmitry
Re: 'svnadmin verify' failed after hotcopy with 'svnadmin: E160004: Revision file (r2255) lacks trailing newline'
Daniel, Is your answer based on the knowledge of the code of the subversion server? Here are some details: 1. It is not Unix [cp(1)], the problem was on Windows 2. The disk looks fine (I ran chkdsk and looked at the SMART data). No errors in the Windows log files. 3. The svn repository did not change since the problem was detected and I compared the corrupt hot copy to a correct one. There are 7940 files in each. Of these, the contents of 28 files are not the same (file sizes are ok). These 28 files are of various sizes but the first one (2255) is rather large - 1.5 MB. The repository size is about 1GB. The data in the rev files of the bad copy is corrupted from positions 0x1000 (first and second file), 0x4000, 0, 0x1000, 0, 0, 0x4000, 0, 0, 0, 0x4000 etc. The corrupted file numbers are not sequential (2255 corrupted, 2256-2270 ok, 2271 corrupted). 4. Some antivirus software is running on the system. 5. The 'svnadmin hotcopy' which produced the corrupt copy returned 0 (success) to the script that called it. 6. The system might have been heavily loaded at the time the corrupt copy was made. It looks unlikely that 28 files were corrupted and no errors were logged by the OS. Do you still think is was a disk issue? Thanks, Dmitry PS The server is VisualSVN 2.5.2 (Subversion 1.7.2) on WinXP SP3. On Wed, Jan 11, 2012 at 6:52 PM, Daniel Shahaf wrote: > D D wrote on Wed, Jan 11, 2012 at 15:51:32 +0400: > > Once (for now) the verify call failed with 'svnadmin: E160004: Revision > > file (r2255) lacks trailing newline' > > The copy of the repository is still available and I can reproduce the > > problem. > > The subsequent hot copies of the same repository are ok (for now). > > > > Is it ok to file this as a hotcopy bug, please? > > > > No. All 'hotcopy' does is copy the revisions files using the same means > cp(1) uses. I'd check the health of your disks or replace them. >
Re: 'svnadmin verify' failed after hotcopy with 'svnadmin: E160004: Revision file (r2255) lacks trailing newline'
On Thu, Jan 12, 2012 at 3:41 PM, Andy Levy wrote: > Have you run svnadmin verify against the *actual* repository? Yes. No problem detected. > If you make a new hotcopy of the repository, is that corrupted as well? > No. I've only got a corrupted hot copy once in the last two weeks (backups are daily). Before that the repository was hosted on another WinXP system with an earlier version of the Subversion server. I only added the call to verify the hot copy to the backup script recently so I do not know if the problem ever occurred with the repository on the other system. I'd be interested to know if svnadmin employs some memory buffer to hot-copy. The offsets where data corruption starts look like multiples of 0x1000 which is 4K. The NTFS cluster size on the disk is exactly 4K. If svnadmin just calls the OS to copy each file the problem should either be in the OS or the disk.
Vendor branches: Current guidance?
Hello all, What are the currently accepted best practices / tools for maintaining "vendor" branches? I've seen the page at:http://svnbook.red-bean.com/en/1.7/svn.advanced.vendorbr.html I ask about updated guidance since: 1) I notice some (?) churn for this section in the SVN Book repository:https://code.google.com/p/svnbook/source/browse/trunk/en/book/ch04-branching-and-merging.xml 2) There appears to be both "svn_load_dirs" and "svn-merge-vendor.py" scripts at:http://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/ I'm trying to refactor out some thirdparty code from my codebase, and I'd like to set things up correctly. (I'd hate to screw things up just because I accidentally read a soon-to-be-outdated HOWTO.) Secondarily, what kind of issues can I expect to encounter as I setup and use a vendor branch style deployment? Thank you,David
RE: Vendor branches: Current guidance? [Fixed formatting]
Hello all, [Repost with formatting fixed. Misbehaving email client. ] What are the currently accepted best practices / tools for maintaining "vendor" branches? Particularly where maintaining patches against vendor drops is expected. I've seen the page at: http://svnbook.red-bean.com/en/1.7/svn.advanced.vendorbr.html I ask about updated guidance since: 1) I notice some (?) churn for this section in the SVN Book repository: https://code.google.com/p/svnbook/source/browse/trunk/en/book/ch04-branching-and-merging.xml 2) There appears to be both "svn_load_dirs" and "svn-merge-vendor.py" scripts at: http://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/ I'm trying to refactor out some thirdparty code from my codebase, and I'd like to set things up correctly. (I'd hate to screw things up just because I accidentally read a soon-to-be-outdated HOWTO.) Secondarily, what kind of issues can I expect to encounter as I setup and use a vendor branch style deployment? Thank you, David
