Re: Subversion 1.14.1 and serf 1.3.9
Den fre 22 okt. 2021 07:30Tomasz Lubinski skrev: > I confirm, I used back zlib 1.2.11 but without ASMV, ASMIN symbols > defined. Now it works correctly (even with OPENSSL 3.0). > > Regards and thank you for your help, > Tomek L > Thanks for checking and confirming. I will try to dig out references and make sure it is documented in our build instructions! Kind regards Daniel Sahlberg > > -Original Message- > From: Nathan Hartman > Sent: Thursday, October 21, 2021 5:57 PM > To: Tomasz Lubinski > Cc: Subversion ; Johan Corveleyn < > jcor...@gmail.com>; Daniel Sahlberg > Subject: Re: Subversion 1.14.1 and serf 1.3.9 > > On Thu, Oct 21, 2021 at 8:06 AM Johan Corveleyn wrote: > > > > > > Den tors 21 okt. 2021 kl 13:39 skrev Tomasz Lubinski < > t.lubin...@verocel.pl>: > > >> Very strange problem with assembly code in zlib 1.2.11. > > > > > Indeed, zlib's assembly code seems to be unreliable on Windows. When I > > build / test (for signing new releases) on Windows, I never use the > > assembly build of zlib anymore (ever since I ran into problems with it > > years ago). > > I thought we had that documented somewhere but I can't seem to find it > now. I remember reading a recommendation not to use the assembly build of > zlib because of various issues. It may have been in the mailing list > archives. > > Compilers these days have gotten so good that I think it's a waste of time > to write hand-coded assembly unless there's a very specific and very > special use case requiring exact control over something. Data structure and > algorithm design make a far bigger impact than trying to save a few cycles. > :-) > > Hope you get better results now! > > Cheers, > Nathan > >
RE: Subversion 1.14.1 and serf 1.3.9
I confirm, I used back zlib 1.2.11 but without ASMV, ASMIN symbols defined. Now it works correctly (even with OPENSSL 3.0). Regards and thank you for your help, Tomek L -Original Message- From: Nathan Hartman Sent: Thursday, October 21, 2021 5:57 PM To: Tomasz Lubinski Cc: Subversion ; Johan Corveleyn ; Daniel Sahlberg Subject: Re: Subversion 1.14.1 and serf 1.3.9 On Thu, Oct 21, 2021 at 8:06 AM Johan Corveleyn wrote: > > Den tors 21 okt. 2021 kl 13:39 skrev Tomasz Lubinski > > : > >> Very strange problem with assembly code in zlib 1.2.11. > Indeed, zlib's assembly code seems to be unreliable on Windows. When I > build / test (for signing new releases) on Windows, I never use the > assembly build of zlib anymore (ever since I ran into problems with it > years ago). I thought we had that documented somewhere but I can't seem to find it now. I remember reading a recommendation not to use the assembly build of zlib because of various issues. It may have been in the mailing list archives. Compilers these days have gotten so good that I think it's a waste of time to write hand-coded assembly unless there's a very specific and very special use case requiring exact control over something. Data structure and algorithm design make a far bigger impact than trying to save a few cycles. :-) Hope you get better results now! Cheers, Nathan
Re: Subversion 1.14.1 and serf 1.3.9
Den tors 21 okt. 2021 kl 17:56 skrev Nathan Hartman < hartman.nat...@gmail.com>: > On Thu, Oct 21, 2021 at 8:06 AM Johan Corveleyn wrote: > > > > > > Den tors 21 okt. 2021 kl 13:39 skrev Tomasz Lubinski < > t.lubin...@verocel.pl>: > > >> Very strange problem with assembly code in zlib 1.2.11. > > > > > Indeed, zlib's assembly code seems to be unreliable on Windows. When I > > build / test (for signing new releases) on Windows, I never use the > > assembly build of zlib anymore (ever since I ran into problems with it > > years ago). > > I thought we had that documented somewhere but I can't seem to find it > now. I remember reading a recommendation not to use the assembly build > of zlib because of various issues. It may have been in the mailing > list archives. > Following up a few loose threads from the discussion: It was discussed in 2013 (the thread started a few months earlier but I picked a message with a clear suggestion): https://svn.haxx.se/dev/archive-2013-10/0109.shtml I didn't search for any later discussion. TortoiseSVN removed support for building the ASM versions in 2013 as a result of the above thread. The Subversion build templates also removing the support for building the ASM code as of r1560864. The code itself was removed from zlib develop branch on Oct 13th 2017, however no new release has been made since. I have added a warning in INSTALL, see r1894491. Thanks to everyone for the valuable input! Kind regards Daniel
