Re: quilt-like feature, to support patch series
wuzhouhui wrote on Mon, 16 Dec 2019 06:57 +00:00: > I don't want to commit changes until I think the changes are good enough. > After > all, commit to a branch is also a commit. There is no technical requirement that commits to branches be as stable as commits to trunk; that's purely a social construct and, as such, subject to change. For example, in Subversion's own development we explicitly encourage not-necessarily-fully-baked commits, but ask that they be clearly labeled in the log message; see https://subversion.apache.org/docs/community-guide/conventions.html#log-messages (last three paragraphs only). Or you could make the distinction based on the branch's URL, etc.. > > You could also use git-svn(1) local branches, for example. Or you could use > > quilt on top of Subversion. > > Using quilt on top of Subversion seems is a good idea. To do this, I guess you'll want to write a script that automatically commits a patch series along with log messages (from `quilt header -e`)? If you do, please consider publishing it; it's not the first time this question has come up so it'll probably be useful to others. Cheers, Daniel
Re: Re: quilt-like feature, to support patch series
> -Original Messages- > From: "Daniel Shahaf" > Sent Time: 2019-12-17 09:29:22 (Tuesday) > To: wuzhouhui > Cc: subversion > Subject: Re: quilt-like feature, to support patch series > > wuzhouhui wrote on Mon, 16 Dec 2019 06:57 +00:00: > > I don't want to commit changes until I think the changes are good enough. > > After > > all, commit to a branch is also a commit. > > There is no technical requirement that commits to branches be as stable > as commits to trunk; that's purely a social construct and, as such, > subject to change. For example, in Subversion's own development we > explicitly encourage not-necessarily-fully-baked commits, but ask that > they be clearly labeled in the log message; see > https://subversion.apache.org/docs/community-guide/conventions.html#log-messages > (last three paragraphs only). Or you could make the distinction based on the > branch's URL, etc.. > > > > You could also use git-svn(1) local branches, for example. Or you could > > > use > > > quilt on top of Subversion. > > > > Using quilt on top of Subversion seems is a good idea. > > To do this, I guess you'll want to write a script that automatically > commits a patch series along with log messages (from `quilt header -e`)? > If you do, please consider publishing it; it's not the first time this > question has come up so it'll probably be useful to others. I'm going to hack Subversion, instead of quilt. > > Cheers, > > Daniel
Re: quilt-like feature, to support patch series
wuzhouhui wrote on Tue, 17 Dec 2019 04:38 +00:00: > From: "Daniel Shahaf" > > To do this, I guess you'll want to write a script that automatically > > commits a patch series along with log messages (from `quilt header -e`)? > > If you do, please consider publishing it; it's not the first time this > > question has come up so it'll probably be useful to others. > I'm going to hack Subversion, instead of quilt. I think there's been a misunderstanding: I didn't propose that you modify quilt. In any case, if you have something reusable, please post it :)
Re: quilt-like feature, to support patch series
Subversion's missing piece is the patch-review system, agreed. Rietveld was 11.5 years ago (and Mondrian was 2 years before that - Perforce admittedly), so we have plenty of things to be inspired by. In the last year a "shelve" facility has been perfected for Subversion - https://cwiki.apache.org/confluence/display/SVN/Shelving-v3+in+Svn-1.12. It seems to me that this could be grown into a patch review system. Ref: https://en.wikipedia.org/wiki/Rietveld_(software)