subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273L bad if ?

2018-07-22 Thread David Binderman 
Hello there,


subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273]: (style) 
Expression is always false because 'else if' condition matches previous 
condition at line 271.

Source code is


 else if (strcmp(name, "DAV:" SVN_DAV__VERSION_NAME) == 0)
lrb.dirent_fields |= SVN_DIRENT_CREATED_REV;
  else if (strcmp(name, "DAV:" SVN_DAV__CREATIONDATE) == 0)
lrb.dirent_fields |= SVN_DIRENT_TIME;


Regards


David Binderman

svnbook.red-bean.com is not accessible

2018-07-22 Thread Xiao Jia 
Hello,

I'm trying to dig deeper into SVN today but only found out that
http://svnbook.red-bean.com/ is not accessible.

$ nmap svnbook.red-bean.com

Starting Nmap 7.60 ( https://nmap.org ) at 2018-07-21 13:26 PDT
Nmap scan report for svnbook.red-bean.com (66.146.219.98)
Host is up (0.080s latency).
rDNS record for 66.146.219.98: sanpietro.red-bean.com
Not shown: 986 closed ports
PORTSTATESERVICE
17/tcp  open qotd
22/tcp  open ssh
25/tcp  filtered smtp
53/tcp  open domain
110/tcp open pop3
113/tcp open ident
135/tcp filtered msrpc
139/tcp filtered netbios-ssn
143/tcp open imap
445/tcp filtered microsoft-ds
465/tcp open smtps
587/tcp open submission
993/tcp open imaps
995/tcp open pop3s

Nmap done: 1 IP address (1 host up) scanned in 8.26 seconds

Xiao

subversion-1.10.2/subversion/bindings/javahl/native/JNIUtil.cpp:589: pointer to dead memory ?

2018-07-22 Thread David Binderman 
Hello there,


subversion-1.10.2/subversion/bindings/javahl/native/JNIUtil.cpp:589]: (error) 
Dangerous usage of c_str(). The value returned by c_str() is invalid after this 
call.


Source code is


{
  std::ostringstream buf;
  buf << err->file;
  if (err->line > 0)
buf << ':' << err->line;
  source = buf.str().c_str();
}


source seems to be left pointing at some random stack address.


Regards


David Binderman

Re: svnbook.red-bean.com is not accessible

2018-07-22 Thread vishwajeet singh 
https://subversion.apache.org/docs/


On Sun 22 Jul, 2018, 21:57 Xiao Jia,  wrote:

> Hello,
>
> I'm trying to dig deeper into SVN today but only found out that
> http://svnbook.red-bean.com/ is not accessible.
>
> $ nmap svnbook.red-bean.com
>
> Starting Nmap 7.60 ( https://nmap.org ) at 2018-07-21 13:26 PDT
> Nmap scan report for svnbook.red-bean.com (66.146.219.98)
> Host is up (0.080s latency).
> rDNS record for 66.146.219.98: sanpietro.red-bean.com
> Not shown: 986 closed ports
> PORTSTATESERVICE
> 17/tcp  open qotd
> 22/tcp  open ssh
> 25/tcp  filtered smtp
> 53/tcp  open domain
> 110/tcp open pop3
> 113/tcp open ident
> 135/tcp filtered msrpc
> 139/tcp filtered netbios-ssn
> 143/tcp open imap
> 445/tcp filtered microsoft-ds
> 465/tcp open smtps
> 587/tcp open submission
> 993/tcp open imaps
> 995/tcp open pop3s
>
> Nmap done: 1 IP address (1 host up) scanned in 8.26 seconds
>
> Xiao
>

Re: subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273L bad if ?

2018-07-22 Thread Daniel Shahaf 
David Binderman wrote on Sun, 22 Jul 2018 10:18 +:
> subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273]: (style) 
> Expression is always false because 'else if' condition matches previous 
> condition at line 271.

(I replied on https://issues.apache.org/jira/browse/SVN-4765.  David,
for future reference, we prefer emails to tickets.  Thanks again for
the report.)