core dump when specifying revision with trailing dash

2018-06-11 Thread Robert Wenner 
Hello subversion users and devs,

I had a crash that I didn't find in your bug tracker.

With svn, version 1.10.0 (r1827917)
   compiled Apr 20 2018, 09:01:43 on x86_64-apple-darwin17.4.0,
run this in any working copy:

robert~> svn diff -c 123-
svn: E235000: In file 'subversion/libsvn_client/ra.c' line 682:
assertion failed (SVN_IS_VALID_REVNUM(start_revnum))
Abort trap: 6 (core dumped)

IMHO Subversion should reject the bad revision number, as it does when I
specify e.g., "foo" instead.

Robert

Re: core dump when specifying revision with trailing dash

2018-06-11 Thread Daniel Shahaf 
Robert Wenner wrote on Mon, 11 Jun 2018 15:56 +0200:
> robert~> svn diff -c 123-
> svn: E235000: In file 'subversion/libsvn_client/ra.c' line 682:
> assertion failed (SVN_IS_VALID_REVNUM(start_revnum))
> Abort trap: 6 (core dumped)
> 
> IMHO Subversion should reject the bad revision number, as it does when I
> specify e.g., "foo" instead.

Thanks for the report.

Yes, an assertion failure is invariably a bug.

I can reproduce that with recentish trunk (that I had lying around) but haven't 
debugged.