Run shelve tests in subversion 1.9

2018-03-11 Thread wuzhouhui
I am backporting 'svn shelve' subcommand into Subversion 1.9, and now I want
to do some tests. If I copy shelve_tests.py from Subversion-1.10 to
Subversion-1.9/subversion/tests/cmdline/shelve_tests.py, and run 'make check',
but shelve_tests.py doesn't executed.

So my question is how to run shelve_tests.py in Subversion 1.9 when 'make
check'?



Re: Run shelve tests in subversion 1.9

2018-03-11 Thread Branko Čibej
On 11.03.2018 11:20, wuzhouhui wrote:
> I am backporting 'svn shelve' subcommand into Subversion 1.9,

Why are you doing this? Subversion 1.10 will be released in a couple
weeks; the first release candidate is available, with all the shelving
support. Why not use that, instead of backporting something that we'll
never support?


>  and now I want
> to do some tests. If I copy shelve_tests.py from Subversion-1.10 to
> Subversion-1.9/subversion/tests/cmdline/shelve_tests.py, and run 'make check',
> but shelve_tests.py doesn't executed.
>
> So my question is how to run shelve_tests.py in Subversion 1.9 when 'make
> check'?

Most likely you forgot to make the file executable.

-- Brane



Re: Run shelve tests in subversion 1.9

2018-03-11 Thread wuzhouhui
I customize Subversion 1.9 for my own use. It is much easier to backport
shelve from 1.10 than upgrade to 1.10.

> On 11 Mar 2018, at 6:29 PM, Branko Čibej  wrote:
> 
> On 11.03.2018 11:20, wuzhouhui wrote:
>> I am backporting 'svn shelve' subcommand into Subversion 1.9,
> 
> Why are you doing this? Subversion 1.10 will be released in a couple
> weeks; the first release candidate is available, with all the shelving
> support. Why not use that, instead of backporting something that we'll
> never support?
> 
> 
>> and now I want
>> to do some tests. If I copy shelve_tests.py from Subversion-1.10 to
>> Subversion-1.9/subversion/tests/cmdline/shelve_tests.py, and run 'make 
>> check',
>> but shelve_tests.py doesn't executed.
>> 
>> So my question is how to run shelve_tests.py in Subversion 1.9 when 'make
>> check'?
> 
> Most likely you forgot to make the file executable.
> 
> -- Brane
> 





Re: Run shelve tests in subversion 1.9

2018-03-11 Thread wuzhouhui

> On 11 Mar 2018, at 7:15 PM, wuzhouhui <1530108...@qq.com> wrote:
> 
> I customize Subversion 1.9 for my own use. It is much easier to backport
> shelve from 1.10 than upgrade to 1.10.
> 
>> On 11 Mar 2018, at 6:29 PM, Branko Čibej  wrote:
>> 
>> On 11.03.2018 11:20, wuzhouhui wrote:
>>> I am backporting 'svn shelve' subcommand into Subversion 1.9,
>> 
>> Why are you doing this? Subversion 1.10 will be released in a couple
>> weeks; the first release candidate is available, with all the shelving
>> support. Why not use that, instead of backporting something that we'll
>> never support?
>> 
>> 
>>> and now I want
>>> to do some tests. If I copy shelve_tests.py from Subversion-1.10 to
>>> Subversion-1.9/subversion/tests/cmdline/shelve_tests.py, and run 'make 
>>> check',
>>> but shelve_tests.py doesn't executed.
>>> 
>>> So my question is how to run shelve_tests.py in Subversion 1.9 when 'make
>>> check'?
>> 
>> Most likely you forgot to make the file executable.
The file is executable.
>> 
>> -- Brane
>> 
> 
> 
> 





Re: Run shelve tests in subversion 1.9

2018-03-11 Thread Daniel Shahaf
wuzhouhui wrote on Sun, 11 Mar 2018 19:51 +0800:
> > On 11 Mar 2018, at 7:15 PM, wuzhouhui <1530108...@qq.com> wrote:
> >> On 11 Mar 2018, at 6:29 PM, Branko Čibej  wrote:
> >>> On 11.03.2018 11:20, wuzhouhui wrote:
> >>> I am backporting 'svn shelve' subcommand into Subversion 1.9,
> >>> and now I want
> >>> to do some tests. If I copy shelve_tests.py from Subversion-1.10 to
> >>> Subversion-1.9/subversion/tests/cmdline/shelve_tests.py, and run 'make 
> >>> check',
> >>> but shelve_tests.py doesn't executed.
> >>> 
> >>> So my question is how to run shelve_tests.py in Subversion 1.9 when 'make
> >>> check'?
> >> 
> >> Most likely you forgot to make the file executable.
> The file is executable.

What happens when you run 'python2 ./shelve_tests.py'?

(I don't think our infrastructure cares whether the +x bit is set.)


Re: Run shelve tests in subversion 1.9

2018-03-11 Thread Philip Martin
wuzhouhui <1530108...@qq.com> writes:

>>> Most likely you forgot to make the file executable.
> The file is executable.

You probably need to rerun gen-make.py.

gen-make.py is responsible for adding the new file to TEST_PROGRAMS in
build-outputs.mk

-- 
Philip


Re: Run shelve tests in subversion 1.9

2018-03-11 Thread wuzhouhui

> On 12 Mar 2018, at 4:21 AM, Philip Martin  wrote:
> 
> wuzhouhui <1530108...@qq.com> writes:
> 
 Most likely you forgot to make the file executable.
>> The file is executable.
> 
> You probably need to rerun gen-make.py.
> 
> gen-make.py is responsible for adding the new file to TEST_PROGRAMS in
> build-outputs.mk
After adding shelve_tests.py in build-outputs.mk, 'make check' runs shelve tests
successfully!

Thanks!
> -- 
> Philip