Re: svnignore?

2017-12-30 Thread Daniel Shahaf
Bo Berglund wrote on Sat, 30 Dec 2017 08:51 +0100:
> On Sat, 30 Dec 2017 05:56:17 +0100, Branko ?ibej 
> wrote:
> 
> >
> >Yes and this also works:
> >
> >[miscellany]
> >global-ignores =
> >    foo1 foo2
> >    bar1 bar2

Are you sure?  I couldn't get continuation lines to take effect
regardless of what I tried.  (With/without text after the "=",
with/without backslash, with single tab or single space at the start of
the continuation line...)



Re: svnignore?

2017-12-30 Thread Branko Čibej
On 30.12.2017 09:31, Daniel Shahaf wrote:
> Bo Berglund wrote on Sat, 30 Dec 2017 08:51 +0100:
>> On Sat, 30 Dec 2017 05:56:17 +0100, Branko ?ibej 
>> wrote:
>>
>>> Yes and this also works:
>>>
>>> [miscellany]
>>> global-ignores =
>>>     foo1 foo2
>>>     bar1 bar2
> Are you sure?  I couldn't get continuation lines to take effect
> regardless of what I tried.  (With/without text after the "=",
> with/without backslash, with single tab or single space at the start of
> the continuation line...)

Don't know what you were trying but see parse_option() and
parse_value_continuation_lines() in subversion/libsvn_subr/config_file.c.

-- Brane


Re: svnignore?

2017-12-30 Thread Daniel Shahaf
Branko Čibej wrote on Sat, 30 Dec 2017 10:09 +0100:
> Don't know what you were trying

[[[
% cat ~/.subversion/config
[miscellany]
global-ignores = bar
 foo
% touch foo bar
]]]

> but see parse_option() and
> parse_value_continuation_lines() in subversion/libsvn_subr/config_file.c.

(lldb) p ctx->value->data
(char *) $2 = 0x77e1d310 "bar oo"

And if I «touch ./oo» then ./oo gets ignored and ./foo doesn't.

We've got an off-by-one somewhere.

Cheers,

Daniel


Re: svnignore?

2017-12-30 Thread Bo Berglund
On Sat, 30 Dec 2017 08:31:05 +, Daniel Shahaf
 wrote:

>Bo Berglund wrote on Sat, 30 Dec 2017 08:51 +0100:
>> On Sat, 30 Dec 2017 05:56:17 +0100, Branko ?ibej 
>> wrote:
>> 
>> >
>> >Yes and this also works:
>> >
>> >[miscellany]
>> >global-ignores =
>> >    foo1 foo2
>> >    bar1 bar2
>
>Are you sure?  I couldn't get continuation lines to take effect
>regardless of what I tried.  (With/without text after the "=",
>with/without backslash, with single tab or single space at the start of
>the continuation line...)
>

I have now edited my file and it now looks as follows (actual line
breaks):

global-ignores = *.o *.lo *.la *.al .libs *.so *.so.[0-9]* *.a
  *.pyc *.pyo *.a  *.aps  *.bak.clw  *.db  *.dbg  *.dcu
  *.ddp  *.dsk  *.dti   *.err  *.exp  *.gid  *.gz
  *.identcache  *.ilk  *.jar  *.lnk  *.local  *.log  *.lps
  *.lrt *.mod  *.ncb  *.ocx  *.opt  *.pch
  *.pjt *.plg  *.pdb  *.ppu *.obj
  *.or  *.rsj  *.rst  *.sbr  *.scc  *.sln  *.tar  *.tds
  *.tlh *.tli  *.trg  *.vbw  *.zip  __history  bak  *.~*  .#*

When I create a new file in a non-versioned directory with extension
.jar (3rd continuation line above) then SmartSVN does not show it
unless I change the display filter to show also ignored files.
So I am pretty sure the local version does work with line
continuation.


-- 
Bo Berglund
Developer in Sweden



Re: svnignore?

2017-12-30 Thread Daniel Shahaf
Bo Berglund wrote on Sat, 30 Dec 2017 11:25 +0100:
> So I am pretty sure the local version does work with line
> continuation.

The bug exists only in 1.10 pre-releases; it doesn't exist in 1.9.x.
You've found a regression. :-)