Re: svn switch, touches files with svn:keywords

2016-09-24 Thread Daniel Shahaf
FEDERICO PRADES ILLANES wrote on Fri, Sep 23, 2016 at 12:36:24 +0200:
> Steps to reproduce:
> 
>1. Create a branch b1.
>2. Create an dummy file in b1, with svn:keywords.
>3. Don't use the svn:keywords on the file.
>4. Commit the changes to b1.
>5. Create a branch b2, from b1.
>6. Perform a switch to b2.
> 
> Expected results:
> 
>- Dummy file modification time hasn't change
> 
> Actual results
> 
>- Dummy file modification time has change

I can reproduce this with current trunk and I agree it's a (minor) bug.

Minimal reproduction:

svn co -q $URL wc
cd wc
touch iota
svn add iota
svn ps -q svn:keywords Id iota
svn ci -q -mr1 
svn up -q
stat iota
svn switch ^/iota iota
stat iota

> This is a problem specially with header files, in C++ projects. This bug
> wasn't present in svn 1.7.9 r1462340.
> 
> Can someone else confirm, and will proceed to open the issue.

Confirmed.  Thanks for the clear bug report1

Daniel


svn merge --reintegrate like diff

2016-09-24 Thread Veit Guna
Hi.

Currently at work we're using git for SCM. Although coming from SVN and
having my doubts in the first place, I like it very much now.
Especially the Github style flow with PRs and reviewing makes sense.

Now in another project we're still using SVN. Here I would love to have
the same PR/review flow like in Github.
For this I would like to try the following approach (simplified):

- Use feature branches in SVN
- For every commit there, a post commit hook creates a diff from
branchpoint to branch HEAD
- This diff is posted as draft to ReviewBoard
- So one can see the changes of the whole branch within ReviewBoard
- When the branch is ready to merge, the draft review request is made
public and review starts
- When all comments have been applied to the branch, the branch is
merged and the review is closed.

Now, I'm already there. Diffs are created on-the-fly, reviews can be
done etc.
The only point that annoys me is the fact, when merging latest changes
from trunk to the feature branch
my svn diff shows these changes as well in the branch. Of course, this
isn't really helpful since these changes
got already been reviewed when they were merged to trunk in the first place.

So what I wanted to have is, that my diff should only contain the
changes made within the branch, ignoring
the changes that come from merging from trunk to the branch.

As subversion 1.8 added support for transparently handling such
scenarios without using --reintegrate any
longer, I hope that this logic might have been applied to diff as well.

So basically what I need is a diff that shows me the same changes that
would be made to trunk if the branch
would be merged to it (ignoring trunk changes merged to branch).

Is this somehow possible?

Thanks
Veit




Re: svn merge --reintegrate like diff

2016-09-24 Thread Daniel Shahaf
Veit Guna wrote on Sat, Sep 24, 2016 at 12:19:16 +0200:
> So basically what I need is a diff that shows me the same changes that
> would be made to trunk if the branch
> would be merged to it (ignoring trunk changes merged to branch).
> 
> Is this somehow possible?

Checkout trunk@HEAD, run 'merge --reintegrate' (without committing the
result), and run 'diff'?

That'd give the most accurate answer possible, even if the branch has
received cherry-picking or subtree merges.

Cheers,

Daniel