[Bug 1801540]

2021-09-09 Thread korrode
FYI, the 'solution' for this issue that is now in the kernel breaks
capturing screen+currrently playing audio with ffmpeg, for me at least,
on AMD Raven hardware.

I tried many things but could not achieve good audio capture that is
synchronised, not when capturing from Pulse anyway.

I'm guessing it's being in BATCH mode, and Pulse not operating with
tsched, that is the problem, not the rest of the patchwork.

Nonetheless I just wanted things to work as before without any doubt, so
I now have my kernel patched with the following (restoring 1022:15e3 to
use the parameter sets it used to before all this) and everything is
working fine now:


diff -Naur a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
--- a/sound/pci/hda/hda_intel.c 2021-02-10 19:29:23.0 +1100
+++ b/sound/pci/hda/hda_intel.c 2021-02-14 02:42:38.714796278 +1100
@@ -2601,7 +2601,8 @@
 AZX_DCAPS_PM_RUNTIME },
/* AMD Raven */
{ PCI_DEVICE(0x1022, 0x15e3),
- .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
+ .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB |
+AZX_DCAPS_PM_RUNTIME },
/* ATI HDMI */
{ PCI_DEVICE(0x1002, 0x0002),
  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },



--
While I greatly appreciate the work on the microphone input crackling issue 
(which I have experienced and been annoyed by myself over the years), i'm 
concerned that the current solution should've been further tested and developed 
before being mainlined.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1801540

Title:
  Microphone distorted sound on ALC892/1220 on AMD chipsets

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1801540/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1801540]

2021-09-09 Thread korrode
Just thought i'd update on my situation, i've now tested that it is only
the Pulse changing to batch mode that causes my issue. So i'm no longer
running the patch i posted earlier, rather now i do this:


diff -Naur a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
--- a/sound/pci/hda/hda_controller.c2021-02-10 19:29:23.0 +1100
+++ b/sound/pci/hda/hda_controller.c2021-02-14 00:38:36.602466066 +1100
@@ -609,13 +609,6 @@
 20,
 17800);
 
-   /* by some reason, the playback stream stalls on PulseAudio with
-* tsched=1 when a capture stream triggers.  Until we figure out the
-* real cause, disable tsched mode by telling the PCM info flag.
-*/
-   if (chip->driver_caps & AZX_DCAPS_AMD_WORKAROUND)
-   runtime->hw.info |= SNDRV_PCM_INFO_BATCH;
-
if (chip->align_buffer_size)
/* constrain buffer sizes to be multiple of 128
   bytes. This is more efficient in terms of memory


--

It's my opinion that the above reversion should be done in mainline. A
bugfix that fixes a problem over here but creates a new one over there
isn't a bugfix at all.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1801540

Title:
  Microphone distorted sound on ALC892/1220 on AMD chipsets

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1801540/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1801540]

2021-09-09 Thread korrode
Indeed.

My issue relates to usage with Pulse.

PipeWire looks like an interesting up-and-coming project, but right now
Pulse is what is rolled out in the vast majority of distros and, for
now, tales of outcomes with PipeWire aren't so useful.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1801540

Title:
  Microphone distorted sound on ALC892/1220 on AMD chipsets

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1801540/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1801540]

2021-09-09 Thread korrode
@Takashi Iwai

> So moving it back would break something else, too.  Hmm.

Indeed, it will break whatever solutions to the original issue of
microphone input crackling your changes may have fixed for this sound
device.

My use case - capturing from the global output monitor - has never had a
crackling issue, but is completely broken by the changes.

It's a difficult situation.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1801540

Title:
  Microphone distorted sound on ALC892/1220 on AMD chipsets

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1801540/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1801540]

2021-09-09 Thread korrode
I should clarify: My broken use case is capturing from the global output
monitor while also capturing the screen, and having the audio be
synchronised like at capture time.

In some of my early tests the audio was not only un-synchronised, but
had other issues too (jolting, etc.), so it's possible even just
capturing from the audio monitor alone has issues, but i haven't
confirmed that.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1801540

Title:
  Microphone distorted sound on ALC892/1220 on AMD chipsets

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1801540/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs