[Bug 662981] Re: wireless-{, iwl-, ipw-}power modules do not discard non-wireless interfaces
That's great. Did you also fix the use of iwconfig instead of $IWCONFIG, and inconsistent support for WIRELESS_POWER_SAVING_EXCLUDE_DRIVERS? -- wireless-{,iwl-,ipw-}power modules do not discard non-wireless interfaces https://bugs.launchpad.net/bugs/662981 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 662924] Re: ethernet module has a control flow bug
> So does it not work with dash? laptop-mode-tools uses dash and I haven't seen > this bug report. In case you see problems when run with dash, please report. What is dash? On Gentoo, /usr/sbin/laptop_mode uses /bin/sh, which is a link to /bin/bash. It works, and I don't see a reason to use what looks like an obscure bug/feature for no reason. -- ethernet module has a control flow bug https://bugs.launchpad.net/bugs/662924 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 663103] Re: wireless-ipw-power module has incorrect initialization code
The problem is that the script checks whether the values of IPW2100_* are set, and if they are not, it sets the values of IPW_3945_* variables instead. -- wireless-ipw-power module has incorrect initialization code https://bugs.launchpad.net/bugs/663103 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 662981] Re: wireless-{, iwl-, ipw-}power modules do not discard non-wireless interfaces
Ah, it was a misunderstanding on my part about the purpose of this variable. I thought it was a generic one, just undocumented. -- wireless-{,iwl-,ipw-}power modules do not discard non-wireless interfaces https://bugs.launchpad.net/bugs/662981 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 702930] [NEW] cpufreq: new (generic) ignore_nice_load setting is limited to the "ondemand" governor
Public bug reported: Binary package hint: laptop-mode-tools In /usr/share/laptop-mode-tools/modules/cpufreq (laptop-mode- tools-1.55-r1 on Gentoo): if [ -f "/sys/devices/system/cpu/cpufreq/ondemand/ignore_nice_load" ]; then log "VERBOSE" "Setting CPU ignore_nice_load for all cpus" set_sysctl /sys/devices/system/cpu/cpufreq/ondemand/ignore_nice_load $CPU_IGNORE_NICE_LOAD ... I suggest replacing "ondemand" with "$CPU_GOVERNOR", otherwise the new interface is not used for the conservative governor (for example). Note also that the old "backward compatibility" routine causes a deprecation warning on newer kernels. Perhaps it's better to combine the old and the new routines. ** Affects: laptop-mode-tools (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702930 Title: cpufreq: new (generic) ignore_nice_load setting is limited to the "ondemand" governor -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 662924] [NEW] ethernet module has a control flow bug
Public bug reported: Binary package hint: laptop-mode-tools First, /usr/share/laptop-mode-tools/modules/ethernet:if ! [ -z $path ]; then /usr/share/laptop-mode-tools/modules/ethernet:if ! [ -z $dev_path ] && [ -f $dev_path/enable ]; then are confusing without the quotes around the variable given to -z (but it still works in Bash). Second, in the ETHERNET devices loop, if $path is empty, previous value for $dev_path will be used (redundantly operating on the device). ** Affects: laptop-mode-tools (Ubuntu) Importance: Undecided Status: New -- ethernet module has a control flow bug https://bugs.launchpad.net/bugs/662924 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 662981] [NEW] wireless-{, iwl-, ipw-}power modules do not discard non-wireless interfaces
Public bug reported: Binary package hint: laptop-mode-tools In all the three modules: $IWCONFIG $IFNAME >/dev/null 2>&1; ret=$?; if [ "$ret" = "0" ]; then # Yes, it is a wireless device. However, iwconfig gleefully returns status code 0 for any network device. This results in ugly error messages afterwards. Moreover, in wireless-power: if ( ! iwconfig $IF power $WIRELESS_AC_POWER_SAVING_ONOFF ) ; then if ( ! iwconfig $IF power $WIRELESS_BATT_POWER_SAVING_ONOFF ) ; then Not using the $IWCONFIG variable defined earlier. Moreover, wireless-power supports WIRELESS_POWER_SAVING_EXCLUDE_DRIVERS, whereas wireless-{iwl,ipw}-power do not. Moreover, # LP: #369113 # Kernel's 2.6.29 and above have been reported to be missing # the $DEVICE/wireless folder. See the OCNFIG_WIRELESS_EXT_SYSFS kernel variable for that. ** Affects: laptop-mode-tools (Ubuntu) Importance: Undecided Status: New -- wireless-{,iwl-,ipw-}power modules do not discard non-wireless interfaces https://bugs.launchpad.net/bugs/662981 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 663103] [NEW] wireless-ipw-power module has incorrect initialization code
Public bug reported: Binary package hint: laptop-mode-tools [ "$IPW3945_AC_POWER" ] || IPW3945_AC_POWER=6 [ "$IPW3945_BATT_POWER" ] || IPW3945_BATT_POWER=7 [ "$IPW2100_AC_POWER" ] || IPW3945_AC_POWER=0 [ "$IPW2100_BATT_POWER" ] || IPW3945_BATT_POWER=5 ** Affects: laptop-mode-tools (Ubuntu) Importance: Undecided Status: New -- wireless-ipw-power module has incorrect initialization code https://bugs.launchpad.net/bugs/663103 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 663103] Re: wireless-ipw-power module has incorrect initialization code
In addition, it is impossible to enable power saving for IPW2200 when on AC, via variables settings. -- wireless-ipw-power module has incorrect initialization code https://bugs.launchpad.net/bugs/663103 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs