Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > >> I thought we wanted all spaces? > > > If we do, we should replace all the tabs in pcap-int.h with spaces; we > > should at least be consistent, and change #918 fixed one inconsistent > > case. > > Let's agree that we are going towards spaces. > I think most files are using 8-space indents, a la Linux Kernel. Where is the beginning of this discussion ? -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)
--- Begin Message --- Francois-Xavier Le Bail wrote: >> > If we do, we should replace all the tabs in pcap-int.h with spaces; we >> > should at least be consistent, and change #918 fixed one inconsistent >> > case. >> >> Let's agree that we are going towards spaces. >> I think most files are using 8-space indents, a la Linux Kernel. > Where is the beginning of this discussion ? In a github ticket, #918. --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)
--- Begin Message --- On 20/03/2020 16:16, Michael Richardson wrote: > Francois-Xavier Le Bail wrote: > >> > If we do, we should replace all the tabs in pcap-int.h with spaces; > we > >> > should at least be consistent, and change #918 fixed one inconsistent > >> > case. > >> > >> Let's agree that we are going towards spaces. > >> I think most files are using 8-space indents, a la Linux Kernel. > > > Where is the beginning of this discussion ? > > In a github ticket, #918. I don't see the message starting this conversation in #918, nor the following ones. Could you push them in the list? -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)
--- Begin Message --- Francois-Xavier Le Bail via tcpdump-workers wrote: >> In a github ticket, #918. > I don't see the message starting this conversation in #918, nor the > following ones. Could you push > them in the list? #918 fixes a space->tab, I think. I took it directly to the list to ask if this was right. You didn't miss anything. -- ] Never tell me the odds! | ipv6 mesh networks [ ] Michael Richardson, Sandelman Software Works|IoT architect [ ] m...@sandelman.ca http://www.sandelman.ca/| ruby on rails[ --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol
--- Begin Message --- After going to interop/test events and discussions with other engineers in the field it looks like a lot of the junk in the ATSC ALP protocol will never be used and can be ignored. The protocol is defined in the ATSC A/330 standard. Proposed implementation: 1) Check the packet_type (first 3 bits of the packet). If the packet type is 7 (MPEG2 transport stream) then report "MPEG2 transport stream" and stop parsing. It is likely this packet type will never be used in real-world use. Note that the fields that follow don't apply when the packet type is 7 - all we can do is report the packet type and stop. 2) If the payload_configuration bit is 1 check the segmentation_concatenation bit. If the segmentation_concatenation bit is 0 report that it is a "segmented packet" and stop parsing. It is likely this mode will never be used in real world use (the layer below this protocol does segmentation/reassembly). If the segmentation_concatenation bit is 1 report that it is a "concatenation packet" and stop parsing. It is likely this mode will never be used in real world use. 3) If the payload_configuration bit is 0 then the packet is useful! If header_mode is 0 then report the length and the packet_type. The packet type will typically be IPv4 packet (packet_type = 0) where the payload is a normal IPv4 packet. The other possible packet type is a link layer signalling packet (packet_type = 4). In this case there is an "Addition Header for Signaling" header followed by a table. Note that the payload_length tells you the table length - it does not include the "Addition Header for Signaling" header length. If header_mode is 1 then parse the single_packet_hdr(). If SIF flag is set then parse/skip sub_stream_identification() header. If HEF flag is set the parse/skip header_extension() header. At this point you look at the packet type, following the same logic as header_mode 0 above. Nick --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol
--- Begin Message --- On 3/20/2020 11:17 AM, Michael Richardson wrote: > > Nick Kelsey via tcpdump-workers wrote: > > After going to interop/test events and discussions with other engineers in > > the field it looks like a lot of the junk in the ATSC ALP protocol will never > > be used and can be ignored. > > > The protocol is defined in the ATSC A/330 standard. > > > Proposed implementation: > > okay, this sounds fine. > Are you waiting for a link type allocation? > > libpcap/doc/DLT_ALLOCATE_HOWTO.md tells you how to do that with a pull request. Pull request created (#919): https://github.com/the-tcpdump-group/libpcap/pull/919 Thanks, Nick --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > I will submit a whitespace change to master next week, and then a modeline > fix. > Are there any integrations to github that will warn people to fix their > whitespace settings? Could you explain the whitespace change you are thinking? -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol
--- Begin Message --- On Mar 20, 2020, at 2:39 PM, Nick Kelsey via tcpdump-workers wrote: > Pull request created (#919): > > https://github.com/the-tcpdump-group/libpcap/pull/919 I've added a proposed description as a comment to the pull request; please check whether my assumptions are correct and whether the description would work for that format's entry on https://www.tcpdump.org/linktypes.html.--- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol
--- Begin Message --- On 3/20/2020 9:42 PM, Guy Harris wrote: > On Mar 20, 2020, at 2:39 PM, Nick Kelsey via tcpdump-workers wrote: > >> Pull request created (#919): >> >> https://github.com/the-tcpdump-group/libpcap/pull/919 > > I've added a proposed description as a comment to the pull request; please check whether my assumptions are correct and whether the description would work for that format's entry on https://www.tcpdump.org/linktypes.html. Thanks! I figure there will be interest in this protocol as we start to see ATSC 3.0 test broadcasts. Our ATSC 3.0 hardware can output pcap data over HTTP in real time so ALP can be captured to file with a simple curl/wget command. --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol
--- Begin Message --- On Mar 20, 2020, at 11:14 PM, Nick Kelsey wrote: > I figure there will be interest in this protocol as we start to see ATSC 3.0 > test broadcasts. Our ATSC 3.0 hardware can output pcap data over HTTP in real > time so ALP can be captured to file with a simple curl/wget command. An additional possibility might be to implement the rpcap protocol, but I should probably get around to documenting that protocol before I ask you to do that. :-)--- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
