Re: [tcpdump-workers] Should the tcpdump tests be run with TZ=GMT0, or should the AFS printer print time stamps in UTC?
On Aug 3, 2018, at 6:44 PM, Michael Richardson wrote: > Guy Harris wrote: >> Currently, the tcpdump tests for AFS fail if you're not in the time >> zone where the .out files were generated, because AFS time stamps are >> printed as local time rather than as UTC. > > That's broken So we should just change it to use gmtime() rather than localtime(). (For what it's worth, the NFS dissector just prints raw seconds-since-the-Epoch and microseconds/nanoseconds, and the SMB dissector also appears to convert to local time, at least for Windows FILETIME values, which are proleptic Gregorian-calendar-and-UTC values that could also be shown as UTC, but older versions of SMB have local-time time stamps.) ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Should the tcpdump tests be run with TZ=GMT0, or should the AFS printer print time stamps in UTC?
On 04/08/2018 03:14, Guy Harris wrote: > Currently, the tcpdump tests for AFS fail if you're not in the time zone > where the .out files were generated, because AFS time stamps are printed as > local time rather than as UTC. > > Should we run the tcpdump tests with TZ=GMT0 (at least on UN*X), so that all > time stamps are interpreted as UTC? Yes, setting TZ=GMT0 in TESTrun.sh and update-test.sh. Like that, we could run the tests without the '-t' option and get problems/changes in time printing functions. Need an update to the current tests outputs. > Or should the AFS printer show time stamps as UTC rather than as local time > in the time zone where tcpdump is being run? ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] Should the tcpdump tests be run with TZ=GMT0, or should the AFS printer print time stamps in UTC?
On 04/08/2018 09:03, Guy Harris wrote: > On Aug 3, 2018, at 6:44 PM, Michael Richardson wrote: > >> Guy Harris wrote: >>> Currently, the tcpdump tests for AFS fail if you're not in the time >>> zone where the .out files were generated, because AFS time stamps are >>> printed as local time rather than as UTC. >> >> That's broken Why broken ? it's just local time. > So we should just change it to use gmtime() rather than localtime(). I think an user prefer have the local time. ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
