Re: [tcpdump-workers] RFC Almost trivial unused-parameter patch (and lots of questions)

2018-04-02 Thread Guy Harris
On Mar 31, 2018, at 10:41 AM, Joerg Mayer  wrote:

> attached a patch with the almost trivial fixes for -Wunused-paramter warnings.

Checked in, which changes as needed, as 
0a1a0ed3bce9d3b4fd41b1a0b53e948c15dd525b.
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers


Re: [tcpdump-workers] RFC Almost trivial unused-parameter patch (and lots of questions)

2018-04-02 Thread Guy Harris
On Mar 31, 2018, at 2:12 PM, Guy Harris  wrote:

> On Mar 31, 2018, at 10:41 AM, Joerg Mayer  wrote:
> 
>> - rpcapd/daemon.c:1538:183: warning: unused parameter 'samp_param' could be 
>> silenced
>> by removing it, or by removing the #if 0 around "// Apply sampling 
>> parameters"
> 
> The sampling stuff is a mechanism that the WinPcap driver supported, at least 
> at one point, but I'm not sure whether it's still supported, and no UN*X 
> supports it.  I'd leave it in place, and mark the argument unused, pending an 
> ultimate decision as to whether sampling mode will continue to be supported 
> on Windows.

Checked in as 0a1a0ed3bce9d3b4fd41b1a0b53e948c15dd525b.
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers