Re: [tcpdump-workers] [Patch] print-nfs.c
10.07.2013, 15:18, "Gisle Vanem" : > 'int32_t' isn't 'int' for all targets. Some Windows targets have > it defined as 'signed int' in . So print-nfs.c > does not compile cleanly; conflicting definition of xid_map_find(). Should both declarations be just "int" then? The function returns either 0 or -1 and the only calling function checks the result to be >= 0. -- Denis Ovsienko ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [Patch] print-nfs.c
"Denis Ovsienko" wrote: 10.07.2013, 15:18, "Gisle Vanem" : 'int32_t' isn't 'int' for all targets. Some Windows targets have it defined as 'signed int' in . So print-nfs.c does not compile cleanly; conflicting definition of xid_map_find(). Should both declarations be just "int" then? That could be simpler, yes. --gv ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [Patch] print-nfs.c
11.07.2013, 16:36, "Gisle Vanem" : > "Denis Ovsienko" wrote: > >> 10.07.2013, 15:18, "Gisle Vanem" : >>> 'int32_t' isn't 'int' for all targets. Some Windows targets have >>> it defined as 'signed int' in . So print-nfs.c >>> does not compile cleanly; conflicting definition of xid_map_find(). >> Should both declarations be just "int" then? > > That could be simpler, yes. It is now in GitHub master branch, thank you! -- Denis Ovsienko ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
