[tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Chris Maynard
If I visit http://www.wireshark.org/, I can find the GPL license without too
much searching at the bottom of this page: http://www.wireshark.org/about.html.
 I can't seem to find the tcpdump/libpcap license mentioned anywhere on
http://www.tcpdump.org/.  Is it mentioned somewhere and I'm just missing it?

The reason I bring this up is because I believe Nokia has modified tcpdump and
is including it with their IPSO software.  Tcpdump is GPL'd, isn't it?  So Nokia
should be making their modified tcpdump sources available; yet I can't seem to
find it available for download anywhere.

Thanks.
- Chris


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Tyson Key
Hi Chris,

As far as I'm aware, TCPDump is released under the terms of the BSD Licence
- meaning that Nokia haven't got any obligations regarding releasing their
modifications; and whilst it's not the most reliable information source on
the planet, Wikipedia seems to corroborate that thought.

I hope that helps,

Tyson.

On 21 December 2011 16:20, Chris Maynard  wrote:

> If I visit http://www.wireshark.org/, I can find the GPL license without
> too
> much searching at the bottom of this page:
> http://www.wireshark.org/about.html.
>  I can't seem to find the tcpdump/libpcap license mentioned anywhere on
> http://www.tcpdump.org/.  Is it mentioned somewhere and I'm just missing
> it?
>
> The reason I bring this up is because I believe Nokia has modified tcpdump
> and
> is including it with their IPSO software.  Tcpdump is GPL'd, isn't it?  So
> Nokia
> should be making their modified tcpdump sources available; yet I can't
> seem to
> find it available for download anywhere.
>
> Thanks.
> - Chris
>
>
> -
> This is the tcpdump-workers list.
> Visit https://cod.sandelman.ca/ to unsubscribe.
>



-- 
  Fight Internet Censorship!
http://www.eff.org
http://vmlemon.wordpress.com | Twitter/FriendFeed/Skype: vmlemon |
00447934365844
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] [libpcap] libpcap 'inbound'/'outbound' filter fixes for Linux (#3)

2011-12-21 Thread Michael Richardson

> "David" == David Ward 
> 
>  writes:
David> I'm sending a couple of fixes to the 'inbound' and 'outbound'
David> filters in libpcap affecting Linux. I have compiled and
David> tested under Linux as well as FreeBSD (to make sure it
David> doesn't affect non-Linux builds).

David> Note that the behavior of the 'inbound' filter for Linux
David> cooked captures is slightly modified, with the intent of
David> making the meaning of 'inbound' consistent across all link
David> types and with pcap_setdirection(). Since installing an
David> 'inbound' filter for Linux cooked captures into the kernel
David> was broken anyway, it doesn't seem that there would be any
David> impact.

David> I'm not sure if there is a more preferred way to handle the
David> LSF- or PF_PACKET-specific includes/defines in gencode.h.

David> Please let me know if there are any questions or
David> comments. Thank you.

David> You can merge this Pull Request by running:

David>   git pull https://github.com/dpward/libpcap master

David> Or you can view, comment on it, or merge it online at:

David>   https://github.com/mcr/libpcap/pull/3

I merged it, it looked good to me.

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Tyson Key
For what it's worth, you could try asking Petra Söderling (
petra.soderl...@nokia.com) - who happens to head some of the Open Source
initiatives at Nokia.

Tyson.

On 21 December 2011 16:20, Chris Maynard  wrote:

> If I visit http://www.wireshark.org/, I can find the GPL license without
> too
> much searching at the bottom of this page:
> http://www.wireshark.org/about.html.
>  I can't seem to find the tcpdump/libpcap license mentioned anywhere on
> http://www.tcpdump.org/.  Is it mentioned somewhere and I'm just missing
> it?
>
> The reason I bring this up is because I believe Nokia has modified tcpdump
> and
> is including it with their IPSO software.  Tcpdump is GPL'd, isn't it?  So
> Nokia
> should be making their modified tcpdump sources available; yet I can't
> seem to
> find it available for download anywhere.
>
> Thanks.
> - Chris
>
>
> -
> This is the tcpdump-workers list.
> Visit https://cod.sandelman.ca/ to unsubscribe.
>



-- 
  Fight Internet Censorship!
http://www.eff.org
http://vmlemon.wordpress.com | Twitter/FriendFeed/Skype: vmlemon |
00447934365844
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Chris Maynard
Tyson Key  gmail.com> writes:

> As far as I'm aware, TCPDump is released under the terms of the BSD Licence
> - meaning that Nokia haven't got any obligations regarding releasing their
> modifications; and whilst it's not the most reliable information source on
> the planet, Wikipedia seems to corroborate that thought.

Thanks Tyson.  Yes, I see that now in the sources.  Still, might it be useful to
mention the license somewhere on the web site?


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread David Laight
Chris Maynard wrote:

> Tyson Key  gmail.com> writes:
> 
> > As far as I'm aware, TCPDump is released under the terms of the BSD
Licence
> > - meaning that Nokia haven't got any obligations regarding releasing
their
> > modifications; and whilst it's not the most reliable information
source on
> > the planet, Wikipedia seems to corroborate that thought.
> 
> Thanks Tyson.  Yes, I see that now in the sources.  Still,  might it
be useful to
> mention the license somewhere on the web site?

The sources seem to contain a mix of zero, 2, 3 and 4
clause BSD licences from Berkley.
I thought Berkley had made a general statement that
some of those clauses (esp. the advertising one) could
be removed??

David


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Michael Richardson

> "Chris" == Chris Maynard  writes:
Chris> Tyson Key  gmail.com> writes:

>> As far as I'm aware, TCPDump is released under the terms of the
>> BSD Licence - meaning that Nokia haven't got any obligations
>> regarding releasing their modifications; and whilst it's not the
>> most reliable information source on the planet, Wikipedia seems
>> to corroborate that thought.

Chris> Thanks Tyson.  Yes, I see that now in the sources.  Still,
Chris> might it be useful to mention the license somewhere on the
Chris> web site?

I guess you are right:
  http://www.ca.tcpdump.org/license.html
(and a mirror near you tomorrow)

I'll try to convert the htdocs to a git tree to help people be able to
contribute to it easier.

-- 
]   He who is tired of Weird Al is tired of life!   |  firewalls  [
]   Michael Richardson, Sandelman Software Works, Ottawa, ON|net architect[
] m...@sandelman.ottawa.on.ca http://www.sandelman.ottawa.on.ca/ |device driver[
   Kyoto Plus: watch the video 
   then sign the petition. 



-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Michael Richardson

> "David" == David Laight  writes:
>> Tyson Key  gmail.com> writes:
>> 
>> > As far as I'm aware, TCPDump is released under the terms of the
>> BSD
David> Licence
>> > - meaning that Nokia haven't got any obligations regarding
>> releasing
David> their
>> > modifications; and whilst it's not the most reliable
>> information
David> source on
>> > the planet, Wikipedia seems to corroborate that thought.
>> 
>> Thanks Tyson.  Yes, I see that now in the sources.  Still, might
>> it
David> be useful to
>> mention the license somewhere on the web site?

David> The sources seem to contain a mix of zero, 2, 3 and 4 clause
David> BSD licences from Berkley.  I thought Berkley had made a
David> general statement that some of those clauses (esp. the
David> advertising one) could be removed??

Yes, so wherever it has a 4-clause license, you can replace it with a
3-clause license (patches welcome!!!).  Going from 3-clause to 2-clause
would generally require the agreement of everyone who contributed to the
file. (volunteers welcome!)

-- 
]   He who is tired of Weird Al is tired of life!   |  firewalls  [
]   Michael Richardson, Sandelman Software Works, Ottawa, ON|net architect[
] m...@sandelman.ottawa.on.ca http://www.sandelman.ottawa.on.ca/ |device driver[
   Kyoto Plus: watch the video 
   then sign the petition. 
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] tcpdump license and Nokia

2011-12-21 Thread Guy Harris

On Dec 21, 2011, at 9:02 AM, David Laight wrote:

> I thought Berkley had made a general statement that
> some of those clauses (esp. the advertising one) could
> be removed??

The statement made by the Directory of Technology Licensing at UCB was:

ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change

> July 22, 1999
> 
> To All Licensees, Distributors of Any Version of BSD:
> 
> As you know, certain of the Berkeley Software Distribution ("BSD") source
> code files require that further distributions of products containing all or
> portions of the software, acknowledge within their advertising materials
> that such products contain software developed by UC Berkeley and its
> contributors.
> 
> Specifically, the provision reads:
> 
> " * 3. All advertising materials mentioning features or use of this 
> software
>   *must display the following acknowledgement:
>   *This product includes software developed by the University of
>   *California, Berkeley and its contributors."
> 
> Effective immediately, licensees and distributors are no longer required to
> include the acknowledgement within advertising materials.  Accordingly, the
> foregoing paragraph of those BSD Unix files containing it is hereby deleted
> in its entirety.
> 
> William Hoskins
> Director, Office of Technology Licensing
> University of California, Berkeley

That speaks of "certain of the Berkeley Software Distribution ("BSD") source 
code files".

However, libpcap and tcpdump were, as far as I know, part of a *separate* 
distribution of source code files from Lawrence Berkeley Laboratory; their 
license says

> /*
>  * Copyright (c) 1993, 1994, 1995, 1996, 1998
>  *  The Regents of the University of California.  All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that: (1) source code distributions
>  * retain the above copyright notice and this paragraph in its entirety, (2)
>  * distributions including binary code include the above copyright notice and
>  * this paragraph in its entirety in the documentation or other materials
>  * provided with the distribution, and (3) all advertising materials 
> mentioning
>  * features or use of this software display the following acknowledgement:
>  * ``This product includes software developed by the University of California,
>  * Lawrence Berkeley Laboratory and its contributors.'' Neither the name of
>  * the University nor the names of its contributors may be used to endorse
>  * or promote products derived from this software without specific prior
>  * written permission.
>  * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED
>  * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF
>  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
>  */

the relevant provision of which says "...developed by the University of 
California, Lawrence Berkeley Laboratory and its contributors." rather than 
"...developed by the University of California, Berkeley and its contributors."

So I'm not sure whether the letter from William Hoskins applies or not.  I 
asked some people at the Technology Transfer Division at LBL, but got no 
response.-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] [libpcap] libpcap 'inbound'/'outbound' filter fixes for Linux (#3)

2011-12-21 Thread Guy Harris

On Dec 21, 2011, at 8:46 AM, Michael Richardson wrote:

> 
>> "David" == David Ward 
>> 
>>  writes:
>David> I'm sending a couple of fixes to the 'inbound' and 'outbound'
>David> filters in libpcap affecting Linux. I have compiled and
>David> tested under Linux as well as FreeBSD (to make sure it
>David> doesn't affect non-Linux builds).
> 
>David> Note that the behavior of the 'inbound' filter for Linux
>David> cooked captures is slightly modified, with the intent of
>David> making the meaning of 'inbound' consistent across all link
>David> types and with pcap_setdirection(). Since installing an
>David> 'inbound' filter for Linux cooked captures into the kernel
>David> was broken anyway, it doesn't seem that there would be any
>David> impact.
> 
>David> I'm not sure if there is a more preferred way to handle the
>David> LSF- or PF_PACKET-specific includes/defines in gencode.h.

Ultimately, the right way is probably to have per-packet-source routines for 
that, to handle either other capture mechanisms (either now or in the future) 
that supply packet direction as packet meta-data or capture file formats that 
might supply that data (pcap-ng can - but it's optional, so I'm not sure 
whether an "inbound" or "outbound" filter should only match packets that have 
the direction information or should match all packets that don't have it; my 
guess is that the former is better).

> I merged it, it looked good to me.

I fixed it to fail the compilation of the filter if you're reading a savefile, 
as pcap has no per-packet direction metadata and we don't support it in pcap-ng 
yet.-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] Fwd: New datasource implementation

2011-12-21 Thread Guy Harris

On Dec 20, 2011, at 4:37 PM, Akos Vandra wrote:

> When building wireshark based on the new libpcap with my module using
> libusb-1.0, it didn't build, because it was missing symbols
> (naturally, as wireshark didn't know it has to link libusb-1.0 as
> well). So insted of digging into where I have to add them, it seemed
> simpler to write a script.
> Also it seems unnatural that only for my project wireshark, and any
> other project using libpcap must use libusb-1.0...

"Use" in what sense?

On all modern UN*Xes, as far as I know, a dynamic library can be linked with 
another dynamic library, and if a program is explicitly linked with the first 
of those libraries, but *not* explicitly linked with the second of those 
libraries, the program will still work - the run-time linker will see that the 
first library requires the second library and will load and bind it in at 
run-time.

Only if the program is explicitly linked with a *static* version of the first 
library, or if it's being linked with a dynamic version of the first library 
that wasn't explicitly linked with a dynamic version of the second library, 
does it also need to be linked with a static version of the second library.

> I'm not quite sure I understand this. How would ./configure know that
> that the libusb_claim_interface is in the libusb-1.0 library?
> I'm sorry if I'm a bit slow here, I'm quite unfamiliar with autobuild
> and autoconf, should look into them soon.

It's unfortunately not trivial to do this, but it is possible.

If libpcap should, by default, support your new device if libusb is available 
on your machine (which, for most Linux distributions, means the "development" 
package for libusb must be installed on the machine on which you're building 
libpcap), with a "--disable-{whatever}" option available to let the user 
configure libpcap *not* to support your new device, I'd look at, for example, 
the code in configure.in for Bluetooth capturing - look for "enable Bluetooth 
support."  It lets you configure:

with no options, in which case it'll look for the bluetooth.h header 
and include Bluetooth support if and only if it's present;

with --disable-bluetooth, in which case it will leave the Bluetooth 
support out, even if the header is there.

If all versions of libusb have all the routines you need, checking for a header 
file for libusb is sufficient.  (Checking for the *library* is not sufficient; 
this probably being Linux, you might have the libusb package installed, so that 
you have a dynamic library for the benefit of programs built with that library, 
but *not* have the libusb-dev package installed, so you don't have the header 
files needed in order to build code that uses libusb.)

If not all versions of libusb have those routines, you'll have to use a macro 
such as AC_CHECK_LIB to see whether libusb exists and has the function or 
functions in question.

> Is there a how-to guide to how to add a new module to libpcap?

Unfortunately, no.  The mechanisms for doing so were originally created as 
somewhat specialized hacks, and have been slowly turning into less-specialized 
mechanisms, but it's still not as clean as arguably should be the case.-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] Fwd: New datasource implementation

2011-12-21 Thread Guy Harris

On Dec 20, 2011, at 1:01 AM, Akos Vandra wrote:

> So my questions are:
>  - What are the steps needed to 'nicely' add support to a new device?

If your new device requires a new link-layer header type (which this one does, 
as per the discussion on the wireshark-dev list), you need to get one assigned; 
that means supplying an indication of the packet header format or, at least, a 
link to such a specification, even if it's one of ARM's damned "sorry, you have 
to be a customer to see this document" documents.

> What do I have to add to the configuration, makefiles, #ifdefs, to add
> conditional building?

See how, for example, the Linux Bluetooth support was added.

>  - How can I commit my newly supported device to the libpcap tree?

Send us a patch, submit it on SourceForge, or do whatever the shiny new Git 
magic is for that (Michael, how do people do that?).

>  - How can this libusb dependency be solved? I don't think it would
> be fair to require all libpcap users to need libusb, just for one
> device that they might not even use - conditional building might solve
> this though.

I guess that depends on what "need" means here.  As I noted in my other 
message, if libpcap is dynamically linked with libusb, libusb will be linked in 
at run time without programs using libpcap, or their developers, needing to 
know about it.-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Re: [tcpdump-workers] libpcap support for nanosecond resolution timestamps?

2011-12-21 Thread Guy Harris

On Nov 28, 2011, at 2:02 PM, Andy Fingerhut wrote:

> libpcap has had support for pcap ng files since early 2010.  Such
> files can contain timestamps with resolutions more precise than
> microseconds.  From my reading of the code, it appears that when
> libpcap reads from such a file, it converts the fractional time values
> to units of microseconds, since that is what a struct timeval is
> documented to contain in its tv_usec field.

Yes - that's a requirement for source and binary compatibility.

> A pcap_t *p created by any of the pcap_open_* calls can be used as an
> argument to the new function:
> 
> int pcap_set_tv_usec_resolution(
> pcap_t *p, int tv_usec_resol);

How about

a pcap_t can be used as an argument to the new function

int pcap_allow_max_resolution(pcap_t *p)

which returns the reciprocal of the highest time-stamp resolution 
possible on that pcap_t, and causes the fraction part of the timestamp to be in 
units of that resolution.

This means that existing programs, which don't use that API, get microsecond 
resolution, while new programs that use that API get, for example, nanosecond 
resolution if the capture device (for live captures) or file format (for 
savefiles) offers it, and microsecond resolution otherwise.  (It could also 
support intermediate resolutions.)

That way if a device/mechanism doesn't support nanosecond resolution, or a file 
being read doesn't offer that resolution, you don't get that resolution, and 
don't then end up, for example, displaying time stamps with a bunch of 
meaningless extra 0's in the fraction-of-a-second part or writing a file that 
claims to provide higher resolution time stamps but doesn't really do so.-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.