[swift-corelibs-dev] [SR-1608]

2016-08-01 Thread David Liu via swift-corelibs-dev
Hi all,

I am new to the mailing list, I am  interested in contributing to Swift
Open source.
Recently picked up SR-1608 and have a PR out for it (i split it in 2 to
keep the pulls small).
The code contribution guide lines suggested to contact the mailing list to
make sure work is not duplicated.
So i want to just check with in you guys about it and any guidance is much
appreciated.

Cheers

Dave
___
swift-corelibs-dev mailing list
[email protected]
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev


Re: [swift-corelibs-dev] [SR-1608]

2016-08-02 Thread David Liu via swift-corelibs-dev
Hi Tony,

Thanks for the update, I looked over the PR's i think i am that recent
contributor .
I do have a question about updating and rebasing. Looks like the tip of
master is not compiling with the 7/29 snapshot.
Think it was compiling last right before last weekend. I tried to build the
TC manually and TC failed as well. Any suggestions to rebase and build/test?

Cheers

Dave


On Tue, Aug 2, 2016 at 2:22 AM, Tony Parker 
wrote:

> Hi David,
>
> Thanks for helping!
>
> Can you check out some of our current open PRs to make sure your work
> isn’t overlapping? We’ve had some contributions in this area recently that
> we still need to finish merging.
>
> - Tony
>
> > On Jul 29, 2016, at 11:28 PM, David Liu via swift-corelibs-dev <
> [email protected]> wrote:
> >
> > Hi all,
> >
> > I am new to the mailing list, I am  interested in contributing to Swift
> Open source.
> > Recently picked up SR-1608 and have a PR out for it (i split it in 2 to
> keep the pulls small).
> > The code contribution guide lines suggested to contact the mailing list
> to make sure work is not duplicated.
> > So i want to just check with in you guys about it and any guidance is
> much appreciated.
> >
> > Cheers
> >
> > Dave
> >
> > ___
> > swift-corelibs-dev mailing list
> > [email protected]
> > https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
>
>
___
swift-corelibs-dev mailing list
[email protected]
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev


Re: [swift-corelibs-dev] [SR-1608]

2016-08-08 Thread David Liu via swift-corelibs-dev
Hey Tony,

Thanks for the reply :) yea know lots of changes as of late.
So think part of it was my own fault, I was building my toolchain with a
outdated Xcode and after updating it compiled like a champ!
I updated rebased to master with the latest toolchain snapshot that is
working as well.

Cheers

Dave

On Mon, Aug 8, 2016 at 11:59 AM, Tony Parker 
wrote:

> Hi David,
>
> The compiler has been changing pretty rapidly underneath us, but hopefully
> has settled down a bit now that we’re getting towards the end. I’d suggest
> rebasing against master again and trying with the latest compiler snapshots.
>
> - Tony
>
> On Aug 3, 2016, at 3:29 AM, David Liu  wrote:
>
> Hi Tony,
>
> Thanks for the update, I looked over the PR's i think i am that recent
> contributor .
> I do have a question about updating and rebasing. Looks like the tip of
> master is not compiling with the 7/29 snapshot.
> Think it was compiling last right before last weekend. I tried to build
> the TC manually and TC failed as well. Any suggestions to rebase and
> build/test?
>
> Cheers
>
> Dave
>
>
> On Tue, Aug 2, 2016 at 2:22 AM, Tony Parker 
> wrote:
>
>> Hi David,
>>
>> Thanks for helping!
>>
>> Can you check out some of our current open PRs to make sure your work
>> isn’t overlapping? We’ve had some contributions in this area recently that
>> we still need to finish merging.
>>
>> - Tony
>>
>> > On Jul 29, 2016, at 11:28 PM, David Liu via swift-corelibs-dev <
>> [email protected]> wrote:
>> >
>> > Hi all,
>> >
>> > I am new to the mailing list, I am  interested in contributing to Swift
>> Open source.
>> > Recently picked up SR-1608 and have a PR out for it (i split it in 2 to
>> keep the pulls small).
>> > The code contribution guide lines suggested to contact the mailing list
>> to make sure work is not duplicated.
>> > So i want to just check with in you guys about it and any guidance is
>> much appreciated.
>> >
>> > Cheers
>> >
>> > Dave
>> >
>> > ___
>> > swift-corelibs-dev mailing list
>> > [email protected]
>> > https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
>>
>>
>
>
___
swift-corelibs-dev mailing list
[email protected]
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev