Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
* Paul Lesniewski :

> > This patch renders my server inoperable. It drives the load from 2.57
> > avg. up to 121 (!) in a few minutes.
> 
> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
> was the only thing you changed before the load skyrocketed?

Yes. I applied the patch - and the load rose. I "patch -R"-ed the
patch, all back to normal.

> If it caused this kind of load, it seems like you would have noticed a
> part of the software that became noticeably slower -- did you or your
> users notice anything like that?

SM completely ceased to work.

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
> If you are willing to sacrifice usability of your machine for another
> five minutes, you can try re-applying that patch, then changing the
> following lines in functions/mime.php:
> 
> 1) comment out line 792 so it looks like:
> 
> //case '"':
> 
> 2) change line 843 so it looks like:
> 
> if ($k > 126 || $string{$i} == '"') {
> 
> I think this will have the same result, but having a real world test
> to help verify would be a big help.  It seems that encoding quotes
> makes too much use of this code, but the only other fix is to rewrite
> the function parseAddress in the Rfc822Header class because it tries
> to parse by and then strip out quotes regardless of if they are
> embedded in an encoded part of the string.

I applied that patch and made the changes you mention above.
The machine is working fine (load still 2.46 just like befor applying
the patch!), and the patch seems to work.

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 12:33 AM, Ralf Hildebrandt
 wrote:
> * Paul Lesniewski :
>
>> > This patch renders my server inoperable. It drives the load from 2.57
>> > avg. up to 121 (!) in a few minutes.
>>
>> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
>> was the only thing you changed before the load skyrocketed?
>
> Yes. I applied the patch - and the load rose. I "patch -R"-ed the
> patch, all back to normal.
>
>> If it caused this kind of load, it seems like you would have noticed a
>> part of the software that became noticeably slower -- did you or your
>> users notice anything like that?
>
> SM completely ceased to work.

I don't understand that.  You said it seemed to fix the issue.  SM
*works* for me with the patch, so it's not that it doesn't work.  I'm
looking for what actions become problematic...


-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 12:42 AM, Ralf Hildebrandt
 wrote:
>> If you are willing to sacrifice usability of your machine for another
>> five minutes, you can try re-applying that patch, then changing the
>> following lines in functions/mime.php:
>>
>> 1) comment out line 792 so it looks like:
>>
>>             //case '"':
>>
>> 2) change line 843 so it looks like:
>>
>>                 if ($k > 126 || $string{$i} == '"') {
>>
>> I think this will have the same result, but having a real world test
>> to help verify would be a big help.  It seems that encoding quotes
>> makes too much use of this code, but the only other fix is to rewrite
>> the function parseAddress in the Rfc822Header class because it tries
>> to parse by and then strip out quotes regardless of if they are
>> embedded in an encoded part of the string.
>
> I applied that patch and made the changes you mention above.
> The machine is working fine (load still 2.46 just like befor applying
> the patch!), and the patch seems to work.

Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
your load remains normal after another day or more of running this
code.

Thank you.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 1:28 AM, Paul Lesniewski  wrote:
> On Wed, Sep 30, 2009 at 12:42 AM, Ralf Hildebrandt
>  wrote:
>>> If you are willing to sacrifice usability of your machine for another
>>> five minutes, you can try re-applying that patch, then changing the
>>> following lines in functions/mime.php:
>>>
>>> 1) comment out line 792 so it looks like:
>>>
>>>             //case '"':
>>>
>>> 2) change line 843 so it looks like:
>>>
>>>                 if ($k > 126 || $string{$i} == '"') {
>>>
>>> I think this will have the same result, but having a real world test
>>> to help verify would be a big help.  It seems that encoding quotes
>>> makes too much use of this code, but the only other fix is to rewrite
>>> the function parseAddress in the Rfc822Header class because it tries
>>> to parse by and then strip out quotes regardless of if they are
>>> embedded in an encoded part of the string.
>>
>> I applied that patch and made the changes you mention above.
>> The machine is working fine (load still 2.46 just like befor applying
>> the patch!), and the patch seems to work.
>
> Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
> your load remains normal after another day or more of running this
> code.

And if you're feeling even more adventurous, might I ask you to revert
these changes and try the original patch again to be double sure it
kills the machine?  It's just that this second version shouldn't be
that different than the first


-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
> > SM completely ceased to work.
> 
> I don't understand that.  You said it seemed to fix the issue.

Yes, it fixed the issue when I tested it, but at the same time it was
driving the load higher and higher up to the point where the whole
machine wouldn't respond to anything.

> SM *works* for me with the patch, so it's not that it doesn't work.

it works, but not with 1000 simultaneous connections, for that your
adapted patch works ok

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
* Paul Lesniewski :

> > I applied that patch and made the changes you mention above.
> > The machine is working fine (load still 2.46 just like befor applying
> > the patch!), and the patch seems to work.
> 
> Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
> your load remains normal after another day or more of running this
> code.

I'll keep the code in place unless the load rises...

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

[SM-USERS] Why Reply attache HTML Source

2009-09-30 Thread mogusa

Whenever I reply an email, squirrelmail attache HTML source rather the
message itself. My recipient does not see the attached message but HTML
source.

How can I turn this feature off.

- Mogusa
-- 
View this message in context: 
http://www.nabble.com/Why-Reply-attache-HTML-Source-tp25665614p25665614.html
Sent from the squirrelmail-users mailing list archive at Nabble.com.


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
* Paul Lesniewski :

> And if you're feeling even more adventurous, might I ask you to revert
> these changes and try the original patch again to be double sure it
> kills the machine?  It's just that this second version shouldn't be
> that different than the first

Done. Machine still working. I don't understand this :(

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 11:19 AM, Paul Lesniewski  wrote:
> On Wed, Sep 30, 2009 at 5:12 AM, Ralf Hildebrandt
>  wrote:
>> * Paul Lesniewski :
>>
>>> And if you're feeling even more adventurous, might I ask you to revert
>>> these changes and try the original patch again to be double sure it
>>> kills the machine?  It's just that this second version shouldn't be
>>> that different than the first
>>
>> Done. Machine still working. I don't understand this :(
>
> Ralf, thanks a lot for being so willing to test this in your
> production environment.  Unfortunately, this makes things a little
> more difficult to understand.  :-)  Hmmm.

It may be possible that it's just one particular action or email
message content that triggers a problem with this patch - in which
case maybe SM gets caught in an endless loop eating all your server
memory or the likes.  You didn't happen to notice a runaway httpd
thread when the load was skyrocketing, did you?

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 5:12 AM, Ralf Hildebrandt
 wrote:
> * Paul Lesniewski :
>
>> And if you're feeling even more adventurous, might I ask you to revert
>> these changes and try the original patch again to be double sure it
>> kills the machine?  It's just that this second version shouldn't be
>> that different than the first
>
> Done. Machine still working. I don't understand this :(

Ralf, thanks a lot for being so willing to test this in your
production environment.  Unfortunately, this makes things a little
more difficult to understand.  :-)  Hmmm.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Ralf Hildebrandt
* Paul Lesniewski :

> It may be possible that it's just one particular action or email
> message content that triggers a problem with this patch - in which
> case maybe SM gets caught in an endless loop eating all your server
> memory or the likes.  You didn't happen to notice a runaway httpd
> thread when the load was skyrocketing, did you?

Well, I INITIALLY applied the patch during daytime, at the time of
highest load. Maybe that was unwise and caused the runaway condition...

-- 
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebra...@charite.de | http://www.charite.de


--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

2009-09-30 Thread Paul Lesniewski
On Wed, Sep 30, 2009 at 12:15 PM, Ralf Hildebrandt
 wrote:
> * Paul Lesniewski :
>
>> It may be possible that it's just one particular action or email
>> message content that triggers a problem with this patch - in which
>> case maybe SM gets caught in an endless loop eating all your server
>> memory or the likes.  You didn't happen to notice a runaway httpd
>> thread when the load was skyrocketing, did you?
>
> Well, I INITIALLY applied the patch during daytime, at the time of
> highest load. Maybe that was unwise and caused the runaway condition...

So can I infer that the second version was never used during peak
time?  (and also that it has not been peak time yet since you reverted
to the first version?)

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): 
https://lists.sourceforge.net/lists/listinfo/squirrelmail-users