Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) > > Yes, I confirm that. Many thanks @zdila to push this PR. > > We may take over it. > > Are you planning on taking over this PR? I have some work that will build on > it, but I want to figure out what order to do the work in. Hey, I'd like to finish this, but I'm not sure when I will have time for it. I hope before the end of June. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2838015966 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) > Are the maintainers planning to make the final changes here, or should > someone from the community do it? I am planning to it in the next 2 weeks -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2983121388 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) > Whether or not the style.json path definition changes, this now looks good to > me. That could also be worth revisiting when there's more than one vector > style. Tests pass in my fork > [hlfan#18](https://github.com/hlfan/openstreetmap-website/pull/18). If you > wanna do other reviewers a favor, go through the code comments and mark > applicable ones as _resolved_. I'm sorry, unfortunately I cannot resolve them, I suppose since this is not originally my PR, so if you can resolve those raised by you, it'd be great, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3031084090 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. bd723208a345d1bcef325fdd233d777d0e2bca41 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/76ea626c96119c7fa401818efd264d58f0d2cb51..bd723208a345d1bcef325fdd233d777d0e2bca41 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. f8bd0b0153138be2f8c498370a3cc6665436b787 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/bd723208a345d1bcef325fdd233d777d0e2bca41..f8bd0b0153138be2f8c498370a3cc6665436b787 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 8fc98e107970781caffed51aa5adaee913315363 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fdc3e9da260c603bad306be6d28d58fc8018d109..8fc98e107970781caffed51aa5adaee913315363 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. fdc3e9da260c603bad306be6d28d58fc8018d109 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f8bd0b0153138be2f8c498370a3cc6665436b787..fdc3e9da260c603bad306be6d28d58fc8018d109 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(OSM.RTL_TEXT_PLUGIN, true);
+
+ L.OSM.OpenMapTiles = L.MaplibreGL.extend({
+options: {
+ maxZoom: 23,
+ style: "https://api.maptiler.com/maps/openstreetmap/style.json?key="; +
OSM.MAPTILER_KEY
@tomhughes WDYT?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#discussion_r2177888358
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. f08892f2cc41deec0a88a60aefb1e184754b22b4 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e0a533374d2127a2c3467bd6b090582f345bcaa7..f08892f2cc41deec0a88a60aefb1e184754b22b4 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 7565be18217452402e4a51c331cdc2f84af26328 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/0881ffa40e2b07036e2d81b452704c8c0b2a4c50..7565be18217452402e4a51c331cdc2f84af26328 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 76ea626c96119c7fa401818efd264d58f0d2cb51 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/7565be18217452402e4a51c331cdc2f84af26328..76ea626c96119c7fa401818efd264d58f0d2cb51 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 0881ffa40e2b07036e2d81b452704c8c0b2a4c50 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f08892f2cc41deec0a88a60aefb1e184754b22b4..0881ffa40e2b07036e2d81b452704c8c0b2a4c50 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. a28f6dbbe4f4e12489c4ad91d38118de56958ff0 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86..a28f6dbbe4f4e12489c4ad91d38118de56958ff0 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 4a7b1374945d8577ea7ec5408b05aeca02e5c497 revert vsc settings change -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/a28f6dbbe4f4e12489c4ad91d38118de56958ff0..4a7b1374945d8577ea7ec5408b05aeca02e5c497 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. e0a533374d2127a2c3467bd6b090582f345bcaa7 fix trailing coma -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a7b1374945d8577ea7ec5408b05aeca02e5c497..e0a533374d2127a2c3467bd6b090582f345bcaa7 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) @tomhughes I tried to address all the raised issues. Please bear with me as this is my first PR to this repo, I'm ready for the feedback. Could you authorize me to run the workflows to see if all the lints and test will pass? In the scope of my work I also updated the newly added deps to their latest version. @pnorman I think it should be compatible with your work in https://github.com/openstreetmap/openstreetmap-website/pull/6137 in case this gets merged first -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3023692145 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 4a0fbba2fd57623718f90c56ba8d82c662368a7f Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/8fc98e107970781caffed51aa5adaee913315363..4a0fbba2fd57623718f90c56ba8d82c662368a7f You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek commented on this pull request. > @@ -79,3 +79,18 @@ osm_france_link: id: "osm_france" href: "https://openstreetmap.fr/"; + +- leafletOsmId: "OpenMapTiles" + code: "V" + layerId: "openmaptiles_osm" + nameId: "openmaptiles_osm" + apiKeyId: "maptiler_key" using the apikey in the initialization and removed it from OSM -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#discussion_r2181003869 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a0fbba2fd57623718f90c56ba8d82c662368a7f..cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) In the end I keep maplibre v4 with maplibre-gl-leaflet 0.0.22 since for some reason the custom attribution got broken after updating. Someone else can update this in some followup PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3029383993 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) > Is there an api key I can use for testing? You can let me have it privately > if you prefer... I believe it should work with the Free account so just by signing up here you can get one: https://cloud.maptiler.com/account/keys/ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3068587943 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
