Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)
> Maybe for discussion in #5328 to conclude? @matkoniecz The problem is that the map should not have been dimmed to begin with, especially without any proper discussion. This should be merged and the map should remain as default until #5328 is concluded. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2489447168 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
Dimming the map was probably the worst possible thing contributors (cough cough @AntonKhorev) could have done. It's a terrible stop gap solution and it really did fumble the launch of dark mode. What could have been a nice update that just made the UI dark, they _really_ just had to mess with the map even though nothing was discussed (aside from one maintainer approval). In any case the fact that the dimmed map is STILL in prod is very problematic. Until this issue is resolved the map should be reverted back to the default. > It's normal for users to be afraid of UI changes even when they are good for > them long term. @pkrasicki The "hacky" way of using filters to override the existing tile map to get the dark mode map is not good long term. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2487254185 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
The logical decision would be unaltered map as the default. Until vector maps are implemented, any tampering with the map via CSS filters should be avoided. It’s still ridiculous to me that the dimmed map was implemented in the first place with no discussion in #4712 aside from @tomhughes who doesn’t even use dark mode. Merging #5327 would resolve all the immediate issues and allow discussion to continue. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2483944927 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)
There should be absolutely no image or map dimming. It just reduces readability. Just leaving this comment here so an option is **NOT** created for it. The dimming shouldn’t be a thing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2477475054 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)
Again, what will the default be? There is overwhelming feedback against modification of the map. The default should be 100% brightness (no modification) but I’m wondering if your stance on this is the same. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5336#issuecomment-2480849856 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dim map tiles in dark mode (PR #4712)
> There are two options: dim them or invert them You left out the third option of not changing anything! Just leaving my two cents here to say this should be reverted. Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4712#issuecomment-2477500958 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)
I really hope the dim filter over the map is removed. Either have a proper dark tile map or just don’t touch it at all. It just looks terribly washed out. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2477483039 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)
For the time being this should be discussed in depth and not treated as a "quick fix". Theres serious implications to changing the color of a map that has been meticulously colored and iterated on for the past decade. Realistically, I don't expect a "default" dark map theme until the vector map is released. However, for the time being, the existing dimming filter on the map should absolutely be removed as a quick fix. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2477849951 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)
Glad to see this change! It's a shame that @AntonKhorev saw all the feedback about the dimmed map and completely ignored it with fast tracking this change #5330 instead of removing the filter all together until #5336 is completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2480423234 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)
Will 100% brightness be the default? From what I understand to be the sole criticism (mine included) of the initial introduction dark mode was the dimmed map. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5336#issuecomment-2480417984 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
This whole dimmed tiles situation really goes to show how much of a mess this project management is at the moment. How can something as important as the MAP ITSELF be treated as an afterthought? It is quite literally the most important part of the website yet no community discussion took place beforehand and even after the unanimous criticism NOTHING has been done about it to reverse the dimmed tiles. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2522187561 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
I saw the website got an update but it unfortunately still uses the dimmed tiles as default with OS dark mode despite all of this discussion. Is @AntonKhorev still pushing for the dimmed tiles alone? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2540262072 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) This should be reverted. It's really trying to solve a problem but going about it in the wrong way. This PR just visualizes the annoyance of not being able to see that the changeset you're hovering over is. Here's my proposal: 1. Revert this PR as it won't be needed anymore. 2. Use `scrollIntoView()` to bring the selected list-group-item into view in the sidebar so you can always see what you're hovering over in the map. 3. If we're feeling generous, use `scroll-behavior: smooth;` 4. Say goodby to the days of trying to find the corresponding changesets in the sidebar. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5924#issuecomment-2811658437 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) > > selected list-group-item > > > > Selected how? There's no selection mechanism as of right now. You might be confused. When you hover over a changeset bbox on the map it marks the respective changeset in the side bar as selected. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5924#issuecomment-2815594192 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)
mxdanger left a comment (openstreetmap/openstreetmap-website#5924) > If what you propose is sidebar scrolling frantically as you move your mouse > over the map (and not scrolling anywhere when you're using a device without a > mouse), I expect about 10x more posts starting with "This should be reverted". Considering that your implementation doesn't really solve the issue of "it's difficult to find the corresponding changesets in the sidebar" I don't think you should be dismissive of the scroll into view idea, which would make it incredibly easy and intuitive to see what changeset you're hovering over is without having to click on it. Give it a try and see if it works as a viable option rather than outright dismissing it, surely it shouldn't be too hard to implement `scrollIntoView()` [Mozilla docs](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView) into the function that adds the selected css class, and get some feedback from the community forums. Sure it might jump around if you move your mouse all over the map but it makes intuitive sense. Playing a how/cold game to hunt down a changeset does not make sense, however I guess on mobile it's fine. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5924#issuecomment-2816201959 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
mxdanger left a comment (openstreetmap/openstreetmap-website#5328) > Where? How to enable them? Account > My Preferences > Preferred Map Color Scheme -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2937862028 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
