[openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)
Some more cleanups for `bundle exec i18n-tasks health`. * ChangesetHelper: we have multiple definitions and translations of the same "anonymous" string. Key "changesets.*" is more in line with the other translation keys used in the changeset helper file. Further details in respective commit messages. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5217 -- Commit Summary -- * ChangesetHelper: fix translation key for anonymous user * Ignore users.auth_failure.* as unused translation * Remove unused translation key users.new.external auth -- File Changes -- M app/helpers/changesets_helper.rb (2) M config/i18n-tasks.yml (1) M config/locales/en.yml (1) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5217.patch https://github.com/openstreetmap/openstreetmap-website/pull/5217.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)
@mmd-osm pushed 2 commits. efb3e0c81be04b2c40f131fefabd3d8bd768cb61 Ignore users.auth_failure.* as unused translation 57b402f8fe9667c44093eea16ecb5592617f Remove unused translation key users.new.external auth -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/b7991abc919c4ed407c9b28fa7c45ae89cb04151..57b402f8fe9667c44093eea16ecb5592617f You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)
@mmd-osm pushed 1 commit. 5aa63c60ec7ab98eeb6f595a527f7a525e807a47 Remove unused .greeting translation in changeset_comment_notification -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/57b402f8fe9667c44093eea16ecb5592617f..5aa63c60ec7ab98eeb6f595a527f7a525e807a47 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)
@mmd-osm pushed 1 commit. bcc07e87bf29997fb5935918f923c8f2551d Remove unused Namefinder translation strings -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/5aa63c60ec7ab98eeb6f595a527f7a525e807a47..bcc07e87bf29997fb5935918f923c8f2551d You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add the ability to redact changeset comments (Issue #5219)
Moderators can hide changeset comments, sysadmin/operations can completely remove the data, if needed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352284851 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add the ability to redact changeset comments (Issue #5219)
Best is to send an email to operations with all relevant details. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352714939 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Order changeset elements for consistent pagination (PR #5209)
Timestamp + version is not stable. cgimap does mass inserts/updates, where elements have the exact same timestamp down to the µs. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5209#issuecomment-2353545924 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)
You can pretty much ignore this hint, there’s no need for further action here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217#issuecomment-2356743397 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Notes controller calls set_locale after lookup_user which can cause unexpected language for 404 users notes (Issue #5251)
Right, I had another issue in mind where you would see error messages in whatever language that happens to be set previously. I can't find it at the moment... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-2396669733 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add optional two-factor authentication for user accounts (Issue #3476)
By the way, most third party login providers should support 2FA. This might be a good alternative for the time being. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3476#issuecomment-2408929916 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)
New entry for highway=busway to be added here: https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2408916808 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)
New entry for highway=busway to be added here: https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2408920680 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] split Javascripts.share.image_dimensions to allow translations (Issue #5195)
Looking through existing translations, it might be even better to have three
separate strings for each of the three relevant layers. Instead of "Image will
show the %{layer} layer at %{width} x %{height} ", that would be:
* Image will show the Standard layer at %{width} x %{height}
* Image will show the Cycle map layer at %{width} x %{height}
* Image will show the Transport Map layer at %{width} x %{height}
@maro-21 : what do you think about this proposal?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5195#issuecomment-2408969915
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)
According to https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#nominatim-prefixes, "I18n keys under the geocoder.search_osm_nominatim" are managed by Nominatim maintainers. I'm not exactly clear how this was done in the past. Maybe @lonvia can help here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2408973435 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Remove Nomatim prefixes mention in contributors guide (PR #5260)
See https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2410282588 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5260 -- Commit Summary -- * Remove Nomatim prefixes mention in contributors guide -- File Changes -- M CONTRIBUTING.md (9) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5260.patch https://github.com/openstreetmap/openstreetmap-website/pull/5260.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5260 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@mmd-osm approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3715#pullrequestreview-2370327606 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@mmd-osm commented on this pull request.
> @@ -1603,12 +1603,12 @@ en:
footer_html: "You can also read the message at %{readurl} and you can
send a message to the author at %{replyurl}"
friendship_notification:
hi: "Hi %{to_user},"
- subject: "[OpenStreetMap] %{user} added you as a friend"
- had_added_you: "%{user} has added you as a friend on OpenStreetMap."
+ subject: "[OpenStreetMap] %{user} followed you"
+ had_followed_you: "%{user} has followed you on OpenStreetMap."
I would probably expect a slightly different wording here, like "%{user} is
following you on OpenStreetMap now.".
"has followed you" sounds to me like this is a thing of the past, and not
necessarily the case anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1801690986
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update link for Austria data sources (PR #5254)
Fixes #5253. As requested by LWG. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5254 -- Commit Summary -- * Update link for Austria data sources -- File Changes -- M config/locales/en.yml (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5254.patch https://github.com/openstreetmap/openstreetmap-website/pull/5254.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5254 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] update link for Austria data sources (Issue #5253)
@kathleenlu09 is LWG member, that's why I created the PR right away. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5253#issuecomment-2402862923 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Update en-GB.yml: don't say "import" when you mean "upload" (PR #5257)
As per https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#i18n, I'm closing this PR: _If you make a change that involve the locale files (in config/locales) then please **only submit changes to the en.yml file**. The other files are updated via [Translatewiki](https://translatewiki.net/wiki/Translating:OpenStreetMap) and should not be included in your pull request._ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5257#issuecomment-2406750834 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Update en-GB.yml: don't say "import" when you mean "upload" (PR #5257)
Closed #5257. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5257#event-14604609966 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
> > Assuming we need to convert SVGs to PNGs > > I'm not suggesting that. Ok, I think you would need to further elaborate on your proposal, because it’s still not clear to me how this looks in detail. Please provide some working code snippets which addresses both position and coloring of svg. Also some comment why it is better or with issues it solves. We can then look into this in more detail and work out the best approach. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2382363978 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Notes controller calls set_locale after lookup_user which can cause unexpected language for 404 users notes (Issue #5251)
Related issue for API error messages: #2227 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-2396664674 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
@mmd-osm pushed 1 commit. 6a22d04098506f62609998599256b423bea0f9e9 Trace import: remove activerecord-import gem -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/d41d61856f499de9a40969bd676cd34d99bbc529..6a22d04098506f62609998599256b423bea0f9e9 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)
I suppose the issues listed below are a side effect of #5084. I would just fix the respective unit tests to re-align them with the current implementation. ``` 1) OSM .formatHash formats lat/lon/zoom params Failure/Error: expected '#map=9/57.625/-3.685' to equal '#map=9/57.6247/-3.6845' 2) OSM .formatHash respects zoomPrecision Failure/Error: expected '#map=5/57.62/-3.68' to equal '#map=5/57.625/-3.685' 3) OSM .formatHash formats layers params Failure/Error: expected '#map=9/57.625/-3.685&layers=C' to equal '#map=9/57.6247/-3.6845&layers=C' 4) OSM .formatHash ignores default layers Failure/Error: expected '#map=9/57.625/-3.685' to equal '#map=9/57.6247/-3.6845' 5) OSM .zoomPrecision suggests 0 digits for z0-1 Failure/Error: expected 1 to equal 0 6) OSM .zoomPrecision suggests 3 digits for z5-8 Failure/Error: expected 2 to equal 3 7) OSM .zoomPrecision suggests 4 digits for z9-16 Failure/Error: expected 3 to equal 4 8) OSM .zoomPrecision suggests 5 digits for z17-20 Failure/Error: expected 6 to equal 5 9) OSM .locationCookie creates a location cookie value Failure/Error: expected '-3.685|57.625|9|M' to equal '-3.6845|57.6247|9|M' 10) OSM .locationCookie respects zoomPrecision Failure/Error: expected '-3.685|57.625|9|M' to equal '-3.6845|57.6247|9|M' ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216#issuecomment-2395022501 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 77dabb6abfd1eef8241d79fe648a01ad16e13fda Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..77dabb6abfd1eef8241d79fe648a01ad16e13fda You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
Closed #5252 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723546783 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929 Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/77dabb6abfd1eef8241d79fe648a01ad16e13fda..9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9e62a712fd13c71a8c4bdcfb1fc1bdf24f706929..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
https://github.com/openstreetmap/openstreetmap-website/actions/runs/11407724340/job/31744367292 seems to be doing a bit better. I have replaced `pull_request_target: types: [opened, synchronize]` by `on: [pull_request]`. The token doesn't have access to remove or add labels: ``` Error message: "Big PR" label is not existing. DELETE https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/5270/labels/Big%20PR: 403 - Resource not accessible by integration // See: https://docs.github.com/rest/issues/labels#remove-a-label-from-an-issue Error message: "Inappropriate Translations" label is not existing. DELETE https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/5270/labels/Inappropriate%20Translations: 403 - Resource not accessible by integration // See: https://docs.github.com/rest/issues/labels#remove-a-label-from-an-issue Error message: "Merge Commits" label is not existing. DELETE https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/5270/labels/Merge%20Commits: 403 - Resource not accessible by integration // See: https://docs.github.com/rest/issues/labels#remove-a-label-from-an-issue All green. Congrats. Danger does not have write access to the PR to set a PR status. ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2422932906 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..c10c659245cd1b43a29a23ac7e2e20bb6d3b4dff You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
I don't think share links with node/way/relations are a good fit for sharing and publishing elsewhere. Remember, element ids are not stable and could change at any time, even by your "criminals". I vote for closing this issue, since it's fairly off topic for the site. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#issuecomment-2422795392 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/915cb20421c0304804efe0c7ed6eb17e397ed79d..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 915cb20421c0304804efe0c7ed6eb17e397ed79d Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..915cb20421c0304804efe0c7ed6eb17e397ed79d You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
Closed #5252 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#event-14723554282 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] GPX email shouldn't say "Import", it should just say "Upload" (Issue #5272)
> I messed up https://github.com/openstreetmap/openstreetmap-website/pull/5257 > so I'll just open an issue instead. You’ve only changed the wrong file, just do your changes in en.yml instead… -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5272#issuecomment-2423654201 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add devcontainer configuration (Issue #5264)
Thanks, this looks like a great suggestion. I gave it a try, created a new clone of the repo, then added a new devcontainer using `bundle exec rails container.` Initially I was a bit struggling with (Debian, Rails, npm) packages on generated devcontainer. I believe we can probably reuse a lot of the existing Dockerfile and copy it over to .devcontainer/Dockerfile, thereby hopefully addressing these issues. There's a bit of overlap between the "postCreateCommand" in devcontainer.json and the existing Dockerfile, which would need to be resolved. Then I added memcached and mailpit to compose.yaml and adjusted settings.local.yml accordingly. Both were fairly trivial to get up and running. They allow me to run more production-like scenarios without much hassle. Also, unit tests are passing successfully. Overall I see a much improved DX compared to the old Dockerfile. Sample screenshot  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5264#issuecomment-2423746669 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Show route hints on the website? (Issue #5275)
FYI: Since it doesn't really make sense to replicate each and every routing UI feature on the osm.org repo, we're looking to add a direct link to various routing engines in #5224 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5275#issuecomment-2425153661 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7 Another danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. f99d63bafd5f956773f740cb549d019179cbbf20 danger testing -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/4cc078b6c04d0c6b1d7c920c95c7d33b03588fc7..f99d63bafd5f956773f740cb549d019179cbbf20 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
I found another alternative in https://github.com/chef/chef/pull/14134, which is danger-js. It seems to work on a forked repo pull request:  The output is a bit buried in gh action logs. Fancy things like settings tags don't seem to be supported.  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2427373716 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99d63bafd5f956773f740cb549d019179cbbf20..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
I think that's fine. Log files from 3 weeks ago show that danger was running back then:  https://github.com/danger/danger/actions/runs/11090746237/job/30813474684 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2427418631 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
Here's another comparison at 250% zoom. The old rendering looked a bit off, in particular for the _(part of ways...)_ section. Old | New -- | --  |  _As mentioned earlier, the new icons + colors are based on https://wiki.openstreetmap.org/wiki/OpenStreetMap_Carto/Symbols. It is expected that some of them differ from the old ones._ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2427448913 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse node version coordinates (PR #4930)
> There's no single API call to get geometry [of] old versions of elements > other than nodes. This doesn’t mean we couldn’t introduce such an API endpoint. Ways should be ok, relations could be a bit expensive. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4930#issuecomment-2428359285 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Compress GPX traces when saving (Issue #4188)
As noted elsewhere, we probably don't need to store the original gpx files in the first place. All relevant details should be in the gps_points table already. Or am I missing something here? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4188#issuecomment-2417967431 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
It seems this Danger issue might be related: https://github.com/danger/danger/issues/1103 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2417742102 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 9608220336e83cafc6774e1f5637b61d4f678357 Unauthenticated session expiry -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99b2ad1b82554dbd3a799a7c53fab4f53f7146b..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
What about RUNNING_IN_ACTIONS=true ? This seems to be still missing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2421500814 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
I haven’t checked the code before. They’re using it in their own Dangerfile to control junit reporting. So it’s really irrelevant for us: https://github.com/danger/danger/blob/cd913ea817a2fb9536172597303d78492a727668/Dangerfile#L56 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2421509896 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
> I'm explicitly passing it's hash as the head. [...] PR branch should still be > present and accessible. I suspect that there must be more to pull_request_target to prevent untrusted code from accidentally being executed with elevated privileges... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2430104880 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Fails :no_entry_sign: `bla.sh` failed. ### Log ``` ``` Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 7aeafbd890108734b866df1eaac8ef9b595d5cab -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2430353800 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
I've taken my question over to https://github.com/danger/danger/issues/1103#issuecomment-2430080724 Maybe you can keep an eye the discussion over there a bit. We probably need to move to danger-js. https://danger.systems/js/usage/danger-process as proposed in one answer seems to fit nicely to what I've written earlier today with the two separate CI steps. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2430090099 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Fails
:no_entry_sign:
`bla.rb` failed.
### Log
```
Hello from ruby!
{
"fails": [
{
"message": "Gem/Bundle changes were not documented in the Description. If
this is a major update, add #gemlock_major_upgrade to the PR Description."
}
],
"warnings": [],
"messages": [],
"markdowns": [],
"scheduled": []
}
```
Generated by :no_entry_sign: https://danger.systems/js";>dangerJS
against 7aeafbd890108734b866df1eaac8ef9b595d5cab
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2430359671
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Fails :no_entry_sign: bla Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 7aeafbd890108734b866df1eaac8ef9b595d5cab -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2430379503 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 429cb593fccb03360b4c140be0782621708a14bf Unauthenticated session expiry -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..429cb593fccb03360b4c140be0782621708a14bf You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
It seems it's still failing: https://github.com/openstreetmap/openstreetmap-website/actions/runs/11466048440/job/31905883310?pr=5270 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429943268 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
Yes, it's a security feature: https://github.blog/news-insights/product-news/github-actions-improvements-for-fork-and-pull-request-workflows/ _-> new pull_request_target event [...] runs against the workflow and code from the base of the pull request. This means the workflow is running from a trusted source and is given access to a read/write token as well as secrets enabling the maintainer to safely comment on or label a pull request._ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429954750 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ might be interesting. It describes a set up, where untrusted code is processed by an `on: pull_request` step (which has access to the pull request). In this step we could run danger, similar to what chef/chef is doing as mentioned above. The results on this analysis run can then be checked in as artifact, and another trusted CI step can then be used to download the artifact and update the Pull request labels. This second step is leveraging `on: pull_request_target:`. I think the overall aproach might in fact work. At least the first step to run danger with `on: pull_request` should be able to successfully analyse the untrusted code in the pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2429030319 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
I can't validate the assumption in production and don't know what test cases to add. Or in other words, I was stuck with the current state and decided to close it, as there's no way to make any progress on it. Assuming a slab is full and new entries need to be added. There are two possible options: entries that expire sooner (rather than never) get evicted first, or some random entry will be evicted. Both options are bad, since they might remove valid user sessions. To me, this question is not super important. I would rather let the LRU crawler clean up short lived anonymous sessions as soon as possible, and never get to a state where eviction is unavoidable. Ideally, this change would keep the items in the cache at a very low number all the time, and never get to a point of 80%+ memory usage. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270#issuecomment-2442688850 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Create base and head branches before running danger (PR #5295)
Gemfile.lock update seems to be missing in the PR... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2447300140 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Create base and head branches before running danger (PR #5295)
@nenad-vujicic : this might be a good topic for another rule in Dangerfile.
Something like:
```
gemfile_modified = git.modified_files.include?("Gemfile")
gemfile_lock_modified = git.modified_files.include?("Gemfile.lock")
if gemfile_modified && !gemfile_lock_modified
warn("Gemfile was updated, but Gemfile.lock wasn't updated. Usually, when
Gemfile is updated, you should run `bundle install`.")
end
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2447849335
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)
Fails :no_entry_sign: Gem/Bundle changes were not documented in the Description. If this is a major update, add #gemlock_major_upgrade to the PR Description. Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 7aeafbd890108734b866df1eaac8ef9b595d5cab -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269#issuecomment-2432713396 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
Closed #5038. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#event-14965898966 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Set maximum size limits for user provided content (PR #4694)
Closed #4694. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4694#event-14965892280 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Using osm.org as identity provider for non-"osm.org production" Rails instances (PR #5071)
Closed #5071. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5071#event-14965975015 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
Closed #5270. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270#event-14965984261 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)
@mmd-osm pushed 1 commit. 0d4d86e0820910d527f1be0364f62e3a767bc3e7 Unauthenticated session expiry -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/429cb593fccb03360b4c140be0782621708a14bf..0d4d86e0820910d527f1be0364f62e3a767bc3e7 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Improvements to danger workflow (PR #5290)
I tried another pull request #5270, and here it seems to be working fine. The only obvious difference I can spot is that #5080 has a lot more commits. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2440106153 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
@mmd-osm pushed 1 commit. 7f643077ca62fc39714967d9315be8e83f905c94 Trace import: remove activerecord-import gem -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/6a22d04098506f62609998599256b423bea0f9e9..7f643077ca62fc39714967d9315be8e83f905c94 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Using osm.org as identity provider for non-"osm.org production" Rails instances (PR #5071)
@mmd-osm pushed 1 commit. 961a16749ab89769c97d167396dcaa077e530f25 Using osm.org as identity provider -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5071/files/5b61d54da9b213474b301b18653b007429e9cbdc..961a16749ab89769c97d167396dcaa077e530f25 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Improvements to danger workflow (PR #5290)
I think there's still an issue... I did a rebase on master + force push. Danger is still failing: https://github.com/openstreetmap/openstreetmap-website/pull/5080 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2440001840 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Support version for /nodes, /ways, /relations (#1189)
Closing because #3715 supersedes this PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1189#issuecomment-2440125883 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Support version for /nodes, /ways, /relations (#1189)
Closed #1189. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1189#event-14929561553 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
Could it be that danger is checking a certain number of commits by default only? I tried adding one commit at a time in https://github.com/openstreetmap/danger-test/pull/6, and it worked at least up to 15 commits. The failing PR had 20 commits. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2440142255 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 20 commits. 88255573de25e59f6ae4d95544478dbdbcce02a7 Browse icons as svg f484f93b8a82c931e1f4b971f2faa848f239e67b Visibility improvements for dark mode c2e6dc276384c311fd89c17401560997c443ae99 Fine tune position of 9 svg symbols 81f6f5eeeb1c1283165535d5310bab693be5b335 Replaced two png by svg symbols 027f41e41f0d872677e6a0ca20768052ad758152 Added childcare svg 2887e49b53d1e473f9392ea3f52e9a071a10689b Added svg symbols for school and car share 3e29ecf798063bdb5cc42f4d2cc665163a162ee1 rtl:ignore added for additional transforms 9ed02175bfec9ac311941a5aea4f1e21db791e11 Added mini_roundabout svg 32d361fd7fb6cd2310c1ab48e0d70dda23b8fc96 Remove white background for barrier gate svg 39252ea3a3c9b25c4779a6c2d06ba118a65fd81e Added two railway svgs 77c432b7ae2df69f945589c20ef176da271075bd Added railway level_crossing svg 486070c0c8017efab528c1b36363303f299ed95e Added amenity university svg dc6aac3a3973fa4325d5a5bed2ba0f5396b08e8e Added historic wreck svg 49b0543c68b531f6ba4e9a6d39732dba988c5121 Added estate agent svg 8743e1bdd46f60873611f3bdd564f685508fa708 Added historic ruins svg 734cff601c9b266e929bfcb56859743363fbad81 Remove white background for amenity bus_station svg 5e462b86d5bd44ea1cb6d41393af7c96f81ab729 Rescale golf svgs to 14 3fa4f9241d387480b90d022aaf4e0193de3af62a Rescale some svgs to 14pt a103a499c1cdfd6b41a8193c9a2980a0e8403979 Unit test to accept filenames with optional # suffix ef1810f014e45fac54cea1d5ce4cf21522417741 Use relative position instead of svg transform -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/be6f334b1698fb919a1e486122b87ac5d3a9d56b..ef1810f014e45fac54cea1d5ce4cf21522417741 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
Danger starts failing once the PR has >= 20 commits: https://github.com/openstreetmap/danger-test/pull/6 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2440147247 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
_I'm moving the discussion from #5290 over to this issue..._ I had some issues with danger not being able to correctly process #5080. I can also reproduce the issue in the danger test repo: https://github.com/openstreetmap/danger-test/pull/5 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2440115938 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)
I'm trying the complex scenario with 2 CI steps. I've started with the second half that's updating the pull request: https://github.com/test-9bf40560-ba4d/dangertest/pull/7 Have you tried to post some comments and fail the build in case of issues? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2436332127 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Directions need to say "go straight onto road B" (Issue #5280)
https://discuss.graphhopper.com/t/how-to-handle-when-street-name-changes-on-a-route/5528 mentions some url parameter to get all street names. I haven’t checked what options other routing engines are offering. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5280#issuecomment-2433035953 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Improvements to danger workflow (PR #5290)
It seems you need to update the commit hash in Gemfile.lock. This works for me: ``` diff --git a/Gemfile.lock b/Gemfile.lock index 346af2baa..d1bf08281 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -8,7 +8,7 @@ GIT GIT remote: https://github.com/tomhughes/danger.git - revision: 5794971ade2fb4239a346a4902700e0c6d4c04c7 + revision: a265cf74d2f464a25796b48d95697f5eed553454 ref: pull-request-target specs: ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439548550 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Consistent use of quotes (PR #5291)
Quick comment: you would also need to change a few unit tests with the same issue: - test/controllers/user_roles_controller_test.rb:74 - test/controllers/user_roles_controller_test.rb:134 - test/controllers/messages_controller_test.rb:248 - test/controllers/messages_controller_test.rb:305 Can you take a loot at those as well? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5291#issuecomment-2439619930 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Improvements to danger workflow (PR #5290)
Looks good now. The danger failure is expected, you can't test any changes to Danger with a cross repo PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439551743 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Retire activerecord-import gem? (Issue #4994)
Closed #4994 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4994#event-15046953456 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)
This seems a bit odd. The POST request already returns an HTTP return code 303 along with a `location: https://www.openstreetmap.org/messages/inbox` header for the redirect. According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/303 the browser is supposed to ignore the payload in the body and follow the redirect. I'm not clear why Rails is sending the payload as well in this case. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5222#issuecomment-2359060348 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 3 commits. a8037a2329d761901eb303657b533ae24535697a Browse icons as svg 872eb6f885c55a7dcb0d882dd259e45694ffa16d Visibility improvements for dark mode 783a05b16398ba8626f8fd3b6be2430e5a336ccc Fine tune position of 9 svg symbols -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/ea30534be46a5150295a53c2c67b45332fd91c52..783a05b16398ba8626f8fd3b6be2430e5a336ccc You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Allow exporting direction path tracks (Issue #5224)
I have updated the example URLs from above to only require start lat/lon and end lat/lon values as well as a profile. * Valhalla: `https://valhalla.openstreetmap.de/directions?profile=pedestrian&wps=120.8635823%2C24.1893169%2C120.8648163%2C24.1825192` * OSRM: `https://routing.openstreetmap.de/?loc=24.189317%2C120.863582&loc=24.182519%2C120.864816&srv=2` * GraphHopper: `https://graphhopper.com/maps/?point=24.18978%2C120.86377&point=24.18252%2C120.86482&profile=foot` For the profile values, I'd suggest the following mapping table: | Car | Bicycle | Foot -- | -- | -- | -- Valhalla | car | bicycle | pedestrian OSRM | 0 | 1 | 2 GraphHopper | car | bike | foot OSRM (FOSSGIS) is a bit special, since the values appear to be derived from the sequence in https://github.com/fossgis-routing-server/cbf-routing-profiles/blob/master/profiles.conf.example#L2 ... the profile values are valid for the FOSSGIS instance only. I think that's probably all we need to generate URLs similar to Nominatim. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5224#issuecomment-2365144537 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
Thank you for reviewing this PR another time. > some icons are too dark, I inverted and hue-rotated them; here it's not done > I suppose; see place_of_worship icon for an extreme example Agree, that's also something I've noticed. I'm pushing another commit now which should improve the situation. As a general remark, I would leave that sort of fine tuning to a follow up pull request. > do we need a smaller icon for waste baskets here just because it's smaller on > the map render? Yes, it matches exactly the size you see on the map. > alignment wasn't great before, here it's even worse, see traffic lights for > example I've checked all 219 SVGs, and found that less than 10 of them might need some fine tuning. The vast majority of new SVGs is just fine. Hence, I think that's a good topic for follow up pull requests as well. > I still think it's > https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2298987792 > to switch to s first, then start replacing them with svgs, assuming all > of the images have the same size. Hopefully we can avoid random pixel offsets > in css. I'm not entirely clear what you're suggesting here. Assuming we need convert SVGs to PNGs and maintain new entries in browse.scss for them, that would be a very clear no-go for me. Speaking of experience in this PR, it's creating a huge effort with very limited options for later reuse. I would suggest to focus on any remaining import issues with SVGs instead in this PR, rather than spending time on PNGs which we want to phase out anyway. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2365289785 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 1 commit. ea30534be46a5150295a53c2c67b45332fd91c52 Visibility improvements for dark mode -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/40c07ec9b7b87923f3236ea09b9e30c35f973bb4..ea30534be46a5150295a53c2c67b45332fd91c52 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] OCI: ignore invalid replacement token (PR #5231)
In #5210, updating the OSM community index failed due to invalid replacement tokens. This issue needs to be resolved upstream. However, we can add a bit of error handling and still apply the update. EN is used for erroneous translations. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5231 -- Commit Summary -- * OCI: ignore invalid replacement token -- File Changes -- M lib/osm_community_index.rb (6) M test/lib/osm_community_index_test.rb (10) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5231.patch https://github.com/openstreetmap/openstreetmap-website/pull/5231.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5231 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
I've added dedicated css formatting for 9 SVG symbols now, to improve positioning and/or size of the respective symbols. Maybe you could take another look now. If necessary, please suggest exactly which symbol should be changed and how. The approach should be flexible enough to allow for further fine-tuning in the future. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2366904929 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
@mmd-osm pushed 1 commit. d41d61856f499de9a40969bd676cd34d99bbc529 Trace import: remove activerecord-import gem -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/8367e6d6d86ae7849fd3238546e55a52baec1c78..d41d61856f499de9a40969bd676cd34d99bbc529 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transform: translate(2px, 0px);
The purpose of the translate is to improve the positioning of SVGs. Like I've
written below, that's good for the majority of new SVGs.
The remaining old css PNG images will be replaced by SVGs in later PRs, by
which time this issue will become obsolete. Until then, some fine tuning could
still be done in follow up PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#discussion_r1769641430
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Trace import: validate background job results (PR #5232)
While the discussion in #5038 is still ongoing, I have moved the unit test to a new PR. Validating the results of trace import background job is useful for both scenarios You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5232 -- Commit Summary -- * Trace import: validate background job results -- File Changes -- M test/controllers/api/traces_controller_test.rb (22) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5232.patch https://github.com/openstreetmap/openstreetmap-website/pull/5232.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5232 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transform: translate(2px, 0px);
highway=turning_circle has been replaced by an SVG symbol.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#discussion_r1772015926
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 1 commit. 2ff0b3617bde2fe206875ef8bc004fdf41aec894 Replaced two png by svg symbols -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/783a05b16398ba8626f8fd3b6be2430e5a336ccc..2ff0b3617bde2fe206875ef8bc004fdf41aec894 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
My goal was to remove the activerecord-import gem by a built in equivalent method. Since the validations are not automatically executed anymore, I added the call to the validate method. Rubocop is not clever enough to figure out that we're validating the model contents earlier on, so we need an additional annotation. I really don't have an issue with that. Now we could of course further change the implementation and get rid of the model instances. However, that's a second step, and not needed to replace activerecord-import. That's not to say that this isn't a valid discussion to have, it just doesn't fit well here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2376366133 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
