Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-14 Thread Sarah Hoffmann via rails-dev
Feel free to add new entries. And feel free to make a PR to get of this section 
in CONTRIBUTING.md.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2410282588
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Update nominatim terms (PR #5401)

2024-12-16 Thread Sarah Hoffmann via rails-dev
### Description

I'm planning to introduce three new categories for Nominatim classes: lock, 
water and information. These are the main terms for it.

### How has this been tested?

Only made sure the CI runs successfully.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5401

-- Commit Summary --

  * add lock, information and water classes for nominatim terms

-- File Changes --

M config/locales/en.yml (21)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5401.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5401.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5401
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Link to Nominatim is missing viewbox parameter (Issue #5859)

2025-03-27 Thread Sarah Hoffmann via rails-dev
lonvia created an issue (openstreetmap/openstreetmap-website#5859)

### Problem

Follow-up to #3205. The new direct links to Nominatim from #4895 are awesome 
but it looks like the `viewbox=` parameter doesn't work as intended. It never 
seems to be included in the URL. You can already see in the screen shot of PR 
#4895 that it is missing.

### Description

_No response_

### Screenshots

_No response_

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5859
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Update FAQ.md (PR #5908)

2025-04-10 Thread Sarah Hoffmann via rails-dev
lonvia left a comment (openstreetmap/openstreetmap-website#5908)

That's a misguided attempt to fulfil GSOC requirements. Feel free to just close.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5908#issuecomment-2788502666
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Error contacting nominatim.openstreetmap.org: 400 (Issue #5909)

2025-04-09 Thread Sarah Hoffmann via rails-dev
lonvia left a comment (openstreetmap/openstreetmap-website#5909)

The website is sending an empty `zoom` parameter to Nominatim. That is not 
allowed. It must be an integer number.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#issuecomment-2788522129
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Error contacting nominatim.openstreetmap.org: 400 (Issue #5909)

2025-04-09 Thread Sarah Hoffmann via rails-dev
lonvia left a comment (openstreetmap/openstreetmap-website#5909)

I think the restriction appeared on the Nominatim side with the switch to 
Python, which was over a year ago. You really should always send the zoom. It 
does make a difference for the result.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#issuecomment-2788654063
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Implement JSON support for the changeset download API (PR #5973)

2025-05-01 Thread Sarah Hoffmann via rails-dev
lonvia left a comment (openstreetmap/openstreetmap-website#5973)

Changefiles today are usually sorted by (OSM type, OSM id, version). This 
ensures that most(*) dependent changes are already available, when reading an 
object. Consumers may rely on that order.

(*) The obvious exception are nested relations, but they are a beast to handle 
anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5973#issuecomment-2844722180
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Routing by Car is extremely slow (probably down?), but by Bicycle and by Foot are fine (Issue #5974)

2025-05-02 Thread Sarah Hoffmann via rails-dev
lonvia left a comment (openstreetmap/openstreetmap-website#5974)

This isn't the right place to report issues with the OSRM demo server. Usually 
it is probably best to contact the sysadmins via the email listed at 
https://map.project-osrm.org/about.html.

That said, the sysadmins are aware of the issue now and are busy looking into 
it. We can't say right now when it will be fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5974#issuecomment-2846612139
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079)

2025-06-02 Thread Sarah Hoffmann via rails-dev
@lonvia commented on this pull request.



> @@ -12,6 +14,14 @@ def create
   # ask nominatim
   response = fetch_xml(nominatim_reverse_query_url(:format => "xml"))
 
+  # add lang attribute for frontend in certain regions
+  addressparts = response.elements["reversegeocode/addressparts"]
+  lang = nil
+  if addressparts
+region_code = addressparts.elements["ISO3166-2-lvl3"]&.text == "CN-HK" 
? "hk" : addressparts.elements["country_code"]&.text
+lang = region_code ? LANGUAGE_CODES[region_code] : nil

You cannot make such assumptions. Nominatim decides for each part of the 
display name separately which translation fits best. Consequently, this whole 
guessing here will go wrong if a user with Japanese language settings searches 
something in China and gets a result which is mixed Chinese/Japanese. It's also 
not clear to me, if a Japanese reader would rather expect Japanese han even in 
the Chinese-language parts or if that would only be the case when they are able 
to read the different han versions.

Sounds to me like it is worth tackling language-tagging of the display name in 
Nominatim instead of making educated guesses here. We currently have a GSoC 
project running for transliteration of display names. Language-tagging will be 
a part of that. Should be feasible to return that information.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6079#discussion_r2120256570
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev