Re: [openstreetmap/openstreetmap-website] Further rework lego messages for trace notification emails (Issue #4012)

2024-10-31 Thread Pikse via rails-dev
Or, if different ordering isn't needed, then first part of the sentence may 
need different grammatical case depending on if follwed by success or failure 
message. This is the case in my language, which I now noticed when re-reviewing 
the translations.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4012#issuecomment-2449832625
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Fix message reuse for Terms of Use link in signup form (PR #6166)

2025-07-03 Thread Pikse via rails-dev
Currently `layouts.tou` message (link label) is reused in two different 
sentences, i.e. in messages `accounts.terms.show.tou explain html` and 
`users.new.by_signing_up.html`. In some languages however the link label needs 
different declension in these sentences.

Here `users.new.by_signing_up.tou` message is added for use in the latter 
sentence in signup form. In English it's identical to previous 
`layouts.tou` message.

Similarly in #4936 two other link labels in the same sentence were already 
adjusted like this.

It also appears that at some point the terms of use link label already existed 
for this particular sentence, as still documented in translatewiki, but no one 
remembered to actually use it, and then it got removed as an unused message in 
b0ad96e.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6166

-- Commit Summary --

  * Fix message reuse for Terms of Use link in signup form

-- File Changes --

M app/views/users/new.html.erb (2)
M config/locales/en.yml (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6166.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6166.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6166
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Fix message reuse for Terms of Use link in signup form (PR #6166)

2025-07-03 Thread Pikse via rails-dev
@Pikse pushed 1 commit.

da0e2e4306274363ba1079dfd3f28648c068add6  Fix message reuse for Terms of Use 
link in signup form

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6166/files/0ec6286129f73c516b775df5fd45c99642497599..da0e2e4306274363ba1079dfd3f28648c068add6
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev