[openstreetmap/openstreetmap-website] Figure out how to serve client-side style resources (Issue #5306)
### Problem With client side layers proposed as featured layers, we need to figure out how to serve the styles to the client. ### Description We have a couple of proposed featured layers that are Maplibre GL styles. These styles consist of a style json, spritesheet, and fonts. The MapLibre style contains the URL of the spritesheet and fonts. The style, spritesheet, and fonts are all built by various processes. Some of them (particularly fonts) may not be easily automated and they don't need to be regenerated frequently. Some options come to mind are - referencing an external style URL, - including files in the repo, or - trying to generate them at build time. The last probably isn't an option for fonts. I would like to avoid the situation we ended up with OpenLayers where we're compelled to keep an ancient version of software or a resource available forever. ### Screenshots _No response_ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5306 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Guidance on Enhancing OSM Profile Pages with Contribution Data (Issue #5356)
> * Changesets in the planet OSM files contain user data, but tools like > Osmosis and Osmium cannot directly link users to contributions in a database. > * Full history dumps provide the necessary data but are massive (~223 GB > compressed, ~3.7 TB uncompressed) and complex to process. If you're looking in the context of openstreetmap-website, this data is already present in the database and you'd never look at the dumps. You'd only use the planet files if you were building something external. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5356#issuecomment-2498794779 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)
> For myself, I value the ability to turn off dark mode for individual sites > entirely. When working on maps, I often cross reference images, notes and > other information, most of which don't have a "dark mode" so the switching > back and forth is jarring I would have thought this would result in you turning off dark mode in general. What I'm interested in is why you want dark mode for everything else, but not for OSM. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480188279 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)
> Some users do not want to use the new dark mode This would only apply to users who want to use dark mode in general, but not on OSM. Is this a large body of users? Could it be reduced with improvements to dark mode? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480025672 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
This is awaiting a response from MapTiler -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2529095928 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add copyright/attribution message to downloaded map images (PR #5607)
pnorman left a comment (openstreetmap/openstreetmap-website#5607) I was originally in favour of optional attribution, but @matkoniecz arguments persuade me to think it should always be there. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5607#issuecomment-2660372107 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] dead link in /copyright (Issue #3998)
pnorman left a comment (openstreetmap/openstreetmap-website#3998) I emailed the LWG about removing the link > Thanks for the helpful links, Paul. The wiki page says the data's under > CC-BY-SA, which takes "[appropriate > credit](https://creativecommons.org/licenses/by-sa/4.0/deed.en#ref-appropriate-credit)" > to include a link if supplied. I think it's reasonable to say that the link > is no longer being supplied by the licensor and can be removed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3998#issuecomment-2749564222 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
pnorman left a comment (openstreetmap/openstreetmap-website#4042) > Yes, I confirm that. Many thanks @zdila to push this PR. > > We may take over it. Are you planning on taking over this PR? I have some work that will build on it, but I want to figure out what order to do the work in. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2835976235 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
pnorman left a comment (openstreetmap/openstreetmap-website#2799) The terms linked are for apps, not websites. https://developer.apple.com/sign-in-with-apple/usage-guidelines-for-websites-and-other-platforms/ is all I found for websites. If you're developing an app, you don't care about what type of sign-in the user has, and in fact you'll not be able to find out. All you need/get is the oauth2 information. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2799#issuecomment-2847911954 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
pnorman left a comment (openstreetmap/openstreetmap-website#2799) This issue is about adding a another login provider to osm.org and isn't for your app. Your app can't tell how someone logged in to osm.org as all it will know is oauth2 credentials -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2799#issuecomment-2848893452 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)
pnorman left a comment (openstreetmap/openstreetmap-website#5706) > In case _Contributor Terms_ or _Terms of Use_ were updated since last > agreeing to them The Contributor Terms and Terms of use are different. The Contributor Terms are what grants the OSMF the right to distribute your data and they've never been updated. The [Terms of Use](https://osmfoundation.org/wiki/Terms_of_Use) cover accessing OSMF services. These have had minor updates, but they're not integrated into the website as they apply to all OSMF services, regardless of if the user has had an account. Handling new CTs would be nice to have, but it's not a feature that would be used right now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5706#issuecomment-2667740170 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
pnorman left a comment (openstreetmap/openstreetmap-website#4042) My PR won't touch OpenMapTiles stuff. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2985592436 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
Based on #4042 and https://github.com/openstreetmap/openstreetmap-website/pull/4042/files#r1966844335 This PR adds a Leaflet.Maplibregl-based layer using Versatiles Colorful. The issue I'm having right now is relative URLs. To use relative URLs for sprites, tiles, and glyphs, you need to use [`TransformStyleFunction`](https://maplibre.org/maplibre-gl-js/docs/API/type-aliases/TransformStyleFunction/). This can only be supplied to [`Map.setStyle()`](https://maplibre.org/maplibre-gl-js/docs/API/classes/Map/#setstyle). In the demo page I did this [fairly easily](https://github.com/openstreetmap/vectortile-website/blob/6d459cec4940e8488d0f7695940256f5f5dc8feb/demo/shortbread/index.html#L62-L69), but I wasn't dealing with Leaflet.Maplibregl. I'm not sure what the best approach here is. Some options I considered are 1. making colorful.json use absolute paths. This has a few secondary effects a. I'd still need to use `TransformStyleFunction` on the demo page since vector.openstreetmap.org should load tiles/sprites/glyphs via the CDN and dribble.openstreetmap.org should load tiles/sprites/glyphs off of dribble b. I'd want to put CORS restrictions on `https://vector.openstreetmap.org/demo/shortbread/colorful.json` restricting it to OSM domains and testing domains (e.g. localhost). Users of the tile layer should be hosting the style on their website, not depending on what we're hosting 2. Figuring out how to use `TransformStyleFunction` in Leaflet. I'm not sure if this is possible or where to start. I did consider building the colorful.json style in this repo but decided against it. Some aspects of the style (glyphs, sprites) will have to be built externally no matter what, and it's best to keep the style JSON build with those other parts. What I need is some input on what approach to take with the relative/absolute URLs. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6137 -- Commit Summary -- * Add Shortbread-based vector tile layer -- File Changes -- M app/assets/config/manifest.js (1) M app/assets/javascripts/leaflet.map.js (19) M app/assets/javascripts/osm.js.erb (3) M app/controllers/application_controller.rb (2) M config/eslint.config.mjs (3) M config/initializers/content_security_policy.rb (2) M config/layers.yml (9) M config/settings.yml (1) M package.json (3) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6137.patch https://github.com/openstreetmap/openstreetmap-website/pull/6137.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Landing page to promote OSM (Issue #6006)
pnorman left a comment (openstreetmap/openstreetmap-website#6006) > Can i work on this issue. Anyone can work on this issue. It might not be a great starting place for someone new. The technical changes are likely to be easy, the hard part is figuring out what text to have in which place. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6006#issuecomment-2937842806 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
pnorman left a comment (openstreetmap/openstreetmap-website#6137) I'm not sure what the CI failure is from. ``` Sprockets::FileNotFound: couldn't find file '@mapbox/mapbox-gl-rtl-text/mapbox-gl-rtl-text.js' (Sprockets::FileNotFound) ``` I don't get this in my local environment or see it in #4042 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3034759062 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 2700ec23e92960f2ebe5df1b2cc9395dddfb Fix path to RTL plugin -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/7f98378630eaba699e152602046fa3a7eab924e1..2700ec23e92960f2ebe5df1b2cc9395dddfb You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae Fix manipulation of VT style URLs -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/f32315a96f4920495c22409ed8070536a4d61642..0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
pnorman left a comment (openstreetmap/openstreetmap-website#6137) I've got it working now. When this is ready for merging I'll rebase and squish before taking it out of draft. How should I handle updating yarn.lock? Should I just accept all the changes? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3017293700 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
pnorman left a comment (openstreetmap/openstreetmap-website#4042) I *think* there was a question that still needed answering from MapTiler about the featured layer discussions. I'll have to review emails or check notes to be sure -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3026616606 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 2 commits. a9173ab7122ee5130d39119c68e669cac81dd9e9 Add yarn.lock 719be1bc44e6f8becf9c36edaff38985ca380d36 Add shortbread translation key -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae..719be1bc44e6f8becf9c36edaff38985ca380d36 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 7f98378630eaba699e152602046fa3a7eab924e1 Improve a vectortile comment -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/719be1bc44e6f8becf9c36edaff38985ca380d36..7f98378630eaba699e152602046fa3a7eab924e1 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
pnorman left a comment (openstreetmap/openstreetmap-website#6137) > Did you plan to integrate the language selector as well No. I don't plan to look at any language stuff until that stuff has been defined in the shortbread spec -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3076702259 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 7a80c3c3b57f5568b6bc06f83e5f51364f137b62 Add Shortbread-based Vector Tile layer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/63e13015955d7b9272950e6a4f8491add46c98c0..7a80c3c3b57f5568b6bc06f83e5f51364f137b62 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)
@pnorman commented on this pull request. > @@ -56,151 +62,158 @@ sudo dnf install ruby ruby-devel rubygem-rdoc > rubygem-bundler rubygems \ If you didn't already have PostgreSQL installed then create a PostgreSQL instance and start the server: -``` +```bash sudo postgresql-setup initdb Yes, installing on Debian or Ubuntu creates a cluster with the standard setup. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6111#discussion_r2203172004 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 292606319ccceff6e63aad613533695a4a04831e Add Shortbread-based Vector Tile layer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/2700ec23e92960f2ebe5df1b2cc9395dddfb..292606319ccceff6e63aad613533695a4a04831e You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 63e13015955d7b9272950e6a4f8491add46c98c0 Add Shortbread-based Vector Tile layer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/292606319ccceff6e63aad613533695a4a04831e..63e13015955d7b9272950e6a4f8491add46c98c0 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add user preferences support to iD editor via server-side rendering (PR #6199)
pnorman left a comment (openstreetmap/openstreetmap-website#6199) > This enables the iD editor to access user-specific preferences (such as > display settings, editor configurations, etc.) that were previously only > available through separate API calls, improving performance and reducing > client-server round trips during editor initialization. It seems that all of these would come from one call of `/api/0.6/user/preferences`. As it's only one call, it doesn't seem like it would have a large performance impact. Or is the concern that a user might have other large preferences (e.g. overpass turbo queries) and the `/preferences` result will be too large? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6199#issuecomment-3083165985 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
@pnorman pushed 1 commit. 61f61b47370f943bf7a8005a7de9637b2de49c17 Add Shortbread-based Vector Tile layer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/7a80c3c3b57f5568b6bc06f83e5f51364f137b62..61f61b47370f943bf7a8005a7de9637b2de49c17 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
pnorman left a comment (openstreetmap/openstreetmap-website#6137) I'm happy on the server side -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3097953074 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add Shortbread dark mode style (PR #6213)
pnorman left a comment (openstreetmap/openstreetmap-website#6213) > Are you happy with this @pnorman? The eclipse style isn't great, but it's probably no worse than the client-side color changes made to OpenStreetMap Carto so I'm okay with it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6213#issuecomment-3105012955 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
