Re: [openstreetmap/openstreetmap-website] Switch to dynamic allocation for the Firefox bidi port (PR #5820)

2025-03-19 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820)

> I think this pull request completely broke route planning in Firefox, as 
> there’s now a missing `currentLocale` function: #5821

Seems to be unlikely, as this is just related to the testing framework … 
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-2737340689

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737443572
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Switch to dynamic allocation for the Firefox bidi port (PR #5820)

2025-03-20 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820)

My issue is now fixed … it was caused by the recent i18n update: #5811 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2740300801
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Cannot calculate any directions – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-03-19 Thread Openstreetmapler via rails-dev
Openstreetmapler created an issue (openstreetmap/openstreetmap-website#5821)

### URL

https://www.openstreetmap.org/directions?engine=fossgis_valhalla_car&route=42.038752%2C13.626598%3B42.038752%2C13.626598#map=19/42.038804/13.627943

### How to reproduce the issue?

Go to the above URL. The route will never be calculated and there’s an endless 
loading spinner.

### Screenshot(s) or anything else?

Error in the browser console:
```
17:23:32.586 Uncaught TypeError: OSM.i18n.currentLocale is not a function
getRoute 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
s 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:8
y 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
setValue 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:8
d 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
load 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
run 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
load 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9
 
https://www.openstreetmap.org/assets/index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:1
u 
https://www.openstreetmap.org/assets/application-819d5ef9c9be076fee37756c270ec7ab72d539c4e87c6a55121841d48df2e845.js:12
d 
https://www.openstreetmap.org/assets/application-819d5ef9c9be076fee37756c270ec7ab72d539c4e87c6a55121841d48df2e845.js:12
index-fb5318a386ef84e62dbd686715e843ad6afc2cb94d8c1c31114220032f53d736.js:9:8703
```

This JavaScript crash prevents the fetch-route code from executing, as there’s 
never a network request sent for getting directions.

As the missing function is called `currentLocale`, I tried [changing the 
language of my OSM account](https://www.openstreetmap.org/preferences) from 
German to English, to no avail.

Yesterday (18 March 2025, 18:00 UTC), it worked fine, but today (19 March, 
16:20 UTC), it’s broken. A recent commit might have broken something, so please 
review them one more time. **Please do it quickly!**

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Switch to dynamic allocation for the Firefox bidi port (PR #5820)

2025-03-19 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820)

I think this pull request completely broke route planning in Firefox, as 
there’s now a missing `currentLocale` function:
https://github.com/openstreetmap/openstreetmap-website/issues/5821

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737325351
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-03-19 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5821)

Found a likely culprit:
#5820 includes some Firefox-specific changes which are related to `bidi` 
(bidirectionality of text), i.e. a locale-related thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-2737330293
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-03-20 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5821)

Thank you a lot for the quick fix! I really appreciate your time! 😊

(However, why did it still work one day before reporting the issue? I suspect 
it was caused by upstream changes to i18n since dependencies were updated 
recently.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-2740282959
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Make the persistent permalink URL update less frequently (#506)

2025-05-16 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#506)

Using Firefox, I opted for the following intermediate solution:
1. Install the [Historia](https://addons.mozilla.org/firefox/addon/historia/) 
browser extension.
2. Open the extension options (click on the icon and then on “Open Options”).
3. Add the following regular expression to the list of filtered URLs:
`/^.+www\.openstreetmap\.org.+#map=.+$/`
This will prevent all OpenStreetMap website URLs (also during editing) 
with a map location hash from being recorded in the browser history.
- You can customize this regex, e.g. to only block history entries at 
higher zoom levels – the following regex will only allow browser history 
entries up to zoom level 9:
`/^.+www\.openstreetmap\.org.+#map=[12][0-9].+$/`

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/506#issuecomment-2886844345
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev