Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
> Did anyone try them with these layers?

Sorry this is probably not the feedback you want, but honestly I think they all 
look bad, even option 4 (unless maybe for specific use cases but not in 
general) and they should only be available as optional dark styles, and light 
tiles should remain the default with the dark UI.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2498539065
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-24 Thread Nekzuris via rails-dev
> One thing was wrong, the filter was applied twice. Yes, no one noticed it in 
> 6 months.

That’s funny because hundreds of people complained about it within the first 
hour it was live.

It doesn’t matter that it was applied twice, you and every other dev saw it 
like that thought it was fine. You’re just using the fact that it was applied 
twice to justify reducing the intensity by half as a bug fix. But if it had 
only been applied once in the first place, you would have set the filter to 0.6.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2496229810
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-24 Thread Nekzuris via rails-dev
> Everyone had ~6 months to test the dark mode before it was launched 

I use OSM almost daily, from time to time on Discord and forums, I even 
contribute to iD occasionally, but I never saw any indication that a dark mode 
was in active development and about to be released.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2496157361
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode (PR #5340)

2024-11-18 Thread Nekzuris via rails-dev
Closes #5327 
See #5328 and 
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2482070226
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5340

-- Commit Summary --

  * Remove brightness filter for map tiles in dark mode

-- File Changes --

M app/assets/stylesheets/common.scss (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5340.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5340.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5340
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-20 Thread Nekzuris via rails-dev
In any case, the current implementation of the dimming filter for all dark mode 
users is problematic.

I believe that providing an easy way to switch between light and dark maps 
independent of the UI like 
[this](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496)
 is essential, regardless of what we do for dark maps.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2489268810
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-19 Thread Nekzuris via rails-dev
The control buttons don't change in dark mode, I think that's good, but the 
tooltip shouldn't change then.
current dark mode vs light mode
![dark](https://github.com/user-attachments/assets/4832f8ea-1b79-41d0-8aa2-12f6ae175db5)
 
![light](https://github.com/user-attachments/assets/0da60b4b-b797-44ff-9780-1689a33d3849)

And I don't think the lighter background behind the 𝐢 looks good.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2487203946
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-20 Thread Nekzuris via rails-dev
> How would you like to have the button indicate that it's disabled then?

I think the tooltip is enough, but yeah I see your point.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2489102649
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
I don't think so, it's very noticeable, it drop to like 10fps.
And it's actually fine now on my laptop, I hadn't tested since last year, so it 
might no affect as many people as I thought, I will investigate further on my 
computer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480673159
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
I resolved my performance issue 🎉

I'm not sure about the root cause, but I managed to fix it by disabling style 
customization with userChrome.css (which I use to change bookmark icon in the 
toolbar) in `about:config` 
`toolkit.legacyUserProfileCustomizations.stylesheets`, then restart Firefox, 
and the best part is that I can re-enable it, restart, and now everything works 
perfectly!

I never add to do this on my laptop, style customization was always enable and 
working, it simply fix itself in a recent update apparently but not on my 
computer.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480852987
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-16 Thread Nekzuris via rails-dev
Contrast is a bit too low in the topbar, even in light mode. Chrome shows green 
at 4.5 but I think it should be even higher since this text is important.
![image](https://github.com/user-attachments/assets/909efbe8-e8ce-402b-9296-1c7bc08101b4)
![image](https://github.com/user-attachments/assets/cd30b217-83b8-4d89-95ce-9a5ecf729d54)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2480869915
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
@gravitystorm It's also because the Carto render is iconic to OpenStreetMap, 
many people only recognize OSM by this map style and changing it makes it feel 
unfamiliar. 
Even if we already had a proper dark render, I would still want to see the 
light Carto render for some tasks without having to disable the dark UI.

> It's unfortunate that some people experience it, but I see no reason to think 
> that it's super popular.

Just deploy it, we’ll see if many people complain 😅

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480747915
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
No I have an i7 10700K and RTX 3060, Firefox 132.0.1, Windows 10, 2560×1440p 
144Hz.
It's also slow on my less powerful laptop but completely fine on Firefox for 
Android.

I found these bug reports: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1826576 & 
https://bugzilla.mozilla.org/show_bug.cgi?id=1498291
Not everyone seems to be impacted with the same severity.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480636111
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-11-15 Thread Nekzuris via rails-dev
> why you want dark mode for everything else, but not for OSM.

Not only OSM, but maps in general looks bad in dark mode. I have all my apps in 
dark mode except maps app.
But a darker UI with normal tiles looks nice.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480197151
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-15 Thread Nekzuris via rails-dev
These should be style on there own, but not imposed on dark mode users.
I think it's clear that many peoples appreciate the dark UI with normal tiles.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480208235
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-15 Thread Nekzuris via rails-dev
> having a dark map in dark mode seems like a sane default 

Yes indeed, but the current implementation by dimming 20% is worst than using 
regular tiles with a dark UI.
Dark mode should default to a proper dark rendering and still provide the 
option to use regular tiles without dimming.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480325259
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Apply dimming filter to tiles directly (PR #5330)

2024-11-15 Thread Nekzuris via rails-dev
The use of css `filter: brightness(0.8);` makes panning extremely laggy in 
Firefox.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5330#issuecomment-2479700613
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-15 Thread Nekzuris via rails-dev
Readability is bad due to poor contrast with blue.
![image](https://github.com/user-attachments/assets/e3e25e08-2733-4e78-ab47-1beea9ab753d)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2480037520
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-18 Thread Nekzuris via rails-dev
@ChrisJoubert2501 I managed to fix my performance issue by disabling and 
re-enabling style customization with userChrome.css in `about:config` 
`toolkit.legacyUserProfileCustomizations.stylesheets`, restarting Firefox after 
each setting change.

However, other users with less powerful machines and no hardware acceleration 
are still experiencing performance reductions.

Also note that screen recordings like this are less impressive because you 
don't feel the input lag.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2482990437
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2024-11-17 Thread Nekzuris via rails-dev
Imo the background around the search box is unnecessary:
![image](https://github.com/user-attachments/assets/23b180c2-5808-40f9-bfca-f450104dba72)
![image](https://github.com/user-attachments/assets/292c5575-f36b-4d7d-88d3-ef1ab1705647)
maybe replace is by a shadow

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2481269993
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-17 Thread Nekzuris via rails-dev
Can someone merge #5327 ?
It's unacceptable that all users with a dark browser preference are forced to 
endure the highly controversial dimming while waiting for a better solution to 
be implemented.
Their only options currently are switching all websites to light mode or 
install an extension to override the CSS.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2481552805
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-11-17 Thread Nekzuris via rails-dev
What are you waiting to merge this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2481495761
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-15 Thread Nekzuris via rails-dev
I see no one is testing for Firefox, option 1 should be used because CSS filter 
are not well optimized on Firefox and makes panning very laggy, even on good 
computer.

It's not very noticeable in this screen recording because you don't see the 
mouse input lag, try it for yourself.

https://github.com/user-attachments/assets/ee0db0c1-b54e-4c61-bd0e-ae22d3c14f8f



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2479903945
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-15 Thread Nekzuris via rails-dev
The map is like a photo, and any photo-viewing applications display photos the 
same way regardless of whether they are in dark or light mode.

As previously said, dark mode is more about contrast, and should actually be 
bright if used in a bright environment. 
If the user is in dark environment, he will dim the whole screen.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480021036
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
That's the question, certainly not the current one with 20% dimming, maybe a 
more complex filter can work while waiting for vector tiles or simply keep the 
same as light mode for now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480602226
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
>  They don't change much between light/dark modes.

![image](https://github.com/user-attachments/assets/499c55f2-65bc-4977-8b6b-04cc8c4e62a4)
They certainly don't decrease.

> Do we need different filters for different layers?

I don't think filters are a good idea, we just need one good dark style. Styles 
have unique and carefully chosen color palettes, and you can't just apply a 
filter to make them dark mode. There will always be edge cases where it looks 
bad, as well as performance issues.

> Couldn't the dark mode have waited for the release of the vector.osm.org 
> tiles?

I think we would still be waiting for dark mode in 2030 if we waited for 
everything to be perfect. This will at least accelerate development. If a beta 
dark mode had been released in 2020, we would have a perfect one by now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480592759
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
> Do you mean not showing layers that don't have a version with dark tiles? 

No, normal tiles with dark UI looks great, just add a dark style in addition to 
the others and make it default for dark mode but easy to change.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480599162
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-16 Thread Nekzuris via rails-dev
@pkrasicki And you can drag the map smoothly? I have a huge increase in input 
lag when dragging the dark map.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480624689
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
@AntonKhorev It’s unreasonable for you to expect OSM users to look at all the 
pull requests to give feedback before a change as significant as this one gets 
implemented.
Many other websites and apps I use started by adding a dark mode toggle in the 
settings, staying in light mode by default until they were confident enough to 
link it to user preferences.

But apparently maintainers here think it’s fine to impose the dimmed tiles on 
every dark mode user until a proper solution is implemented, which I guess will 
still take several weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2498384131
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
> so it seems osm needs a 'beta.osm org' 

I thought we already had that, but it’s only for iD 
(https://ideditor.netlify.app/).
But I don’t think it’s necessary, a simple post on the official OSM social 
media announcing that a new dark mode is available for testing in the settings 
would have been perfect.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2499284960
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-26 Thread Nekzuris via rails-dev
> you can't have a button in the header for every possible setting

Sure, but I think appearance and language are important enough to be quickly 
accessible at all times, like on Wikipedia.

Another option to consider would be placing them directly in the drop-down 
menu, like on YouTube or Reddit:
![image](https://github.com/user-attachments/assets/385c4e62-9b06-4edd-92ac-0163e1722adf)
 
![image](https://github.com/user-attachments/assets/0a9ffaf6-81aa-412d-9c60-1c793c5f97dc)



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2563199478
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-11 Thread Nekzuris via rails-dev
Call it what you want, but I think we've collected enough feedback to conclude 
that dark maps aren't ready to be the default.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2537238479
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-11 Thread Nekzuris via rails-dev
No because non-logged in users can't set light map.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2537382117
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-12-10 Thread Nekzuris via rails-dev
I found another technical reason to merge this ASAP: the filter is causing a 
black and white grid to flicker around tiles borders while zooming on Chrome. 
It’s slightly noticeable on desktop but very annoying on mobile.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2533563807
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-12 Thread Nekzuris via rails-dev
Apparently this was decided 
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626)
 but I don't understand this choice @gravitystorm.
Even for registered users it's bad because they can't set dark on desktop and 
light on mobile for example.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2539359220
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] White grid around map tiles when page zoom set to 33%, 67%, 80%, 85%, 90% or 115% (Issue #5109)

2024-12-16 Thread Nekzuris via rails-dev
Okay, I don’t have a Mac to test with Safari, but I found an extension to 
precisely change zoom levels on Chrome and it looks like _mix-blend-mode: 
plus-lighter_ creates problems more often than not, so it should only be 
applied to specific pixel ratios where it’s been confirmed to work.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5109#issuecomment-2546649393
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] White grid around map tiles when page zoom set to 33%, 67%, 80%, 85%, 90% or 115% (Issue #5109)

2024-12-14 Thread Nekzuris via rails-dev
@verhovsky How did you set specific zoom values like 85% and 115%?
I found that this white grid can simply be removed with CSS exceptions for 
specific pixel ratios (see https://github.com/Leaflet/Leaflet/pull/9560) but I 
was only able to test for these values 
https://github.com/openstreetmap/iD/pull/10594#issuecomment-2540006158.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5109#issuecomment-2543357197
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Improve key for Standard layer (#1307)

2024-11-22 Thread Nekzuris via rails-dev
Thank you for your work on this.
I was going to request the addition of Tracestrack Topo, but I realize this is 
a bigger problem than it seems. If someone is going to work on it, the effort 
would be better spent creating a script to automatically generate the keys from 
the map stylesheet, making them available for every layer and ensuring they 
never become outdated.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1307#issuecomment-2494520899
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-17 Thread Nekzuris via rails-dev
> I don't think a map is like a photo at all. It's not satellite images, it's 
> just a bunch of data

You only consider labels and lines, but with fill colors and shadows, it’s more 
like a digital painting. 
Style creators spend a lot of time carefully designing it, and you can’t just 
override it with a filter.

> There might be people who want to enjoy dark/light theme without changing 
> their system settings.

Definitely, most dark theme websites have this switch.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2481327106
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-17 Thread Nekzuris via rails-dev
> I'm not aware of any performance issues with CSS filter

Have you tried a more complex filter like `brightness(0.6) invert(1) 
contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7)` on Firefox?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480615574
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-23 Thread Nekzuris via rails-dev
On a grayscale, the default OSM light theme is actually 19% dark, whereas a 
typical light page with black text is around 3%.
The dark theme you showed is 90% dark.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2495539269
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-12-05 Thread Nekzuris via rails-dev
@tomFlowee Only maintainers can merge this, there are three: one is in favor, 
another is the one who added the filter, and the last one doesn't want to do 
anything related to dark mode. It's ridiculous.

You can install the Stylus extension 
([Firefox](https://addons.mozilla.org/en-US/firefox/addon/styl-us/), 
[Chrome](https://chromewebstore.google.com/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne))
 and apply this CSS [Un-Darken Map Tiles](https://userstyles.world/style/19312).


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2521883256
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev