[openstreetmap/openstreetmap-website] input_marker checked by default (PR #6031)

[Martin Monperrus via rails-dev]

fix #6025
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6031

-- Commit Summary --

  * input_marker checked by default

-- File Changes --

M app/assets/javascripts/leaflet.share.js (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6031.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6031.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6031
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] link by gps coordinates does not show a pin (Issue #6025)

[Martin Monperrus via rails-dev]

monperrus left a comment (openstreetmap/openstreetmap-website#6025)

Created https://github.com/openstreetmap/openstreetmap-website/pull/6031 
accordingly

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025#issuecomment-2893165170
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] input_marker checked by default (PR #6031)

[Martin Monperrus via rails-dev]

monperrus left a comment (openstreetmap/openstreetmap-website#6031)

yes, the default can only match the intuitive expectation of the majority. hard 
to measure though.

I believe that lots of people expects markers because this is how it's done in 
lots of Maps apps, incl. Google Maps.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6031#issuecomment-2893723139
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

[openstreetmap/openstreetmap-website] link by gps coordinates does not show a pin (Issue #6025)

[Martin Monperrus via rails-dev]

monperrus created an issue (openstreetmap/openstreetmap-website#6025)

### URL

https://www.openstreetmap.org/?#map=15/55.70787/13.21166

### How to reproduce the issue?

## Action

Send or receive a link with map parameter with latitude and longitude 


## Actual behavior

The map is shown without a pin.

![Image](https://github.com/user-attachments/assets/48c1ca06-b367-4d03-9332-63896ad10969)

## Expected behavior

The map is shown with a pin at the exact given coordinates.

![Image](https://github.com/user-attachments/assets/7527c82d-28da-46a3-b691-cb99c6bfcd88)

### Screenshot(s) or anything else?

_No response_

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] link by gps coordinates does not show a pin (Issue #6025)

[Martin Monperrus via rails-dev]

monperrus left a comment (openstreetmap/openstreetmap-website#6025)

thanks @tomhughes for the fast answer.

the use case is to send a URL to somebody to meet, the positioning fragment is 
meant to be this location and is expected to be shown on the map.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025#issuecomment-2890210131
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] link by gps coordinates does not show a pin (Issue #6025)

[Martin Monperrus via rails-dev]

monperrus left a comment (openstreetmap/openstreetmap-website#6025)

Because this is the URL I get when I click on "share" :)



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025#issuecomment-2890242921
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] link by gps coordinates does not show a pin (Issue #6025)

[Martin Monperrus via rails-dev]

monperrus left a comment (openstreetmap/openstreetmap-website#6025)

OK, there is the option, then my issue is about the default.

The default, shortest URL, could be with marker.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025#issuecomment-2890249755
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev