[openstreetmap/openstreetmap-website] Notes controller calls set_locale after lookup_user which can cause unexpected language for 404 users notes (Issue #5251)

2024-10-07 Thread Grant via rails-dev
### URL

https://www.openstreetmap.org/user/Omaraltab/notes

### How to reproduce the issue?

Refreshing the URL occasionally returns the 404 page in an unexpected language.

https://github.com/openstreetmap/openstreetmap-website/blob/acd899d26dbf09620d598d74759fc6f7aac4846a/app/controllers/notes_controller.rb#L12

### Screenshot(s) or anything else?

Page unexpectedly in German:
https://github.com/user-attachments/assets/9a733469-4572-45a1-8968-0ad472914c8a";>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Slow objects fetching on backend (Ruby on Rails) (Issue #5342)

2024-11-20 Thread Grant via rails-dev
> > Really this is a bug tracker, not a support forum, but bear in mind that 
> > our production setups don't even use the rails API implementation for the 
> > main map data calls precisely because there is no way to get reasonable 
> > performance.
> > If you have significant amounts of data you probably want to be using 
> > [cgimap](https://github.com/zerebubuth/openstreetmap-cgimap/) for the API 
> > calls it supports.
> 
> really? production APIs are written on c++?

For reference you can find the API calls we send to cgimap here:
https://github.com/openstreetmap/chef/blob/08be09e5a29886586d4955e6bdcc6592ed6e531e/cookbooks/web/templates/default/apache.frontend.erb#L179-L190

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5342#issuecomment-2488302914
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Show heatmap only to logged in users (PR #5829)

2025-03-20 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#5829)

In addition to this, some users may still prefer to hide their heatmap.

Here is what the feature looks like on github:

https://github.com/user-attachments/assets/4766559f-0a46-49fd-a580-0d5d4a86d9de";
 />


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829#issuecomment-2741886182
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-04-05 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#5821)

> Found a likely culprit: 
> [#5820](https://github.com/openstreetmap/openstreetmap-website/pull/5820) 
> includes some Firefox-specific changes which are related to `bidi` 
> (bidirectionality of text), i.e. a locale-related thing.

I don't think so. #5820 is purely a testing framework change.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-2737340689
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Show heatmap only to logged in users (PR #5829)

2025-04-04 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#5829)

> We don't have:
> 
> * private profiles
> * private contributions

The "Make [...] and **hide activity**" is the relevant portion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829#issuecomment-2743331023
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)

2025-05-28 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6028)

It is possible the CORS error was due to Cloudflare running an experiment. They 
occasionally run live experiments on our tier before full rollout / rollback.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6028#issuecomment-2915624013
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Add additional common SPAMMY_PHRASES (PR #6044)

2025-05-23 Thread Grant via rails-dev
### Description
Add additional spam phrases to catch additional spam profiles.

### How has this been tested?
TBC
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6044

-- Commit Summary --

  * Add additional common SPAMMY_PHRASES

-- File Changes --

M lib/rich_text.rb (18)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6044.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6044.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6044
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add additional common SPAMMY_PHRASES (PR #6044)

2025-05-23 Thread Grant via rails-dev
@Firefishy pushed 1 commit.

71027c46a0598066b3cf6642d57eaeef37d8faf6  Add additional common SPAMMY_PHRASES

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6044/files/f3acc9d1cebb50182332a442b0eb0bfc09c5c1b1..71027c46a0598066b3cf6642d57eaeef37d8faf6
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] When using QGIS and OpenTopoMap scales of less than 1:3500 cause a failed network request (Issue #6114)

2025-06-17 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6114)

You will have to contact them. This is the repo for the OpenStreetMap website 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6114#issuecomment-2982265389
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] When using QGIS and OpenTopoMap scales of less than 1:3500 cause a failed network request (Issue #6114)

2025-06-17 Thread Grant via rails-dev
Closed #6114 as not planned.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6114#event-18200579907
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] User Social profile links should contribute to Spam Score (Issue #6090)

2025-06-06 Thread Grant via rails-dev
Firefishy created an issue (openstreetmap/openstreetmap-website#6090)

### How to reproduce the issue?

Previously spammers would use their user profile description for promoting 
their spam links, this would affect their User Spam Score.

Spammers are now using the Social profile links feature for promoting their 
spam links, which currently does not affect their User Spam Score

Each Social profile link should contribute a small proportion the User's Spam 
Score so some spammers are automatically suspended.

PS: Display Name == User Location Name is also currently a high correlation for 
spam profiles.

### Screenshot(s) or anything else?

_No response_

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6090
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Mention how long read-only mode lasts (Issue #6135)

2025-06-26 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6135)

https://en.osm.town/@osm_tech/114749783705346288
https://lists.openstreetmap.org/pipermail/announce/2025-June/000121.html
https://community.openstreetmap.org/t/is-osm-partially-down-new-data-isnt-able-to-be-queried-on-the-map-and-new-data-isnt-being-rendered/131884/14

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6135#issuecomment-3008535543
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)

2025-07-01 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6154)

https://github.com/user-attachments/assets/ebc9f809-399f-42ee-b412-42c581d0733d";
 />


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3025313972
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)

2025-07-01 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6154)

I think adding some timeout safeguards to our GitHub Actions would be a good 
idea. We don't have unlimited runtime and the default timeout is an extremely 
long 6 hours.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3023952688
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


[openstreetmap/openstreetmap-website] Notes 404 page can return in wrong language (Issue #6156)

2025-07-01 Thread Grant via rails-dev
Firefishy created an issue (openstreetmap/openstreetmap-website#6156)

### URL

https://www.openstreetmap.org/user/Clean%20Cuts%20Tree%20Care/notes

### How to reproduce the issue?

After a few reloads of example page it will display in the wrong language. 
https://www.openstreetmap.org/user/Clean%20Cuts%20Tree%20Care/notes

I believe the display language is not being set by controller before 404 
resulting in the presentation language not being deterministic. 

### Screenshot(s) or anything else?

https://github.com/user-attachments/assets/46e49790-a288-4de3-87ae-0aa0090a36f5";
 />

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6156
You are receiving this because you are subscribed to this thread.

Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

2025-07-02 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6127)

Are WikiData ok with us doing this? Will they rate limit us like they do on 
wiki.osm.org with WikiCommons?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#issuecomment-3028886860
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


Re: [openstreetmap/openstreetmap-website] Add Cross-Origin-Opener-Policy header (2ff4d6a)

2025-07-11 Thread Grant via rails-dev
Creating some outreach about the security update:
* https://operations.osmfoundation.org/2025/07/11/security-notice.html
* https://en.osm.town/@osm_tech/114835178232370008

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a16074103cd9#commitcomment-161957786
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev