[openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)
### URL
https://www.openstreetmap.org/messages/inbox
### How to reproduce the issue?
0. Have at least 1 message in the inbox
1. Mark it as read/unread
2. Notice that two requests are made at the same time (one POST and one GET).
The POST request goes to
`https://www.openstreetmap.org/messages/{id}/mark?mark=unread`, while the GET
request goes to `https://www.openstreetmap.org/messages/inbox`. Both requests
return the same HTML code, which seems a bit wasteful on server resources if
both are generated independently.
The most logical solution would be to change the response body of the POST
request to have some short status code/text instead of the whole page HTML
(assuming that won't break the turbo integration).
### Screenshot(s) or anything else?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222
You are receiving this because you are subscribed to this thread.
Message ID: ___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Bogus comment is added when a note is reopened (Issue #5359)
### URL https://www.openstreetmap.org/note/4537701 ### How to reproduce the issue? 1. Press "Reopen" on a closed note The bogus is content is likely dynamically generated, since it "leaks" the user's UI language and the current map view. ### Screenshot(s) or anything else? Also see https://www.openstreetmap.org/note/3958106 https://www.openstreetmap.org/note/4482755 https://www.openstreetmap.org/note/4537279 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5359 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)
The numbers on profile pages are hard to read.  --- The popovers (or whatever these balloons are called) should have dark background, right?  --- Some items in the map legend are hard or almost impossible to see, others have distorted colours (major roads for example). The screenshot is from zoom level 17.  --- The buttons on each message in the inbox and outbox should probably use outline buttons.  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2480760001 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Login page does not check if a user is logged in (Issue #5441)
> We can add a message to the login page that you're already logged in. And if > there's a referrer, we can add a link to that page. That is a good solution, given the fact the current behavior is useful to some people. > Quite this is behaving as intended but the user has changed context behind > the site's back - the page was rendered in one context with a set of cookies > that indicated the user is logged in and the user then switched to a > different context with different cookies which is not really a supported > thing to do. Just for the record, the change is not "behind the site's back". When switching containers, a new tab is opened and the page is loaded again. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5441#issuecomment-2563582731 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
It is a very minor nitpick, but is it possible to dynamically determine what's the first weekday based on the user's locale and adjust the heatmap accordingly? [Intl.Locale.prototype.getWeekInfo()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWeekInfo) could be used. It isn't currently available in Firefox but all other browsers have it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2549492091 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (#3310)
Since #5261 is merged, this issue should be marked as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3310#issuecomment-2600962204 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Login page does not check if a user is logged in (Issue #5441)
### URL https://www.openstreetmap.org/login?referer=%2Fedit%3Frelation%3D15090094#map=19/33.411025/-114.923289 ### How to reproduce the issue? 1. Open osm.org in a container that is not normally used for osm.org (i.e. you are not logged in there) 2. Press "Edit" (you are redirected to the login page, some referrer value is added to the URL) 3. Change the container of the tab (right click tab -> "Open in new container tab" -> select the container where you are logged into OSM) 4. The login page is displayed even though you are logged in The expected behavior would be to check if the user is logged in already and if he is, redirect him to the `referer` or to the main page. The bug appears in Firefox when using [multi-account-containers](https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/). I don't know if it's reproducible in other browsers. ### Screenshot(s) or anything else?  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5441 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] "Comments" link on the user profile should include changeset and note comments. (#1148)
Dimitar left a comment (openstreetmap/openstreetmap-website#1148) This issue, along with #842 should be marked as resolved by #5518. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1148#issuecomment-2727658311 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Preview the various profile image options in `/profile/edit` (Issue #5922)
Dimitar created an issue (openstreetmap/openstreetmap-website#5922) ### Problem Currently when you upload a new profile picture, the old one is shown on the left. When changing the selected option, nothing on the left side changes. Due to the fact that the image is quite small, it's not always possible to judge if it will look good, so a preview would be nice. ### Description For example: preview the uploaded (or selected) picture when "Replace current picture" is selected. Preview the default image when "Remove the current image" is selected. Possibly do something similar when "Use Gravatar" is selected. Show the current image when "Keep the current image" is selected. ### Screenshots  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5922 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] `highway=raceway` is rendered as an area if it's closed (Issue #5931)
Dimitar left a comment (openstreetmap/openstreetmap-website#5931) This is not an issue with the default map layer. The orange area is the "highlighting" (or whatever it might be called) that is shown when you select some element using `osm.org/way/123`. It is coming from the OSM website and not from a particular map style. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5931#issuecomment-2800996693 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] `highway=raceway` is rendered as an area if it's closed (Issue #5931)
Dimitar created an issue (openstreetmap/openstreetmap-website#5931) ### URL https://www.openstreetmap.org/way/169361659 ### How to reproduce the issue? 1. Go to https://www.openstreetmap.org/way/169361659 ### Screenshot(s) or anything else? I'm not 100% sure if this is an issue for this repo. I tried to find where "area-like" tags are defined in this repo but it seems like they aren't here.  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5931 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Invisible "X" button when using dark mode preference (Issue #5947)
Dimitar created an issue (openstreetmap/openstreetmap-website#5947) ### URL https://www.openstreetmap.org/node/8043886647 (or any place where an "X" button is visible) ### How to reproduce the issue? 1. Set "Preferred Website Color Scheme" to "Auto" in https://www.openstreetmap.org/preferences and, make sure that your OS/browser is set to prefer dark theme (or use the option in the dev tools) 2. Open https://www.openstreetmap.org/node/8043886647 (notice that the X button in the side panel is light grey) 3. Go to OSM's preferences and set "Preferred Website Color Scheme" to "Dark" 4. Open https://www.openstreetmap.org/node/8043886647 (notice that the X button in the side panel is completely black) ### Screenshot(s) or anything else? |Auto and prefer dark | Dark and prefer dark | |--|--| |  |  | -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5947 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
