Re: [openstreetmap/openstreetmap-website] restore in-progress comments after restoring a closed browser tab (Issue #5624)
Sorry I did try to search for prior tickets. I'm running Google Chrome, latest version, on Debian but from Google's repository, with no extensions enabled for openstreetmap.org, and yes it doesn't seem to restore by itself. GitHub does, OSM doesn't. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5624#issuecomment-2639802623 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] restore in-progress comments after restoring a closed browser tab (Issue #5624)
If a user is writing a changeset comment on a changeset page `https://www.openstreetmap.org/changeset/:id:` and they accidentally close the browser tab, the in-progress comment is lost upon restoring the tab. It would be preferable for the in-progress comment to be restored in the input text area upon restoring the tab. For example this happens here in GitHub, if you're entering a comment, writing an issue description and close the tab, then restore that tab, the in-progress text is restored. In my case this happens because in Vim Ctrl+W deletes the last word, but in Chrome it closes the tab and sometimes they can be mixed up. An alternative would be to popup that their message will be lost and if they should continue, but I see this as a worse UX. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5624 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Copyedit English localization as American English (PR #5029)
Just a note that if this is merged we'll need to do `en_AU` as currently most of the `en` ones work okay for Australian English, but that won't be the case if this is merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5029#issuecomment-2629631400 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Copyedit English localization as American English (PR #5029)
@andrewharvey commented on this pull request. >"yes": "Amenity" boundary: - aboriginal_lands: "Aboriginal Lands" + aboriginal_lands: "Indigenous Boundary" Which is a bit ironic considering we don't use the tag here https://wiki.openstreetmap.org/wiki/Australian_Tagging_Guidelines/Australia%27s_First_Peoples#Aboriginal_Reservations and claim it's better suited for use in the US. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5029#discussion_r1935478007 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Missing American English localization (Issue #4975)
> Filling Station Having seen this popup on openstreetmap.org under a search result, it lead me down this rabbit hole to find where that was defined. I would like to see support for localisation to en-AU, unfortunately TranslateWiki doesn't seem to support it. Is it possible to enable or can we instead manage the localisations directly here? I think as a global project we need to find a solution. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4975#issuecomment-2624227575 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] My user experience with number of changes on a changeset list (Issue #5770)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5770) > For me, the numbers that tell how many objects someone has added or removed > are meaningless, and only make it harder to see which changeset has a comment. I find the current combined number a bit meaningless, but split into add/edit/removed features very useful, eitherway some wider user testing could be useful. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5770#issuecomment-2712257576 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] add link to open view in OSMCha, from changesets history pge (#2629)
andrewharvey left a comment (openstreetmap/openstreetmap-website#2629) > If the tools are external, the means of launching them can also be external. > Browser extensions for that exist. JOSM is also external, but openstreetmap.org links to it via "Edit with Remote Control". A browser extension won't help with discoverability of these tools, and regardless shouldn't be necessary in my opinion. @pwbriggs I like your suggestion if making this configurable to the user! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2629#issuecomment-2799070045 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] restore in-progress comments after restoring a closed browser tab (Issue #5624)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5624) It's also very easy to happen by simply starting a comment, then clicking on a linked object within the changeset, and suddenly you loose your comment. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5624#issuecomment-2834438597 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Permalinks break when user changes their display name (#482)
andrewharvey left a comment (openstreetmap/openstreetmap-website#482) Recently a DWG member who had changed their display name, had another user claim their prior display name who then went on to use the profile to spread insults towards DWG members. This was problematic because the user profile URL was baked in to many places. The problem stems from the fact that this "Display Name" is treated and used by mappers as a stable username. I don't think that's going to change. I think it's best to treat the display name more like a username. You can change it, but nobody else can then reclaim your old usernames, and any links to your old username just redirect to your current username. This prevents this kind of user/display name theft, and helps reduce the effect of people using user/display name changes as a way to evade monitoring by the mapping community. Being able to scrutinise other mappers changes and work and tracing back the history of changes is very important and allowing users to claim another users previous username/display name makes that much more difficult. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/482#issuecomment-2861652942 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)
andrewharvey created an issue (openstreetmap/openstreetmap-website#5757) ### Problem A common use case of mine is to scan through a list of changesets to see what has comments. However perhaps due to recent changes? I find it hard to spot changesets with comments vs those without. Perhaps even making the 💬 sand out more with more colour would be good too. ### Description I suggest omitting the "0 💬" if no comments exist and only showing it where comments do exist. ### Screenshots  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)
andrewharvey created an issue (openstreetmap/openstreetmap-website#5758) ### Problem The current " 🖊" count in the changesets cards makes it hard to know exactly what type of edits were made. ### Description In OSMCha it shows added/modified/deleted feature counts as  which is very clear, it makes it easy to scan through a list of changesets for example to spot only new features, vs deletions or modifications. I suggest to change " 🖊" count to something like OSMCha with | | ### Screenshots  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5758 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] allow markdown in changeset comments (#844)
andrewharvey left a comment (openstreetmap/openstreetmap-website#844)
would be nice to use selected wikitext templates like `{{tag|informal|yes}}` or
alternatively just parse out a pasted URL like
`https://wiki.openstreetmap.org/wiki/Tag:informal%3Dyes` and display it as
[`informal`](https://wiki.openstreetmap.org/wiki/Key:informal)=[`yes`](https://wiki.openstreetmap.org/wiki/Tag:informal%3Dyes).
Suggesting tags to use within a changeset comment means either
1. enter the tag as `key=value` without any links (but then especially new
users don't know what that means or where to read up about it)
2. enter the full URL but this makes the comment long and hard to read the
exactly key=value from the url.
3. do both of the above, but the comment is still too long and harder to read
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Missing American English localization (Issue #4975)
andrewharvey left a comment (openstreetmap/openstreetmap-website#4975) > Why not fair? There should be one source file in one language. It will simply > be a source for translations, not a translation. Exactly. @1ec5 suggested that the source file is not in one language, but a mix of UK and US English. In OSM, I'm more inclined to make the source neutral and close to OSM tags, and then translate US from it, but that's another point. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4975#issuecomment-2708518807 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] pretty formatting of OSM URLS in notes, changeset comment, and comments (Issue #5780)
andrewharvey created an issue (openstreetmap/openstreetmap-website#5780) ### Problem Full URLs pasted within changeset comments and notes makes them harder to read, especially since they only have limited screen real estate. ### Description As suggested by @1ec5 at https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2708470716 we could take inspiration from GitHub and pretty format pasted URLs. I'm thinking within any 1. changeset comment 2. comment on a changeset 3. note 4. note comment Then format the content as follows | Pasted URL | Formatted Display | |---|---| | https://www.openstreetmap.org/note/4655490 | [note/4655490](https://www.openstreetmap.org/note/4655490) | | https://www.openstreetmap.org/changeset/163353772 | [changeset/163353772](https://www.openstreetmap.org/changeset/163353772) | | https://www.openstreetmap.org/way/1249366504 | [way/1249366504](https://www.openstreetmap.org/way/1249366504) | | https://www.openstreetmap.org/way/1249366504/history | [way/1249366504/history](https://www.openstreetmap.org/way/1249366504/history) | | https://www.openstreetmap.org/way/1249366504/history/2 | [way/1249366504 (v2)](https://www.openstreetmap.org/way/1249366504/history/2) | | https://www.openstreetmap.org/node/12639964186 | [node/12639964186](https://www.openstreetmap.org/node/12639964186) | | https://www.openstreetmap.org/relation/7876483 | [relation/7876483](https://www.openstreetmap.org/relation/7876483) | | https://www.openstreetmap.org/user/aharvey | [@aharvey](https://www.openstreetmap.org/user/aharvey) | | https://wiki.openstreetmap.org/wiki/Key:boundary | [`boundary=*`](https://wiki.openstreetmap.org/wiki/Key:boundary) | | https://wiki.openstreetmap.org/wiki/Tag:boundary=place | [`boundary=place`](https://wiki.openstreetmap.org/wiki/Tag:boundary=place) | | `boundary=*` | [`boundary=place`](https://wiki.openstreetmap.org/wiki/Key:boundary) | | `boundary=place` | [`boundary=place`](https://wiki.openstreetmap.org/wiki/Tag:boundary=place) | ### Screenshots _No response_ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5780 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] allow markdown in changeset comments (#844)
andrewharvey left a comment (openstreetmap/openstreetmap-website#844) > Many websites that accept Markdown end up pretty-printing raw URLs. For > example, GitHub turns > https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356 > into > https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356. > It isn’t the most discoverable syntax: you’d probably see people > occasionally trying to replicate the presentation by hand as > [`informal=yes`](https://wiki.openstreetmap.org/wiki/Tag:informal%3Dyes), but > I don’t think that would be a huge problem. Good idea! I think this is getting too far from the ticket here which is about user entered markdown content to be formatted, so I've opened #5780 for what you describe. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2708482692 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757) To be honest I don't know what it was previously, but whatever it was it was easy to scan through a list of changesets and find those with comments. Now it's next to impossible, but it also could be because of the edit count which is within the same space. I think putting the green, orange red boxes like OSMCha in the top right corner, then the changeset comment count in the bottom right corner is best. I think leaving 0 is okay but maybe then make it a stronger white/bold when there is a number >0. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-2708132371 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Missing American English localization (Issue #4975)
andrewharvey left a comment (openstreetmap/openstreetmap-website#4975) Reading the prior responses here it sounds like we should make `en` exclusively US English, it's not fair on the Americans to not allow them to have their own translations. Could you imagine not allowing Germans to have their own translations? `en-CA` is for Canadians. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4975#issuecomment-2708165065 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] allow markdown in changeset comments (#844)
andrewharvey left a comment (openstreetmap/openstreetmap-website#844) > But will those writing comments be bothered to paste the correct > urls/templates? Good point, then perhaps as you suggest parsing key=value would be okay and/or reducing a pasted full wiki link. Although the more we do this automatically the more important a preview/edit button is. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2708133021 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5758) > If OSMCha has it, why copy the same thing to osm.org? If someone needs > accurate data, that's what OSMCha is for. Better to have this by default on OSM.org in my opinion. Fragmenting into many different tools makes the learning curve harder and many people won't discover those tools. Then you had the add challenge of needing to copy paste changeset IDs all the time because all you have is a link to osm.org. Currently OSMCha is very painful to use, 15 seconds load time for each changeset to review, 10 seconds to load the list of changesets, if they have a useful feature then that's more the reason to add it back into OSM.org. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5758#issuecomment-2712262271 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] pretty formatting of OSM URLS in notes, changeset comment, and comments (Issue #5780)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5780)
> Also n12639964186, w1249366504 and r7876483 could have links added as well;
> or be converted to the {object}/{id} format.
Thanks, I've added these to the table, along with "way 1249366504" which are
all in common use.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2709309919
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] My user experience with number of changes on a changeset list (Issue #5770)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5770) Some issue as I reported in #5757 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5770#issuecomment-2709318451 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Missing American English localization (Issue #4975)
andrewharvey left a comment (openstreetmap/openstreetmap-website#4975) > I didn't know that such language exists :) `en_OSM` OpenStreetMaplish https://wiki.openstreetmap.org/wiki/Tag:shop%3Dalcohol#Localized_variants Where en_US it's Liquor Store, en_AU it's Bottle Shop, en_GB it's Off-license and in en_OSM it's simply an Alcohol Shop. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4975#issuecomment-2709323071 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5758) > If there's a performance issue with OSMCha, why not report it in their repo > in the first place? https://github.com/OSMCha/osmcha-frontend/issues Already has been https://github.com/OSMCha/osmcha-frontend/issues/725 https://github.com/OSMCha/osmcha-frontend/issues/719 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5758#issuecomment-2713834125 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] pretty formatting of OSM URLS in notes, changeset comment, and comments (Issue #5780)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5780) > There is a difference with changing how things that are already detected as > links look and the rest. You don't expect "I added a note 5 years ago" to > link to note https://github.com/openstreetmap/openstreetmap-website/pull/5 > but that's what you'll get with those formats. Requiring a minimum number of digits would cover most false positives like that, we don't need it to work on note number 5. > GitHub gets around this problem by requiring a # in front of the number, or > the full URL. Even just detecting and linkifying the URL would be a > significant improvement. Agreed, we could start by only doing note/X, noteX and the full note URL (where X is > 4 characters). Personally I'm not a fan of the shorterned osm.org domain, as pointed out on #5844 people might be be confused if osm.org is the official openstreetmap.org or if it's a different site. I still think we should go further per my proposed here and remove the domain name entirely in the display text, while still allowing the link to work when text is copy pasted. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2763048895 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] After self-deletion of a user, make the username random but still clickable (Issue #4194)
andrewharvey left a comment (openstreetmap/openstreetmap-website#4194) > blocking users from manually setting their username to user_NNN type > usernames, to avoid collisions, > giving the user "name" in the browse pages. We are already publishing the uid > and generated username in the XML and other places. +1 to both of these. Deleted user accounts make life much harder for other mappers trying to work on the map and obscuring the username makes it worse. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4194#issuecomment-2896175498 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] note comments from a deleted user should still be shown (Issue #6056)
andrewharvey created an issue (openstreetmap/openstreetmap-website#6056) ### URL https://www.openstreetmap.org/note/4620093 ### How to reproduce the issue? 1. User A creates a note 2. User B resolves the note and/or adds a comment 3. User A re-opens the note and/or adds a comment 4. User B deletes their account All evidence that User B ever existed and contributed to the note vanishes. This is not great, other users now visiting the note are left with a confusing thread. At the minimum their interactions should be noted in the note. ### Screenshot(s) or anything else? _No response_ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6056 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757) > @andrewharvey How does it look now with edit/comment counters arranged > horizontally? Looks good. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-3025968034 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757) I still feel it's harder than before to spot changesets with comments, it's doable but requires one to look more carefully when scrolling through the list slowly rather than a quick scan. I feel there could be more visual separation between the comment count and edit count which could improve that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-3017341686 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
