[R-pkg-devel] Proper way to cleanup after build third party components?
Hello! I've recently submitted my first package on CRAN and now need to make some improvements on feedback received from CRAN maintainers. https://github.com/thekvs/zstdr https://cran.r-project.org/web/packages/zstdr/index.html My question are: 1. In the process of building package I also need to build some third party components, now I use mktemp utility to create temporary subdirectory in /tmp/ directory where I build this third party part. I was told that according to CRAN packaging policy I should not leave any artifacts in /tmp/ after package build. My question is: Is it enough to delete this temporary directory in the "cleanup" script? 2. Is it possible to install cmake on OSX and Solaris build hosts? -- Konstantin Sorokin [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Proper way to cleanup after build third party components?
This third party component is a compression library for which my package provides bindings and I need to build this library first. Look at the lines starting from https://github.com/thekvs/zstdr/blob/8ea428b33d986667494d940c66732dbbc66871b3/configure.ac#L34 On Mon, Jun 5, 2017 at 12:19 AM, Brian G. Peterson wrote: > > On Sun, 2017-06-04 at 22:56 +0300, Konstantin Sorokin wrote: > > I've recently submitted my first package on CRAN and now need to make > > some improvements on feedback received from CRAN maintainers. > > > > https://github.com/thekvs/zstdr > > https://cran.r-project.org/web/packages/zstdr/index.html > > > > My question are: > > > >1. In the process of building package I also need to build some > >third party components, now I use mktemp utility to create > > temporary subdirectory in /tmp/ directory where I build this third > > party part. I was told that according to CRAN packaging policy I > > should not leave any artifacts in /tmp/ after package build. My > > question is: Is it enough to delete this temporary directory in the > > "cleanup" script? > >2. Is it possible to install cmake on OSX and Solaris build hosts? > > Why not just use .Rbuildignore so that the generated tarball doesn't > have any of the extra files? Or do I misunderstand your question? > -- Konstantin Sorokin [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Proper way to cleanup after build third party components?
On Mon, Jun 5, 2017 at 1:13 AM, Dirk Eddelbuettel wrote: > > On 5 June 2017 at 00:51, Konstantin Sorokin wrote: > | This third party component is a compression library for which my package > | provides bindings and I need to build this library first. Look at the > lines > | starting from > | https://github.com/thekvs/zstdr/blob/8ea428b33d986667494d940c66732d > bbc66871b3/configure.ac#L34 > > The common paradigm is to first build below src/, and to then link via > src/Makevars to the static library you just built. > > I don't have a real go-to example of a package that does this but you could > look into the BioConductor package RGBL (which builds Boost Graph first) > and/or the nloptr package (which, if need be, downloads nlopt and builds > it; > my contribution there was the other part of finding / using a libnlopt if > on > the system). > Thanks, Dirk, I'll look at nloptr package more closely. > > I wondered about this when CRANberries told me about your package. I guess > you can't assume the Zstandard library to be present? Maybe one day the > hybrid approach of nloptr may work for you. > zstandard is a young project and I think it is a bit to early to assume that zstandard library be present in the system. For example on my Ubuntu 16.04 (LTS) I have libzstd0/xenial 0.5.1-1 but the latest stable release has version 1.2. Btw, what about installing cmake on OSX and Solaris in CRAN build farm? Now it is such a ubiquitous and widely used program! -- Konstantin Sorokin [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
[R-pkg-devel] Note about portable file names
Hello! When checking one of my packages I have following message: checking for portable file names ... NOTE Found the following non-portable file paths: tarantoolr/src/third_party/msgpack-1.4.1/include/msgpack/preprocessor/facilities/is_empty_variadic.hpp tarantoolr/src/third_party/msgpack-1.4.1/include/msgpack/preprocessor/iteration/detail/bounds/lower1.hpp Tarballs are only required to store paths of up to 100 bytes and cannot store those of more than 256 bytes, with restrictions including to 100 bytes for the final component. See section ‘Package structure’ in the ‘Writing R Extensions’ manual. My question is: Is it possible to be accepted on CRAN with these sort of messages? To say the truth I have no idea how can I fix them and still have third party components inside source directory. -- Konstantin Sorokin [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Note about portable file names
On Sun, Jun 11, 2017 at 4:15 PM, Dirk Eddelbuettel wrote: > > On 11 June 2017 at 15:18, Konstantin Sorokin wrote: > | Hello! > | > | When checking one of my packages I have following message: > | > | checking for portable file names ... NOTE > | Found the following non-portable file paths: > | tarantoolr/src/third_party/msgpack-1.4.1/include/msgpack/ > preprocessor/facilities/is_empty_variadic.hpp > | tarantoolr/src/third_party/msgpack-1.4.1/include/msgpack/ > preprocessor/iteration/detail/bounds/lower1.hpp > > Do you know about this package > >https://cloud.r-project.org/web/packages/RcppRedis/ > > using the package RcppMsgPack (currently in the off-CRAN repo ghrr-drat) ? > Am I right in my understanding that then I'll be able to link with it and use msgpack (1.4) functions in C++ code without the need to include msgpack sources in my R package? -- Konstantin Sorokin [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
