Re: [R-pkg-devel] Rlang and Code Evalutation Within Aesthetics

2022-04-30 Thread Jeff Newmiller
Things like sensible legends are also impeded by using complex expressions in 
aesthetics mappings, so call it a workaround if you like but creating the data 
frame the way it should be _before_ giving it to ggplot has always been 
recommended.

On April 30, 2022 5:09:51 AM PDT, Duncan Murdoch  
wrote:
>On 30/04/2022 8:00 a.m., Dario Strbenac wrote:
>> Good day,
>> 
>> I am troubled understanding why the following example doesn't work:
>> 
>>> characteristicsList
>> $x
>> `Classifier Name`
>>> ggplot2::aes(fill = if(TRUE) NULL else 
>>> !!rlang::sym(characteristicsList[["fillColour"]]))
>> Error in `rlang::sym()`:
>> ! Can't convert NULL to a symbol.
>>> rlang::last_error()
>> 10. rlang::sym(characteristicsList[["fillColour"]])
>> 
>> but the following does work without error:
>> 
>>> if(TRUE) NULL else !!rlang::sym(characteristicsList[["fillColour"]])
>> NULL # It is desirably avoiding the else part.
>> 
>> The first example seems to be evaluating the else part, even though the if 
>> condition is true.
>> 
>> The overall aim is to allow the end-user to specify a named list of 
>> appearance-modifying parameters, and for the function to create a ggplot 
>> with them, without being bamboozled if the end-user's list doesn't contain 
>> the specification for fill colour variable name or line colour variable name 
>> (like the list in the example above does not have). Thanks in advance for 
>> any suggested reading.
>
>I'm pretty sure this isn't the right place to ask about ggplot2, but that 
>looks like a bug to me.
>
>Duncan Murdoch
>
>__
>R-package-devel@r-project.org mailing list
>https://stat.ethz.ch/mailman/listinfo/r-package-devel

-- 
Sent from my phone. Please excuse my brevity.

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


[R-pkg-devel] Error in r-devel-windows-x86_64 check: package not found.

2022-04-30 Thread Arkajyoti Saha
I recently updated a package in CRAN. Though it passed the
r-devel-linux-x86_64

flavors, I saw an error with r-devel-windows-x86_64
.

The error says "Error : package 'RANN' required by 'BRISC' could not be
found"
The detailed report can be found at
https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/BRISC-00install.html

I was wondering if there is anything to be done on my behalf to circumvent
this problem,
Please let me know if I can provide you with any additional information,

thanks,
Arka

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] Error in r-devel-windows-x86_64 check: package not found.

2022-04-30 Thread Arkajyoti Saha
Thanks so much for the clarification!!

On Sat, Apr 30, 2022 at 8:09 AM Martin Maechler 
wrote:

> > Arkajyoti Saha
> > on Sat, 30 Apr 2022 07:54:22 -0700 writes:
>
> > I recently updated a package in CRAN. Though it passed the
> > r-devel-linux-x86_64
> > <
> https://cran.r-project.org/web/checks/check_flavors.html#r-devel-linux-x86_64-debian-clang
> >
> > flavors, I saw an error with r-devel-windows-x86_64
> > <
> https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/BRISC-00check.html
> >.
>
> > The error says "Error : package 'RANN' required by 'BRISC'
> > could not be found" The detailed report can be found at
> >
> https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/BRISC-00install.html
>
> > I was wondering if there is anything to be done on my
> > behalf to circumvent this problem, Please let me know if I
> > can provide you with any additional information,
>
> > thanks, Arka
>
> Fortunately, this has been a transitional bug in R-devel, and is
> unrelated to the Windows / non-Windows differences:
>
> It's been caused by fixing R bugzilla PR#18331  w/ NEWS entry
>
> * library() now passes its lib.loc argument when requiring Depends
>   packages; reported (with fix) in PR#18331 by Mikael Jagan.
>
> and the orginal change (svn rev 82284) inadvertantly "killed"
> correct working of install.packages()  in some not too
> unfrequent cases.
>
> I've looked for you at
>
> https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/BRISC-00check.txt
> and see that indeed the BRISC installation had happened with
> R-devel svn r88285 which contains this bug.
>
> This newly introduced bug (yesterday) has now been fixed, 28h
> later (with svn r88287).
> It's been my fault  (and fix).
>
> Martin
>

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] Need advice CRAN package check results

2022-04-30 Thread Duncan Murdoch

On 30/04/2022 12:57 p.m., Matthias Gondan wrote:

Dear developers,

I have recently submitted my first r package, and bear with me, I am still 
learning things. Most importantly, there is a page with the CRAN package checks,

https://cran.rstudio.com/web/checks/check_results_rolog.html

The package check for r-release-macos-arm64 fails, in two places.

• The one in the table refers to Version 0.9, that one is less interesting 
because I have already fixed it. Well, minor question, will the version numbers 
for these tests increase automatically?


You manually change the version number of your package, and the version 
number in the check table shows which version was tested.  New 
submissions won't show up there until they are accepted.


Occasionally a new version could be accepted but fail to build on some 
platforms; in that case the version number for that platform won't be 
updated.  I think it's also possible for CRAN maintainers to manually 
skip checks if they want.



• More importantly, there are two links called M1mac below the table, 
„Additional issues“. They refer to the current version of the package, 0.9.2. 
The left link points to https://www.stats.ox.ac.uk/pub/bdr/M1mac/rolog.log, and 
there is an error message at 69% that needs to be fixed somehow. Note that the 
message is not really helpful (clang: error: unable to execute command: Abort 
trap: 6, clang: error: clang frontend command failed due to signal)


That looks like clang crashed.  If you can't duplicate it locally, it 
will be hard to fix.


At the start of your log, there were these messages:

CMake Warning at cmake/port/Darwin.cmake:39 (message):
  Could not find Macport or Homebrew to provide dependencies trying 
to
  configure with default search paths

I would try to test on a system that doesn't have Macport or Homebrew 
installed.



To investigate this in more detail, I tried the mac-builder service, but the 
build doesn’t fail there: 
https://mac.r-project.org/macbuilder/results/1651148567-352c2175cfbba55d/. I 
think this will be deleted soon, so this one is more recent, with only little 
changes: 
https://mac.r-project.org/macbuilder/results/1651332515-22f4e1b1c9492557/

Does anyone have a good idea how to move on? I don’t have a Mac M1 at hand…


I think you'll need to find one to test on.  I'm not sure if Github 
offers that platform for running Github actions, but I imagine there's 
one somewhere or other.


Duncan Murdoch

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel