[Rd] arima.c bug?

2014-04-30 Thread Gabor Bakos
Hello,

   Reading the code I have found that in the line 653 (Pnew[i + r * j] =
tmp;) of http://svn.r-project.org/R/trunk/src/library/stats/src/arima.c
(latest as of now) the multiplier for j is r instead of rd (which is the
dimension of the matrix). Was it intentional? That seems at least worth
a comment why it is the case instead of Pnew[i + rd * j] = tmp;
Thanks and Kind Regards, gabor

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] arima.c bug?

2014-04-30 Thread Gabor Bakos
On 2014. April 30. 15:13:05, Gabor Bakos wrote:
> Hello,
>
>Reading the code I have found that in the line 653 (Pnew[i + r * j] =
> tmp;) of http://svn.r-project.org/R/trunk/src/library/stats/src/arima.c
> (latest as of now) the multiplier for j is r instead of rd (which is the
> dimension of the matrix). Was it intentional? That seems at least worth
> a comment why it is the case instead of Pnew[i + rd * j] = tmp;
> Thanks and Kind Regards, gabor
Sorry, I missed the if (d == 0) condition for that block. In that case 
rd == d, so this do not cause bugs, just a bit confusion for a short 
time. :)
Thanks, gabor


__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel