Re: [Rd] trivial typo in src/library/base/man/LongVectors.Rd
> Ben Bolker > on Wed, 12 Dec 2018 14:45:10 -0500 writes: > Line 23: > "In theory up they can to" > should be > "In theory they can be up to" > or (slightly more formally) > "In theory they can contain up to" > cheers > Ben Bolker Thank you, Ben! (I've chosen the more formal one) Martin __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
[Rd] Documentation examples for lm and glm
Hello, something that has been on my mind for a decade or two has been the examples for lm() and glm(). They encourage poor style because of mismanagement of data frames. Also, having the variables in a data frame means that predict() is more likely to work properly. For lm(), the variables should be put into a data frame. As 2 vectors are assigned first in the general workspace they should be deleted afterwards. For the glm(), the data frame d.AD is constructed but not used. Also, its 3 components were assigned first in the general workspace, so they float around dangerously afterwards like in the lm() example. Rather than attached improved .Rd files here, they are put at www.stat.auckland.ac.nz/~yee/Rdfiles You are welcome to use them! Best, Thomas __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
Re: [Rd] Documentation examples for lm and glm
Agree. Or just create the data frame with those variables in it directly ... On 2018-12-13 3:26 p.m., Thomas Yee wrote: > Hello, > > something that has been on my mind for a decade or two has > been the examples for lm() and glm(). They encourage poor style > because of mismanagement of data frames. Also, having the > variables in a data frame means that predict() > is more likely to work properly. > > For lm(), the variables should be put into a data frame. > As 2 vectors are assigned first in the general workspace they > should be deleted afterwards. > > For the glm(), the data frame d.AD is constructed but not used. Also, > its 3 components were assigned first in the general workspace, so they > float around dangerously afterwards like in the lm() example. > > Rather than attached improved .Rd files here, they are put at > www.stat.auckland.ac.nz/~yee/Rdfiles > You are welcome to use them! > > Best, > > Thomas > > __ > R-devel@r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-devel __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel