Re: [Rd] Patch for R-exts.texi

2017-07-08 Thread Martin Maechler
> Scott Kostyshak 
> on Mon, 3 Jul 2017 02:09:47 -0400 writes:

> Attached is a patch for R-exts.texi against r72880.  Here
> are some of the changes I made:

> - Fix a broken link:
> 
https://developer.apple.com/library/mac/#documentation/DeveloperTools/Conceptual/InstrumentsUserGuide/Introduction/Introduction.html
-> 
> 
https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/InstrumentsUserGuide/index.html

> - Changed a few http to https (and checked that the
> connections are indeed secure, as judged by Chromium and
> Firefox).

> - A couple of grammar fixes and "sounds more natural to
> me" changes.

> - "x84_64" -> x86_64

> - One change of "which" -> "that"

> - The link to Luke's uiowa.edu page involves two changes,
> removing the duplicate URL and changing the protocol to
> https.

> Thanks for your time,
> Scott

> -- 
> Scott Kostyshak Assistant Professor of Economics
> University of Florida
> https://people.clas.ufl.edu/skostyshak/

> [DELETED ATTACHMENT external: R-exts.texi.diff, plain
> text]

Thank you very much, Scott!

This is a clear improvement
 ((even though some of the style changes may be debatable - but only by native
   English/American (;-) speakers, not me. ...))

Hence I've committed it (R-devel, svn rev 72900).

Martin Maechler

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] Patch for R-exts.texi

2017-07-08 Thread Scott Kostyshak
On Sat, Jul 08, 2017 at 06:18:25PM +0200, Martin Maechler wrote:
> > Scott Kostyshak 
> > on Mon, 3 Jul 2017 02:09:47 -0400 writes:
> 
> > Attached is a patch for R-exts.texi against r72880.  Here
> > are some of the changes I made:
> 
> > - Fix a broken link:
> > 
> https://developer.apple.com/library/mac/#documentation/DeveloperTools/Conceptual/InstrumentsUserGuide/Introduction/Introduction.html
> -> 
> > 
> https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/InstrumentsUserGuide/index.html
> 
> > - Changed a few http to https (and checked that the
> > connections are indeed secure, as judged by Chromium and
> > Firefox).
> 
> > - A couple of grammar fixes and "sounds more natural to
> > me" changes.
> 
> > - "x84_64" -> x86_64
> 
> > - One change of "which" -> "that"
> 
> > - The link to Luke's uiowa.edu page involves two changes,
> > removing the duplicate URL and changing the protocol to
> > https.
> 
> > Thanks for your time,
> > Scott
> 
> > -- 
> > Scott Kostyshak Assistant Professor of Economics
> > University of Florida
> > https://people.clas.ufl.edu/skostyshak/
> 
> > [DELETED ATTACHMENT external: R-exts.texi.diff, plain
> > text]
> 
> Thank you very much, Scott!
> 
> This is a clear improvement
>  ((even though some of the style changes may be debatable - but only by native
>English/American (;-) speakers, not me. ...))
> 
> Hence I've committed it (R-devel, svn rev 72900).

Thanks for putting it in, Martin! I do my best to not impose American
English, but sometimes I just don't realize. I actually have adopted
several non-American rules because I find them more logical. For
example, I like to put punctuation outside of quotes, such as "this is a
quote", where for some reason in American English it is preferred to put
it as "this is a quote."

Thanks for taking the time to review the patch and commit it.

Scott


-- 
Scott Kostyshak
Assistant Professor of Economics
University of Florida
https://people.clas.ufl.edu/skostyshak/

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] attributes on symbols

2017-07-08 Thread Radford Neal
Attributes on symbols seem like a bad idea to me.  An additional
obscure part of the global state seems undesirable.  I can't see how
any use of them would be preferrable to storing an environment in some
global variable, in which the same information could be recorded.

Note that the attributes on symbols are not saved when the workspace
is saved with q("yes").

   Radford Neal

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] bug: deparse sometimes omits parentheses for unary operators

2017-07-08 Thread Radford Neal
> From: "Binder, Martin" 
> To: r-devel@r-project.org
> Subject: [Rd] bug: deparse sometimes omits parentheses for unary
>   operators
>
> Example (bad):
> > (expr = substitute(-a * 10, list(a = quote(if (TRUE) 1 else 0
> -if (TRUE) 1 else 0 * 10
>
> The parentheses around the "if"-construct are missing. The expected
> output (the true representation of the expression) is, in fact:
>
> -(if (TRUE) 1 else 0) * 10


It would also be OK for the result to be

  (-if (TRUE) 1 else 0) * 10

It's possible that producing this form is more natural for the deparser.

There are a number of other bugs in the deparser, many of which I
fixed in the pqR deparser when doing a major rewrite, though I missed
the one you report above.  You can see them at

http://www.pqr-project.org/NEWS.txt

Look for BUG FIXES under VERSION RELEASED 2015-09-14.  Some are fixed
in R-3.4.0, but most remain.

   Radford Neal

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel