[Python-Dev] test_bind_port and test_find_unused_port fail due to missing SO_REUSEPORT when building Python 3.3.2-r2 (from portage) on 3.7.10-gentoo-r1 kernel

2013-12-03 Thread Reuben Garrett
Greetings, learned Python devs!

Apologies in advance if my message is misdirected. I'm building Python
3.3.2-r2 from Gentoo's Portage tree [1] and encountered two failed tests
which probably should not have been attempted on my OS (Gentoo 3.7.10):
test_bind_port and test_find_unused_port both use the SO_REUSEPORT socket
option which, to the best of my knowledge is only available since kernel
version 3.9. I was able to build by skipping the tests — but I believe the
tests are there for a reason, and it would be best if a test that is known
to fail should be skipped (or replaced with a fallback that is likely to
succeed). Issue # 16594 [3] may be related (not sure).

Is it possible to detect the kernel version and skip (or modify) these
tests if SO_REUSEPORT is not available? If I'm missing something obvious
(or should be reporting this elsewhere), please educate me so I can better
respect your attention next time around :]


+=== excerpt of portage build log:
==
ERROR: test_bind_port (test.test_support.TestSupport)
--
Traceback (most recent call last):
  File
"/var/tmp/portage/dev-lang/python-3.3.2-r2/work/Python-3.3.2/Lib/test/test_support.py",
line 87, in test_bind_port
support.bind_port(s)
  File
"/var/tmp/portage/dev-lang/python-3.3.2-r2/work/Python-3.3.2/Lib/test/support.py",
line 548, in bind_port
if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1:
OSError: [Errno 92] Protocol not available

==
ERROR: test_find_unused_port (test.test_support.TestSupport)
--
Traceback (most recent call last):
  File
"/var/tmp/portage/dev-lang/python-3.3.2-r2/work/Python-3.3.2/Lib/test/test_support.py",
line 80, in test_find_unused_port
port = support.find_unused_port()
  File
"/var/tmp/portage/dev-lang/python-3.3.2-r2/work/Python-3.3.2/Lib/test/support.py",
line 522, in find_unused_port
port = bind_port(tempsock)
  File
"/var/tmp/portage/dev-lang/python-3.3.2-r2/work/Python-3.3.2/Lib/test/support.py",
line 548, in bind_port
if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1:
OSError: [Errno 92] Protocol not available
===+

[1]: https://packages.gentoo.org/package/dev-lang/python
[2]: https://lwn.net/Articles/542629/
[3]: http://bugs.python.org/issue16594

-- 
Best regards,
Reuben Garrett
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] test_bind_port and test_find_unused_port fail due to missing SO_REUSEPORT when building Python 3.3.2-r2 (from portage) on 3.7.10-gentoo-r1 kernel

2013-12-05 Thread Reuben Garrett
On Tue, Dec 3, 2013 at 9:44 AM, Guido van Rossum  wrote:
> Thanks for reporting this.

With pleasure! I'm just glad to have reported a valid bug for once in my
life :b

> This really belongs in the Python issue tracker (bugs.python.org) -- can
you submit a bug there?

I've opened issue # 19901 [1] as requested.

> My hunch is that, because this seems to be a relatively new feature, we
should just catch and ignore the exception from that specific call.

I agree, although I sort of phrased it poorly in the bug.

Thank you again for your support (and sorry for the delayed response).
Python is cool :]

[1]: http://bugs.python.org/issue19901
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com