[Python-Dev] Pull Request bpo-1812
Can someone please review the subject pull request? Pull request link here: https://github.com/python/cpython/pull/17385 Issue tracker link here: https://bugs.python.org/issue1812 Thank you very much! Peter Donis pdo...@peterdonis.net ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/32BFCXWK3SNCTFRGBHQEZW4RQKM2B4MQ/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Pull Request bpo-1812
Is there any update on this? I have put the setup/teardown code in a context manager as Zach recommended. The setup/teardown code covers everything that could possibly be mutated by the test. It's probably not the most elegant way to do it, but all of the tests pass which indicates that it works. Github shows all checks passed and no conflicts with the base branch. I'm not sure what more would be needed at this point to make this ready to merge. ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/WMFLMU5PP2TKEOP7ULB3CAP22SVM4FYK/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Pull Request bpo-1812
Ok, thanks for the update! ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/3BFH43ZXA5E3QJJIO2S2LNCEKBKPC2TJ/ Code of Conduct: http://python.org/psf/codeofconduct/
