Re: [Python-Dev] We should be using a tool for code reviews

[Andi Albrecht]

Georg Brandl  writes:

> Am 30.09.2010 10:22, schrieb Dirkjan Ochtman:
>> On Wed, Sep 29, 2010 at 20:32, Guido van Rossum  wrote:
>>> I would like to recommend that the Python core developers start using
>>> a code review tool such as Rietveld or Reviewboard. I don't really
>>> care which tool we use (I'm sure there are plenty of pros and cons to
>>> each) but I do think we should get out of the stone age and start
>>> using a tool for the majority of our code reviews.
>> 
>> Rambling thoughts about some of the things mentioned in this thread.
>> 
>> I think hg-review looks interesting, though it may not (yet) have the
>> level of sophistication of Rietveld. (Public test instance at
>> http://review.stevelosh.com/.)
>> 
>> It might be interesting to integrate Rietveld uploads in a Mercurial
>> extension, particularly if it gets integrated with mq somehow.
>
> That would be totally awesome!

The Go (the language) project has a Mercurial extension that integrates
Rietveld. It seems to provide a few commands for both directions:
uploading changelists to a review server and for the reviewer
downloading from the server and applying the changelists to a working
copy. I never used this extension myself so I can't tell anything about
the workflow introduced by these commands.

The sources for this extension are here:
http://code.google.com/p/go/source/browse/lib/codereview/codereview.py

Andi

>
> Georg
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Rietveld or Review Board use?

[Andi Albrecht]

On Fri, Mar 4, 2011 at 5:52 PM, Barry Warsaw  wrote:
> On Mar 04, 2011, at 05:19 PM, Victor Stinner wrote:
>
>>Le vendredi 04 mars 2011 à 10:05 -0600, s...@pobox.com a écrit :
>>> Is Rietveld or Review Board being used within the Python core development
>>> community?  I looked at the dev guide but didn't see anything obvious about
>>> code reviews.  I don't see how to search the Rietveld instance at
>>> codereview.appspot.com looking just for Python core review requests.
>>>
>>> My aim here is to provide some examples to a colleague at work.  I wanted to
>>> give him some examples related to code with which I'm familiar.
>>
>>I used it at least twice.
>>
>>Issue #9425: http://codereview.appspot.com/1874048
>>Issue #3080: http://codereview.appspot.com/3972045
>
> Yep, I used Rietveld for the PEP 3147/3149 patches and it was pretty nice.
> It's not completely well integrated into our workflow, but it's cool enough
> that I think we should promote it more.  Will that be easier once we're
> permanently on Mercurial?

FWIW there's a nice section in the contribution guidelines for the Go
language about code reviews and how they integrate Rietveld into their
development process: http://golang.org/doc/contribute.html#Code_review
They're using a wrapper around the upload.py script bundled as a
Mercurial extension.

And IIRC there's already some Roundup integration done.

-Andi

>
> -Barry
>
> ___
> Python-Dev mailing list
> Python-Dev@python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: 
> http://mail.python.org/mailman/options/python-dev/albrecht.andi%40googlemail.com
>
>
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com