[Python-Dev] Patch review: [ 1100942 ] datetime.strptime constructor added
I see a need for this patch - I've had to write "datetime(*(time.strptime(date_string, format)[0:6]))" far too many times. I don't understand the C API well enough to check if reference counts are handled properly, but otherwise the implementation looks straight forward. Documentation looks good and the test passes on my machine. Two suggestions: 1. In the time module, the strptime() function's format parameter is optional. For consistency's sake, I'd expect datetime.strptime()'s format parameter also to be optional. (On the other hand, the default value for the format is not very useful.) 2. Since strftime is supported by datetime.time, datetime.date and datetime.datetime, I'd also expect strptime to be supported by all three classes. Could you add that now, or would it be better to do it as a separate patch? Alan. -- Alan Green [EMAIL PROTECTED] - http://cardboard.nu ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Patch review: [ 1094542 ] add Bunch type to collections module
Steven Bethard is proposing a new collection class named Bunch. I had a few suggestions which I attached as comments to the patch - but what is really required is a bit more work on the draft PEP, and then discussion on the python-dev mailing list. http://sourceforge.net/tracker/?func=detail&aid=1100942&group_id=5470&atid=305470 Alan. -- Alan Green [EMAIL PROTECTED] - http://cardboard.nu ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Patch review: [ 1009811 ] Add missing types to __builtin__
Last August, James Knight posted to python-dev, "There's a fair number of classes that claim they are defined in __builtin__, but do not actually appear there". There was a discussion and James submitted this patch: http://sourceforge.net/tracker/index.php?func=detail&aid=1009811&group_id=5470&atid=305470 The final result of the discussion is unclear. Guido declared himself +0.5 on the concept, but nobody has reviewed the patch in detail yet. The original email thread starts here: http://mail.python.org/pipermail/python-dev/2004-August/047477.html The patch still applies, and test cases still run OK afterwards. Now that 2.4 has been released it is perhaps a good time to discuss in on python-dev again. If it isn't discussed, then the patch should be closed due to lack of interest. Alan. -- Alan Green [EMAIL PROTECTED] - http://cardboard.nu ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
