[Python-Dev] Re: Do we still need a support of non-type objects in issubclass()?

[Serhiy Storchaka]

04.10.20 01:06, Guido van Rossum пише:
> On Sat, Oct 3, 2020 at 9:28 AM Serhiy Storchaka  > wrote:
> The code of object.__dir__() is very old, it predates new-style classes,
> and currently it gathers names using different algorithm than used in
> object.__getattr__(), so object.__dir__() does not always return a list
> of names accepted by object.__getattr__().
> Would anything break if we changed `dir()` to use `__mro__` instead of
> `__bases__`? It would probably be simpler.

It is what I planned to play with. Also we can consider using
_PyObject_GetDictPtr() instead of resolving the __dict__ attribute and
Py_TYPE() instead of resolving the __class__ attribute.

> > I think all that hackery may predate (and may even have been an
> > inspiration for features of) new-style classes.
> I wonder whether it should pass with Python 2.
> I suppose you meant "pass" as in "die". I agree.

Do we need a deprecation period?
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/PGK7OYU2XAFUTDIYPLG6O5PJGRU5J2D6/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Do we still need a support of non-type objects in issubclass()?

[Brett Cannon]

On Sun, Oct 4, 2020 at 1:24 AM Serhiy Storchaka  wrote:

> 04.10.20 01:06, Guido van Rossum пише:
> > On Sat, Oct 3, 2020 at 9:28 AM Serhiy Storchaka  > > wrote:
> > The code of object.__dir__() is very old, it predates new-style
> classes,
> > and currently it gathers names using different algorithm than used in
> > object.__getattr__(), so object.__dir__() does not always return a
> list
> > of names accepted by object.__getattr__().
> > Would anything break if we changed `dir()` to use `__mro__` instead of
> > `__bases__`? It would probably be simpler.
>
> It is what I planned to play with. Also we can consider using
> _PyObject_GetDictPtr() instead of resolving the __dict__ attribute and
> Py_TYPE() instead of resolving the __class__ attribute.
>
> > > I think all that hackery may predate (and may even have been an
> > > inspiration for features of) new-style classes.
> > I wonder whether it should pass with Python 2.
> > I suppose you meant "pass" as in "die". I agree.
>
> Do we need a deprecation period?
>

If the code can be written such that a DeprecationWarning can be raised if
the __bases__ path is taken then yes unless you ask the SC to skip it and
they agree to it:
https://www.python.org/dev/peps/pep-0387/#basic-policy-for-backwards-compatibility.
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/Y4TFXMXMCWL763FIJX73QO6AKELJZHTT/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] PR checks hang because travis does not report back to github

[Stefan Behnel]

Hi devs,

I have a trivial documentation PR

https://github.com/python/cpython/pull/22464

for which travis (unsurprisingly) had a successful run,

https://travis-ci.com/github/python/cpython/builds/187435578

but github lists the travis build as "created" instead of "passed".

https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760

I already tried closing the PR and reopening it, and also triggering the
build again on travis side, but github still fails to pick up the build status.

I tried creating a new PR, but it seems that github (or travis) deduplicate
the build requests and still refer to the original build, so that there is
still no response from travis.

I also cannot find a way to terminate the checks process in github, or
otherwise make it stop waiting for Godot.

Is this a known issue? Is there anything I can do about it?

Thanks,
Stefan
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/4TNKVOJ2LUJZZHHIBNORZ7GIVMYMNDER/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: PR checks hang because travis does not report back to github

[Mariatta]

This is a known issue and I have brought it up in GitHub OS Maintainers
Feedback Group. It happens to other projects as well.

Currently we have branch protection rule where even administrators couldnt
merge the PR unless all the required checks passed.

Perhaps we can relax the rule to allow administrators to merge the stuck
PRs. At least temporarily until Travis/GitHub fixes it. Does this sound
okay?


On Sun, Oct 4, 2020, 10:44 AM Stefan Behnel  wrote:

> Hi devs,
>
> I have a trivial documentation PR
>
> https://github.com/python/cpython/pull/22464
>
> for which travis (unsurprisingly) had a successful run,
>
> https://travis-ci.com/github/python/cpython/builds/187435578
>
> but github lists the travis build as "created" instead of "passed".
>
> https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760
>
> I already tried closing the PR and reopening it, and also triggering the
> build again on travis side, but github still fails to pick up the build
> status.
>
> I tried creating a new PR, but it seems that github (or travis) deduplicate
> the build requests and still refer to the original build, so that there is
> still no response from travis.
>
> I also cannot find a way to terminate the checks process in github, or
> otherwise make it stop waiting for Godot.
>
> Is this a known issue? Is there anything I can do about it?
>
> Thanks,
> Stefan
> ___
> Python-Dev mailing list -- python-dev@python.org
> To unsubscribe send an email to python-dev-le...@python.org
> https://mail.python.org/mailman3/lists/python-dev.python.org/
> Message archived at
> https://mail.python.org/archives/list/python-dev@python.org/message/4TNKVOJ2LUJZZHHIBNORZ7GIVMYMNDER/
> Code of Conduct: http://python.org/psf/codeofconduct/
>
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/2VVPKIGJ744UFYH5RNJLK3RAGGWCHYOA/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: PR checks hang because travis does not report back to github

[Terry Reedy]

On 10/4/2020 2:32 PM, Mariatta wrote:
This is a known issue and I have brought it up in GitHub OS Maintainers 
Feedback Group. It happens to other projects as well.


Currently we have branch protection rule where even administrators 
couldnt merge the PR unless all the required checks passed.


Perhaps we can relax the rule to allow administrators to merge the stuck 
PRs. At least temporarily until Travis/GitHub fixes it. Does this sound 
okay?


If we are told how to ping the admins, it would be better than being 
stuck.



On Sun, Oct 4, 2020, 10:44 AM Stefan Behnel > wrote:


Hi devs,

I have a trivial documentation PR

https://github.com/python/cpython/pull/22464

for which travis (unsurprisingly) had a successful run,

https://travis-ci.com/github/python/cpython/builds/187435578


Since the details were still available, I verified 'success'.  This is 
much better that previous stuck situations in which the details line 
disappeared.



but github lists the travis build as "created" instead of "passed".

https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760

I already tried closing the PR and reopening it, and also triggering the
build again on travis side, but github still fails to pick up the
build status.

I tried creating a new PR, but it seems that github (or travis)
deduplicate
the build requests and still refer to the original build, so that
there is
still no response from travis.

I also cannot find a way to terminate the checks process in github, or
otherwise make it stop waiting for Godot.

Is this a known issue? Is there anything I can do about it?


--
Terry Jan Reedy
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/IQKOZ62XLWX5Q2YS5B65RFNLQKAKFA4L/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: PR checks hang because travis does not report back to github

[Simon Cross]

On Sun, Oct 4, 2020 at 8:34 PM Mariatta  wrote:
> Perhaps we can relax the rule to allow administrators to merge the stuck PRs. 
> At least
> temporarily until Travis/GitHub fixes it. Does this sound okay?

+1 on relaxing the rule permanently. We should not give robots more
rights than humans.

People before Processes is the very first principle in the Agile
Manifesto (and with good reason).
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/WNGCNNETLTYD5TT2DCZZSWDHQ5PTB22C/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: PR checks hang because travis does not report back to github

[Ned Deily]

On Oct 4, 2020, at 15:55, Terry Reedy  wrote:
> 
> On 10/4/2020 2:32 PM, Mariatta wrote:
>> This is a known issue and I have brought it up in GitHub OS Maintainers 
>> Feedback Group. It happens to other projects as well.
>> Currently we have branch protection rule where even administrators couldnt 
>> merge the PR unless all the required checks passed.
>> Perhaps we can relax the rule to allow administrators to merge the stuck 
>> PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay?
> 
> If we are told how to ping the admins, it would be better than being stuck.

If you run into a problem like this with a stuck PR, contact the release 
manager for the branch directly via email. Release managers can override the 
restrictions and we don't always read every list immediately.

Because this was a trivial change and because of time zones, I've taken the 
liberty of acting in Pablo's behalf: it's now merged. 


--
  Ned Deily
  n...@python.org -- []
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/XQYAE2ZQVTAK7PIER6HXSZXEAFW2TJ3K/
Code of Conduct: http://python.org/psf/codeofconduct/