Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
On May 23, 2018, at 09:13, Ned Deily wrote: > On May 23, 2018, at 07:45, Serhiy Storchaka wrote: >> Is it possible to add yet one beta instead? >> CI was broken for few latest days, tests are not passed on my computer still >> (and fail on some buildbots), updating What's New exposed new features which >> need additional testing (and maybe fixing or reverting), and I'm not >> comfortable about some changes which would be harder to fix after the >> release. > it is possible but there's no point in doing either another beta or a release > candidate until we understand and address the current blocking issues, like > the major buildbot failures. We have another 24 hours until rc1 was planned > to be tagged. Let's keep working on the known issues and we will make a > decision then. An update: thanks to a lot of effort over the past day by a number of people (including Victor, Serhiy, Christian, Zach, and others I'm sure I'm forgetting - my apologies), we have addressed all of the "release blocker" issues and all but one of the persistent failures on the 3.7 stable buildbots. We should have the couple of remaining "deferred blockers" including the remaining stable buildbots in green status by later today. At that point, we will be ready to tag 3.7.0rc1 and begin producing the release candidate artifacts. So this *is* really your last chance: if you know of any true releasing blocking issues for 3.7.0, you have about 12 more hours to log it in the bug tracker as a "release blocker". I'll send out an email once we start the release manufacturing. Any merges to the 3.7 branch after that will be released in 3.7.1 which we tentatively are planning to ship sometime before the end of July (< 2018-07-31). If you do find a critical problem in 3.7.0rc1 that you think needs to be fixed in 3.7.0, please merge a fix into 3.7 (and other appropriate branches), leave the issue open and marked as "release blocker", and add a note why you think the fix needs to be cherry-picked into 3.7.0. More later today! --Ned P.S. To address a few of the earlier comments on this thread: Antoine: > Also there's https://bugs.python.org/issue33612 which appears quite critical. Resolved Victor: > Can someone please have a look at my socketserver change? Reviewed and merged Victor: > I looked at buildbots and I confirm that many of the 3.x buildbots are red: Yes, but it's the 3.7 buildbots that are of interest now, not the 3.x ones :) And, as noted above, I believe we have cleaned up (or will shortly) the remaining 3.7 stable buildbot failures. Coincidentally, we've also fixed some of the 3.x (master -> 3.8) buildbots. Victor: > Ah, Python doesn't compile on Windows anymore :-) Stale files on one of the Windows buildbots -> cleaned up -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
2018-05-24 9:23 GMT+02:00 Ned Deily : > Any merges to the 3.7 branch after > that will be released in 3.7.1 which we tentatively are planning to > ship sometime before the end of July (< 2018-07-31). I recall that Python 3.6.0 was full of bugs, some functions like os.waitpid() on Windows (if I recall correctly) were completely broken. We can do our best to test as much as possible, hope that more and more people use the "nightly" Python version to run their CI, but we always miss bugs. We always get the most testers when the final x.y.0 version is released. Why waiting two months to release bugfixes? Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
On May 24, 2018, at 07:26, Victor Stinner wrote: > 2018-05-24 9:23 GMT+02:00 Ned Deily : >> Any merges to the 3.7 branch after >> that will be released in 3.7.1 which we tentatively are planning to >> ship sometime before the end of July (< 2018-07-31). > I recall that Python 3.6.0 was full of bugs, some functions like > os.waitpid() on Windows (if I recall correctly) were completely > broken. > > We can do our best to test as much as possible, hope that more and > more people use the "nightly" Python version to run their CI, but we > always miss bugs. We always get the most testers when the final x.y.0 > version is released. > > Why waiting two months to release bugfixes? We're not planning on waiting two months. First, 3.7.0 final is not planned to release until 2018-06-15; if necessary, there could be one or more emergency bug fixes in it. Second, "before the end of July (< 2018-07-31)" does not mean we have to wait until the end of July. If necessary, it could be near the beginning of the month, so closer to two weeks after the release. Right now, our focus should be on getting high-quality 3.7.0rc1 and 3.7.0 final releases out there to our users and then we can focus on what comes next. Getting close! -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
24.05.18 10:23, Ned Deily пише: So this *is* really your last chance: if you know of any true releasing blocking issues for 3.7.0, you have about 12 more hours to log it in the bug tracker as a "release blocker". I'll send out an email once we start the release manufacturing. Any merges to the 3.7 branch after that will be released in 3.7.1 which we tentatively are planning to ship sometime before the end of July (< 2018-07-31). If you do find a critical problem in 3.7.0rc1 that you think needs to be fixed in 3.7.0, please merge a fix into 3.7 (and other appropriate branches), leave the issue open and marked as "release blocker", and add a note why you think the fix needs to be cherry-picked into 3.7.0. I have doubts about two issues. I feel the responsibility for them because I had the opportunity to solve them before, but I lost it. 1. Changes in the AST. Few third-party projects was broken by it and already are fixed. I suppose yet few projects will be changed after 3.7 be released. It is interesting that IPython was broken in different way than other projects. It was needed to reintroduce the docstring in the list of statements, effectively reverting the 3.7 change. IPython allows to enter several statements at prompt, and therefore it compiles them with the 'exec' mode instead of 'single' as the CPython REPL and IDLE shell. Currently CPython doesn't allow you to paste arbitrary script like the following: if a: b if c: d You need to add an empty line between top-level complex statements. If one time CPython will add support of pasting several statements without empty lines between, it might need to add the same hack as IPython. I afraid that we might be needed to change AST again, in 3.7.1 or in 3.8.0. 2. Pickle support in typing is not perfect. I was going to fix it (I had almost ready code), but lost a chance of doing this before. It can be changed in 3.7.1, but this means that pickles of some derived typing types created in 3.7.0 will be not compatible with future versions (may be 3.7.1 will not break compatibility, but it will be broken in future because we will not specially supported compatibility with 3.7.0). There is third issue, related to NetBSD, but it is less important. I think two weeks will be enough for fixing these issues, but not at rc1 stage. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
On May 24, 2018, at 11:35, Serhiy Storchaka wrote: > I have doubts about two issues. I feel the responsibility for them because I > had the opportunity to solve them before, but I lost it. [...] Serhiy, what are the bugs.python.org issue numbers for these? Are they marked as "release blocker"? -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
> 2. Pickle support in typing is not perfect. I was going to fix it (I had almost ready code), but lost a chance of doing this before. It can be changed in 3.7.1, but this means that pickles of some derived typing types created in 3.7.0 will be not compatible with future versions (may be 3.7.1 will not break compatibility, but it will be broken in future because we will not specially supported compatibility with 3.7.0). I think I had fixed this one. At least the examples reported on typing tracker are now fixed. Do you have some other examples that still fail? -- Ivan On 24 May 2018 at 12:02, Ned Deily wrote: > On May 24, 2018, at 11:35, Serhiy Storchaka wrote: > > I have doubts about two issues. I feel the responsibility for them > because I had the opportunity to solve them before, but I lost it. > [...] > > Serhiy, what are the bugs.python.org issue numbers for these? Are they > marked as "release blocker"? > > -- > Ned Deily > n...@python.org -- [] > > ___ > python-committers mailing list > python-committ...@python.org > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
24.05.18 19:02, Ned Deily пише: On May 24, 2018, at 11:35, Serhiy Storchaka wrote: I have doubts about two issues. I feel the responsibility for them because I had the opportunity to solve them before, but I lost it. [...] Serhiy, what are the bugs.python.org issue numbers for these? Are they marked as "release blocker"? For docstring in AST: https://bugs.python.org/issue32911 Inada's patch looked complex (actually it mostly restored the code before his previous change). We didn't know about IPython and we decided that it is not worth to change this code at this stage (after beta2). And definitely it will be later to do this after rc1. For pickling of typing types: https://bugs.python.org/issue32873 Ivan fixed cases supported before 3.7. They now are backward and forward compatible. But cases not supported before 3.7 (like List[int]) now produce fragile pickles. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
> But cases not supported before 3.7 (like List[int]) now produce fragile pickles. List[int] pickled in 3.7 can't be un-pickled in 3.6, but I wouldn't worry too much about this because it never worked in 3.6. I remember you proposed using __getitem__ in __reduce__, but I am not sure it is a better way, although it will fix the above problem. I don't think this one is a blocker and we can move this discussion back to b.p.o., unless you have some particular concerns. The AST one however looks more serious. -- Ivan On 24 May 2018 at 12:26, Serhiy Storchaka wrote: > 24.05.18 19:02, Ned Deily пише: > >> On May 24, 2018, at 11:35, Serhiy Storchaka wrote: >> >>> I have doubts about two issues. I feel the responsibility for them >>> because I had the opportunity to solve them before, but I lost it. >>> >> [...] >> >> Serhiy, what are the bugs.python.org issue numbers for these? Are they >> marked as "release blocker"? >> > > For docstring in AST: https://bugs.python.org/issue32911 > > Inada's patch looked complex (actually it mostly restored the code before > his previous change). We didn't know about IPython and we decided that it > is not worth to change this code at this stage (after beta2). And > definitely it will be later to do this after rc1. > > For pickling of typing types: https://bugs.python.org/issue32873 > > Ivan fixed cases supported before 3.7. They now are backward and forward > compatible. But cases not supported before 3.7 (like List[int]) now produce > fragile pickles. > > > ___ > python-committers mailing list > python-committ...@python.org > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
On May 24, 2018, at 12:26, Serhiy Storchaka wrote: > 24.05.18 19:02, Ned Deily пише: >> On May 24, 2018, at 11:35, Serhiy Storchaka wrote: >>> I have doubts about two issues. I feel the responsibility for them because >>> I had the opportunity to solve them before, but I lost it. >> [...] >> >> Serhiy, what are the bugs.python.org issue numbers for these? Are they >> marked as "release blocker"? > For docstring in AST: https://bugs.python.org/issue32911 > > Inada's patch looked complex (actually it mostly restored the code before his > previous change). We didn't know about IPython and we decided that it is not > worth to change this code at this stage (after beta2). And definitely it will > be later to do this after rc1. We have had many discussions about this issue earlier and, while there were arguments made for more than one approach, I believe we reached agreement that this was a deliberate incompatibility that we and our users could live with. The issue has been closed since 2018-03-18. At some point, we need to move on. However, if additional exposure downstream has identified significant new problems, then the issue should be re-opened and a specific proposal made. BTW, do we know what the iPython folks think about this? But there still seems to be disagreements about whether anything needs to be changed. As I commented yesterday, I *really* don't want to keep revisiting this but I am not going to make a technical call. Without an open "release blocker" issue, though, nothing is going to change for 3.7.0rc1. If you (or anyone else) feels strongly enough about it, you should re-open the issue now and make it as a "release blocker" and we should discuss the implications and possible plans of action in the issue. > For pickling of typing types: https://bugs.python.org/issue32873 > > Ivan fixed cases supported before 3.7. They now are backward and forward > compatible. But cases not supported before 3.7 (like List[int]) now produce > fragile pickles. That issue was closed by Ivan and there have been no comments on it since 2018-04-04. I'll defer to his recent reply in this thread. -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] PEP 574 (pickle 5) implementation and backport available
Hi, While PEP 574 (pickle protocol 5 with out-of-band data) is still in draft status, I've made available an implementation in branch "pickle5" in my GitHub fork of CPython: https://github.com/pitrou/cpython/tree/pickle5 Also I've published an experimental backport on PyPI, for Python 3.6 and 3.7. This should help people play with the new API and features without having to compile Python: https://pypi.org/project/pickle5/ Any feedback is welcome. Regards Antoine. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] PEP 574 (pickle 5) implementation and backport available
Link to the PEP: "PEP 574 -- Pickle protocol 5 with out-of-band data" https://www.python.org/dev/peps/pep-0574/ Victor 2018-05-24 19:57 GMT+02:00 Antoine Pitrou : > > Hi, > > While PEP 574 (pickle protocol 5 with out-of-band data) is still in > draft status, I've made available an implementation in branch "pickle5" > in my GitHub fork of CPython: > https://github.com/pitrou/cpython/tree/pickle5 > > Also I've published an experimental backport on PyPI, for Python 3.6 > and 3.7. This should help people play with the new API and features > without having to compile Python: > https://pypi.org/project/pickle5/ > > Any feedback is welcome. > > Regards > > Antoine. > > > ___ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/vstinner%40redhat.com ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] The history of PyXML
On Thu, 2018-05-17 at 15:18 +0300, Serhiy Storchaka wrote: > Does anyone has the full copy of the PyXML repository, with the > complete history? > > This library was included in Python 2.1 as the xml package and is > not maintained as a separate project since 2004. It's home on > SourceForge was removed. I have found sources of the last PyXML > version (0.8.4), but without history. > Did you try asking SourceForge if they still have a backup copy? -- Jan Claeys ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] 3.7.0rc1 Delayed [was] FINAL WEEK FOR 3.7.0 CHANGES!
On May 24, 2018, at 03:23, Ned Deily wrote: > On May 23, 2018, at 09:13, Ned Deily wrote: >> On May 23, 2018, at 07:45, Serhiy Storchaka wrote: >>> Is it possible to add yet one beta instead? >>> CI was broken for few latest days, tests are not passed on my computer >>> still (and fail on some buildbots), updating What's New exposed new >>> features which need additional testing (and maybe fixing or reverting), and >>> I'm not comfortable about some changes which would be harder to fix after >>> the release. >> it is possible but there's no point in doing either another beta or a >> release candidate until we understand and address the current blocking >> issues, like the major buildbot failures. We have another 24 hours until >> rc1 was planned to be tagged. Let's keep working on the known issues and we >> will make a decision then. > An update: thanks to a lot of effort over the past day by a number of > people (including Victor, Serhiy, Christian, Zach, and others I'm sure > I'm forgetting - my apologies), we have addressed all of the "release > blocker" issues and all but one of the persistent failures on the 3.7 > stable buildbots. We should have the couple of remaining "deferred > blockers" including the remaining stable buildbots in green status by > later today. At that point, we will be ready to tag 3.7.0rc1 and begin > producing the release candidate artifacts. Further update: some good news and some changes. The good news is that we have resolutions for all of the previous release and deferred blockers. Thanks to a number of people for continuing to help get the remaining stable buildbot issues taken care of along with some lingering bugs. The not-quite-as-good news is that we have had more discussions about some unexpected incompatibilities that have shown up with downstream user testing with the AST docstrings changes in place (see bpo-32911). We have had some previous discussions about the expected user impact and, earlier in the beta phase, I encouraged us to stay the course with the feature as implemented. But I am now persuaded that we owe it to our users to take one more look at this to make sure we do not force them to make changes for 3.7 and then once again for 3.8. More details are in the bug tracker issue; I strongly encourage those of us who have been involved with this to "vote" there on the proposal to either (A) proceed with the release of the current implementation in 3.7.0 or (B) revert the feature in 3.7.0 and retarget for 3.8. Should the consensus be to revert (B), we will plan to have one more fast-track beta release (b5) prior to the release candidate, in order to allow downstream users to tes t their projects with the removal. PLEASE, keep the discussion about this on the bug tracker (and not here!) and keep it brief so we can move forward quickly. Because of the upcoming 3-day holiday weekend in some countries, I have set Tue 2018-05-29 18:00 UTC as a cutoff for "voting" but, if a clear consensus emerges earlier, we will likely cut the discussion short. So chime in now on the bug tracker if you have a stake in this issue. https://bugs.python.org/issue32911 This does mean that yesterday's "last chance" has been extended a bit, at most a few days. I will let you know as soon as we have made a decision about the feature and will provide updated 3.7.0 schedule info at that time. --Ned -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
