Re: [Python-Dev] [python-committers] 3.6 branch now open only for 3.6.0 release critical fixes and doc updates!

2016-11-22 Thread Victor Stinner
Hi,

2016-11-22 8:24 GMT+01:00 Ned Deily :
> OK, all of the release engineering for 3.6.0b4 is complete.  The 3.6 branch 
> in the cpython repo is now available again but, as noted, *only* for reviewed 
> release critical fixes appropriate for the 3.6.0 final and for final 3.6.0 
> doc updates!

Sorry, I pushed changes before reading your email(s). I expected that
release critical changes would have to be pushed to a different
repository using cherry-pick or something else.

To be clear: Python 3.5 will be frozen as well? Pushing to 3.5
requires to merge into 3.6 (and then merge into default).


Four changes have been pushed after the tag:

(*) https://hg.python.org/cpython/rev/4f6fb9e47f6b
Issue #28023: Fix python-gdb.py didn't support new dict implementation [#28023]

I reviewed Naoki's patch and it LGTM. python-gdb.py was simply 100%
broken without this fix, and I consider that this tool is important
for Python (but I didn't understood correctly the RC rules, sorry)! By
the way, I also broke python-gdb.py with fast calls! I started to work
on a fix, http://bugs.python.org/issue28770


(*) https://hg.python.org/cpython/rev/9b974f988c95
Issue #28023: Fix python-gdb.py on old GDB versions

... My fix for the previous commit. Sadly, it's hard to test on all
GDB versions, but buildbots are here for that :-)



(*) https://hg.python.org/cpython/rev/6b43d15fd2d7
Issue #28727: Fix typo in pattern_richcompare()

Obvious bugfix spotted by Serhiy.


(*) https://hg.python.org/cpython/rev/c2cb70c97163
Issue #28727: Optimize pattern_richcompare() for a==a

This one is a minor optimization suggested by Serhiy.


Should I revert these changes? Or can someone please review them one more time?

Victor
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Stefan Scherfke

Hi all,

I am trying to build a custom Conda installer for Python 3.6.0b4.

I could successfully build an run Python.  However, when I run
the generated Conda installer, it dies with a "Bus error".

It happens when Conda's meta-installer script tries to replace
the build-prefix (e.g., /home/stefan/conda/asdf) with the prefix
of the actual installation (e.g., /tmp/py36).

Therefore, it opens all files in binary mode, reads their contents, 
replaces stuff, and writes the new contents back to the original file.


This works fine with text files but it dies when it hits the first 
binary file.


Here is a minimal example that reproduces the error:

$ /tmp/py36/bin/python
Python 3.6.0b4 (default, Nov 22 2016, 10:32:29)
[GCC 6.2.1 20160916 (Red Hat 6.2.1-2)] on linux
>>>
>>> path = '/tmp/py36/lib/libpython3.6m.so.1.0'
>>> f = open(path, 'wb')
BusError

Can anyone reproduce this?  Is this a compilation error or an issue
with Python itself?

Cheers,
Stefan

PS: If need, I can upload the Conda installer somewhere.  It's ~40MiB.
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Stefan Scherfke



On 22.11.2016 12:52, Stefan Scherfke wrote:


Here is a minimal example that reproduces the error:

$ /tmp/py36/bin/python
Python 3.6.0b4 (default, Nov 22 2016, 10:32:29)
[GCC 6.2.1 20160916 (Red Hat 6.2.1-2)] on linux


path = '/tmp/py36/lib/libpython3.6m.so.1.0'
f = open(path, 'wb')

BusError



This can, of course, not work.  But the Conda installer does something 
like this and it works on Python 3.5 but not on 3.6.  I'm a bit baffled...


Cheers,
Stefan
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Antoine Pitrou
On Tue, 22 Nov 2016 12:52:59 +0100
Stefan Scherfke  wrote:
> Hi all,
> 
> I am trying to build a custom Conda installer for Python 3.6.0b4.
> 
> I could successfully build an run Python.  However, when I run
> the generated Conda installer, it dies with a "Bus error".
> 
> It happens when Conda's meta-installer script tries to replace
> the build-prefix (e.g., /home/stefan/conda/asdf) with the prefix
> of the actual installation (e.g., /tmp/py36).
> 
> Therefore, it opens all files in binary mode, reads their contents, 
> replaces stuff, and writes the new contents back to the original file.
> 
> This works fine with text files but it dies when it hits the first 
> binary file.
> 
> Here is a minimal example that reproduces the error:
> 
> $ /tmp/py36/bin/python
> Python 3.6.0b4 (default, Nov 22 2016, 10:32:29)
> [GCC 6.2.1 20160916 (Red Hat 6.2.1-2)] on linux
>  >>>
>  >>> path = '/tmp/py36/lib/libpython3.6m.so.1.0'
>  >>> f = open(path, 'wb')  
> BusError

You'll have to investigate yourself.  First enable core dumps ("ulimit
-c unlimited"), then run gdb on the resulting core dump.

(or run Python directly under gdb)

Regards

Antoine.


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread INADA Naoki
On Wed, Nov 23, 2016 at 1:00 AM, Stefan Scherfke
 wrote:
>
>
> On 22.11.2016 12:52, Stefan Scherfke wrote:
>>
>>
>> Here is a minimal example that reproduces the error:
>>
>> $ /tmp/py36/bin/python
>> Python 3.6.0b4 (default, Nov 22 2016, 10:32:29)
>> [GCC 6.2.1 20160916 (Red Hat 6.2.1-2)] on linux
>
>
> path = '/tmp/py36/lib/libpython3.6m.so.1.0'
> f = open(path, 'wb')
>>
>> BusError
>>
>
> This can, of course, not work.  But the Conda installer does something like
> this and it works on Python 3.5 but not on 3.6.  I'm a bit baffled...
>

I don't know about Conda.  But this BusError is normal behavior of Linux.
While executing binary, truncating the binary cause BusError.
I can reproduce it with Python 3.5

$ ldd bin/python3.5
...
libpython3.5m.so.1.0 =>
/home/inada-n/local/py35/lib/libpython3.5m.so.1.0 (0x7fdefa188000)
...

$ ll lib/
...
lrwxrwxrwx  1 inada-n inada-n   20 11月 23 02:46 libpython3.5m.so
-> libpython3.5m.so.1.0*
-r-xr-xr-x  1 inada-n inada-n 12497584 11月 23 02:46 libpython3.5m.so.1.0*
...
$ chmod u+w lib/libpython3.5m.so.1.0
$ bin/python3.5
Python 3.5.2+ (3.5:0ee76f3afd70, Nov 23 2016, 02:39:08)
[GCC 6.2.0 20161005] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> f = open('./lib/libpython3.5m.so.1.0', 'wb')
Bus error (core dumped)


-- 
INADA Naoki  
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Ned Deily
On Nov 22, 2016, at 06:52, Stefan Scherfke  
wrote:
> /tmp/py36/bin/python

In addition to the other comments, I'd check whether the new python is built 
with --enable-shared.  If so, it's probably not a good idea to be writing to 
its library while running whereas, if it's not a shared build, it may not 
matter.

--
  Ned Deily
  n...@python.org -- []

___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Victor Stinner
It's not bug but a feature :-) Python doesn't protect yourself against
mistakes :-)

Victor
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Bus error in Python 3.6.0beta

2016-11-22 Thread Chris Angelico
On Wed, Nov 23, 2016 at 6:20 AM, Victor Stinner
 wrote:
> It's not bug but a feature :-) Python doesn't protect yourself against
> mistakes :-)

AIUI the normal way to protect yourself is to unlink (remove) the file
and create it from scratch, rather than truncate it.

ChrisA
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] Python 3.6.0 download stats

2016-11-22 Thread Steve Dower
For anyone who's interested, I ran a quick analysis of the download 
stats from python.org for CPython 3.6.0 releases since September.


As Mac and Linux users typically get their downloads from elsewhere, 
those stats are on the low side. However, we've been getting roughly 10k 
downloads/day for Windows, and even though it's been out less than 24 
hours, 3.6.0b4 is already


There's a PDF with charts at:

https://pythonbuilds.blob.core.windows.net/temp/Python%203.6.0%20Beta%20Downloads.pdf 



My spreadsheet is at 
https://pythonbuilds.blob.core.windows.net/temp/360Beta%20Analysis.xlsx 
(Excel format), if you want to see actual numbers. But there is likely 
some lost data in here and almost certainly some hits counted that 
shouldn't be (e.g. the spike on the 19th of September is *probably* a 
broken browser update causing multiple hits for each download - I 
haven't gone through UA data to figure it out yet, but Chrome has 
definitely done this in the past).


Treat the actual numbers with a grain of salt, but overall it looks like 
we've had pretty good usage of the prerelease versions of 3.6.


Cheers,
Steve
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] [python-committers] 3.6 branch now open only for 3.6.0 release critical fixes and doc updates!

2016-11-22 Thread Raymond Hettinger

> On Nov 22, 2016, at 6:57 AM, Victor Stinner  wrote:
> 
> Should I revert these changes? 

I don't think reverting any of these would improve the release.
I vote for them to stay.


Raymond





___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] [python-committers] 3.6 branch now open only for 3.6.0 release critical fixes and doc updates!

2016-11-22 Thread Victor Stinner
Ok, thank you Raymond for checking.

Victor

Le 23 nov. 2016 05:25, "Raymond Hettinger"  a
écrit :

>
> > On Nov 22, 2016, at 6:57 AM, Victor Stinner 
> wrote:
> >
> > Should I revert these changes?
>
> I don't think reverting any of these would improve the release.
> I vote for them to stay.
>
>
> Raymond
>
>
>
>
>
>
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com